Remove unnecessary semicolons (Attempt 2) (#10020)

This is another PR towards the goal of getting Z3 to compile cleanly
when included via FetchContents into clang-tidy, which uses a pretty
strict set of warnings.

This is a second version of https://github.com/Z3Prover/z3/pull/9957. I
address @NikolajBjorner 's comments about not changing the semicolons
after macro invocations, because some editors work better with them
present. It now, to the best of my ability, only deletes semis:

* after the closing brace of namespace decl.
* after the closing brace of an extern "C" decl.
* after a function definition.

This PR is very large, but it consists entirely of deletions of
semicolons in these situations.

(If there was a way to update the previous PR, which had been closed,
and that is preferable, please let me know. I couldn't figure it out.)

src/util/sat_literal.h

@@ -190,7 +190,7 @@ namespace sat {
         return out << mk_lits_pp(ls.size(), ls.data());
     }
 
-};
+}
 
 namespace std {
 
@@ -198,4 +198,4 @@ namespace std {
         if (l.sign()) return "-" + to_string(l.var());
         return to_string(l.var());
     }
-};
+}

src/util/sat_sls.h

@@ -36,6 +36,6 @@ namespace sat {
     inline std::ostream& operator<<(std::ostream& out, clause_info const& ci) {
         return out << ci.m_clause << " w: " << ci.m_weight << " nt: " << ci.m_num_trues;
     }
-};
+}
 
 

src/util/sign.h

@@ -18,7 +18,7 @@ Author:
 #pragma once
 
 typedef enum { sign_neg = -1, sign_zero = 0, sign_pos = 1} sign;
-static inline sign operator-(sign s) { switch (s) { case sign_neg: return sign_pos; case sign_pos: return sign_neg; default: return sign_zero; } };
+static inline sign operator-(sign s) { switch (s) { case sign_neg: return sign_pos; case sign_pos: return sign_neg; default: return sign_zero; } }
 static inline sign to_sign(int s) { return s == 0 ? sign_zero : (s > 0 ? sign_pos : sign_neg); }
 static inline sign operator*(sign a, sign b) { return to_sign((int)a * (int)b); }
 static inline bool is_zero(sign s) { return s == sign_zero; }

src/util/util.h

@@ -270,7 +270,7 @@ public:
     scoped_ptr& operator=(scoped_ptr&& other) noexcept {
         *this = other.detach();
         return *this;
-    };
+    }
 
     T * detach() {
         T* tmp = m_ptr;