Remove unnecessary semicolons (Attempt 2) (#10020)

This is another PR towards the goal of getting Z3 to compile cleanly
when included via FetchContents into clang-tidy, which uses a pretty
strict set of warnings.

This is a second version of https://github.com/Z3Prover/z3/pull/9957. I
address @NikolajBjorner 's comments about not changing the semicolons
after macro invocations, because some editors work better with them
present. It now, to the best of my ability, only deletes semis:

* after the closing brace of namespace decl.
* after the closing brace of an extern "C" decl.
* after a function definition.

This PR is very large, but it consists entirely of deletions of
semicolons in these situations.

(If there was a way to update the previous PR, which had been closed,
and that is preferable, please let me know. I couldn't figure it out.)

src/tactic/bv/bv_bound_chk_tactic.cpp

@@ -26,7 +26,7 @@ struct bv_bound_chk_stats {
     unsigned            m_unsats;
     unsigned            m_singletons;
     unsigned            m_reduces;
-    bv_bound_chk_stats() : m_unsats(0), m_singletons(0), m_reduces(0) {};
+    bv_bound_chk_stats() : m_unsats(0), m_singletons(0), m_reduces(0) {}
 };
 
 struct bv_bound_chk_rewriter_cfg : public default_rewriter_cfg {

src/tactic/core/ctx_simplify_tactic.h

@@ -57,7 +57,7 @@ public:
         virtual simplifier * translate(ast_manager & m) = 0;
         virtual unsigned scope_level() const = 0;
         virtual void updt_params(params_ref const & p) {}
-        void set_occs(goal_num_occurs& occs) { m_occs = &occs; };
+        void set_occs(goal_num_occurs& occs) { m_occs = &occs; }
         bool shared(expr* t) const;
     };
     

src/tactic/core/symmetry_reduce_tactic.cpp

@@ -341,7 +341,7 @@ private:
     }
 
     typedef hashtable<unsigned, u_hash, u_eq> uint_set;
-    typedef obj_map<app, uint_set*> app_siblings;;
+    typedef obj_map<app, uint_set*> app_siblings;
 
     class siblings {
         app_map const& m_colors;

src/tactic/tactical.cpp

@@ -1012,7 +1012,7 @@ public:
             result.reset(); // assumes in is not strenthened to one of the branches
             throw tactic_exception("failed-if-branching tactical");
         }
-    };    
+    }    
 
     tactic * translate(ast_manager & m) override { 
         tactic * new_t = m_t->translate(m);