Remove unnecessary semicolons (Attempt 2) (#10020)

This is another PR towards the goal of getting Z3 to compile cleanly
when included via FetchContents into clang-tidy, which uses a pretty
strict set of warnings.

This is a second version of https://github.com/Z3Prover/z3/pull/9957. I
address @NikolajBjorner 's comments about not changing the semicolons
after macro invocations, because some editors work better with them
present. It now, to the best of my ability, only deletes semis:

* after the closing brace of namespace decl.
* after the closing brace of an extern "C" decl.
* after a function definition.

This PR is very large, but it consists entirely of deletions of
semicolons in these situations.

(If there was a way to update the previous PR, which had been closed,
and that is preferable, please let me know. I couldn't figure it out.)

src/qe/mbp/mbp_arith.h

@@ -51,5 +51,5 @@ namespace mbp {
     bool arith_project(model& model, app* var, expr_ref_vector& lits);
 
 
-};
+}
 

src/qe/mbp/mbp_arrays.cpp

@@ -1500,4 +1500,4 @@ namespace mbp {
     }
 
 
-};
+}

src/qe/mbp/mbp_arrays.h

@@ -40,5 +40,5 @@ namespace mbp {
 
     };
 
-};
+}
 

src/qe/mbp/mbp_datatypes.h

@@ -39,5 +39,5 @@ namespace mbp {
 
     };
 
-};
+}
 

src/qe/mbp/mbp_euf.h

@@ -31,5 +31,5 @@ namespace mbp {
 
     };
 
-};
+}
 

src/qe/mbp/mbp_plugin.h

@@ -69,7 +69,7 @@ namespace mbp {
         virtual bool solve(model& model, app_ref_vector& vars, expr_ref_vector& lits) { return false; }
         virtual family_id get_family_id() { return null_family_id; }
 
-        virtual bool project(model& model, app_ref_vector& vars, expr_ref_vector& lits) { return false; };
+        virtual bool project(model& model, app_ref_vector& vars, expr_ref_vector& lits) { return false; }
 
         /**
            \brief project vars modulo model, return set of definitions for eliminated variables.

src/qe/mbp/mbp_tg_plugins.h

@@ -26,9 +26,9 @@ class mbp_tg_plugin {
 public:
     // iterate through all terms in m_tg and apply all theory MBP rules once
     // returns true if any rules were applied
-    virtual bool apply() { return false; };
+    virtual bool apply() { return false; }
     virtual ~mbp_tg_plugin() = default;
-    virtual void use_model() { };
-    virtual void get_new_vars(app_ref_vector*&) { };
-    virtual family_id get_family_id() const { return null_family_id; };
+    virtual void use_model() { }
+    virtual void get_new_vars(app_ref_vector*&) { }
+    virtual family_id get_family_id() const { return null_family_id; }
 };

src/qe/nlarith_util.cpp

@@ -2022,6 +2022,6 @@ namespace nlarith {
     void util::get_sign_branches(literal_set& lits, eval& ev, ptr_vector<branch>& branches) {
         m_imp->get_sign_branches(lits, ev, branches);
     }
-};
+}
 
 

src/qe/nlarith_util.h

@@ -143,5 +143,5 @@ namespace nlarith {
 
     };
 
-};
+}
 

src/qe/nlqsat.cpp

@@ -955,7 +955,7 @@ namespace qe {
             return alloc(nlqsat, m, m_mode, m_params);
         }
     };
-};
+}
 
 tactic * mk_nlqsat_tactic(ast_manager & m, params_ref const& p) {
     return alloc(qe::nlqsat, m, qe::qsat_t, p);

src/qe/qe.h

@@ -367,6 +367,6 @@ namespace qe {
 
     };
 
-};
+}
 
 

src/qe/qe_mbi.cpp

@@ -613,4 +613,4 @@ namespace qe {
         return pogo(pA, pB, itp);
     }
 
-};
+}

src/qe/qe_mbi.h

@@ -156,4 +156,4 @@ namespace qe {
         lbool pogo(solver_factory& sf, expr* a, expr* b, expr_ref& itp);
     };
 
-};
+}

src/qe/qsat.cpp

@@ -1503,7 +1503,7 @@ namespace qe {
     void qmax::collect_statistics(statistics& st) const {
         m_imp->m_qsat.collect_statistics(st);
     }
-};
+}
 
 tactic * mk_qsat_tactic(ast_manager& m, params_ref const& p) {
     return alloc(qe::qsat, m, p, qe::qsat_sat);