Remove unnecessary semicolons (Attempt 2) (#10020)

This is another PR towards the goal of getting Z3 to compile cleanly
when included via FetchContents into clang-tidy, which uses a pretty
strict set of warnings.

This is a second version of https://github.com/Z3Prover/z3/pull/9957. I
address @NikolajBjorner 's comments about not changing the semicolons
after macro invocations, because some editors work better with them
present. It now, to the best of my ability, only deletes semis:

* after the closing brace of namespace decl.
* after the closing brace of an extern "C" decl.
* after a function definition.

This PR is very large, but it consists entirely of deletions of
semicolons in these situations.

(If there was a way to update the previous PR, which had been closed,
and that is preferable, please let me know. I couldn't figure it out.)

src/nlsat/nlsat_assignment.h

@@ -97,5 +97,5 @@ namespace nlsat {
         bool contains(var x) const override { return x != m_y && m_assignment.is_assigned(x); }
         anum const & operator()(var x) const override { return m_assignment.value(x); }
     };
-};
+}
 

src/nlsat/nlsat_clause.cpp

@@ -49,4 +49,4 @@ namespace nlsat {
         return false;
     }
 
-};
+}

src/nlsat/nlsat_clause.h

@@ -66,5 +66,5 @@ namespace nlsat {
 
     typedef ptr_vector<clause> clause_vector;
 
-};
+}
 

src/nlsat/nlsat_evaluator.cpp

@@ -699,4 +699,4 @@ namespace nlsat {
     void evaluator::pop(unsigned num_scopes) {
         // do nothing
     }
-};
+}

src/nlsat/nlsat_evaluator.h

@@ -57,5 +57,5 @@ namespace nlsat {
         void pop(unsigned num_scopes);
     };
     
-};
+}
 

src/nlsat/nlsat_explain.cpp

@@ -1784,7 +1784,7 @@ namespace nlsat {
         m_imp->test_root_literal(k, y, i, p, result);
     }
 
-};
+}
 #ifdef Z3DEBUG
 #include <iostream>
 void pp(nlsat::explain::imp & ex, unsigned num, nlsat::literal const * ls) {

src/nlsat/nlsat_explain.h

@@ -108,4 +108,4 @@ namespace nlsat {
         void test_root_literal(atom::kind k, var y, unsigned i, poly* p, scoped_literal_vector & result);
     };
 
-};
+}

src/nlsat/nlsat_interval_set.cpp

@@ -794,4 +794,4 @@ namespace nlsat {
             out << "*";
         return out;
     }
-};
+}

src/nlsat/nlsat_interval_set.h

@@ -118,5 +118,5 @@ namespace nlsat {
         return out;
     }
 
-};
+}
 

src/nlsat/nlsat_justification.h

@@ -106,5 +106,5 @@ namespace nlsat {
             a.deallocate(obj_sz, ptr);
         }
     }
-};
+}
 

src/nlsat/nlsat_scoped_literal_vector.h

@@ -107,5 +107,5 @@ namespace nlsat {
         operator literal const &() const { return m_lit; }
         void neg() { m_lit.neg(); }
     };
-};
+}
 

src/nlsat/nlsat_simplify.cpp

@@ -826,4 +826,4 @@ namespace nlsat {
         (*m_imp)();
     }
 
-};
+}

src/nlsat/nlsat_solver.cpp

@@ -4784,4 +4784,4 @@ namespace nlsat {
     unsigned solver::lws_spt_threshold() const { return m_imp->m_lws_spt_threshold; }
     bool solver::lws_witness_subs_lc() const { return m_imp->m_lws_witness_subs_lc; }
     bool solver::lws_witness_subs_disc() const { return m_imp->m_lws_witness_subs_disc; }
-};
+}

src/nlsat/nlsat_solver.h

@@ -316,4 +316,4 @@ namespace nlsat {
 
     };
 
-};
+}

src/nlsat/nlsat_types.cpp

@@ -67,4 +67,4 @@ namespace nlsat {
         return a1->m_kind == a2->m_kind && a1->m_x == a2->m_x && a1->m_i == a2->m_i && a1->m_p == a2->m_p;
     }
 
-};
+}

src/nlsat/nlsat_types.h

@@ -26,7 +26,7 @@ Revision History:
 namespace algebraic_numbers {
     class anum;
     class manager;
-};
+}
 
 namespace nlsat {
 #define NLSAT_VB_LVL 10
@@ -204,5 +204,5 @@ namespace nlsat {
         if (s == 0) return 0;
         return 1;
     }
-};
+}