Remove unnecessary semicolons (Attempt 2) (#10020)

This is another PR towards the goal of getting Z3 to compile cleanly
when included via FetchContents into clang-tidy, which uses a pretty
strict set of warnings.

This is a second version of https://github.com/Z3Prover/z3/pull/9957. I
address @NikolajBjorner 's comments about not changing the semicolons
after macro invocations, because some editors work better with them
present. It now, to the best of my ability, only deletes semis:

* after the closing brace of namespace decl.
* after the closing brace of an extern "C" decl.
* after a function definition.

This PR is very large, but it consists entirely of deletions of
semicolons in these situations.

(If there was a way to update the previous PR, which had been closed,
and that is preferable, please let me know. I couldn't figure it out.)

src/ast/simplifiers/distribute_forall.cpp

@@ -101,5 +101,5 @@ void distribute_forall_simplifier::reduce() {
         if (r != d.fml())
             m_fmls.update(idx, dependent_expr(m, r, mp(d.pr(), pr), d.dep()));
     }
-};
+}
 

src/ast/simplifiers/propagate_values.cpp

@@ -62,7 +62,7 @@ void propagate_values::add_sub(dependent_expr const& de) {
         else if (m.is_value(y) && m_shared.is_shared(x))
             m_subst.insert(x, y, dep);
     }
-};
+}
 
 void propagate_values::reduce() {
     m_shared.reset();