Remove unnecessary semicolons (Attempt 2) (#10020)

This is another PR towards the goal of getting Z3 to compile cleanly
when included via FetchContents into clang-tidy, which uses a pretty
strict set of warnings.

This is a second version of https://github.com/Z3Prover/z3/pull/9957. I
address @NikolajBjorner 's comments about not changing the semicolons
after macro invocations, because some editors work better with them
present. It now, to the best of my ability, only deletes semis:

* after the closing brace of namespace decl.
* after the closing brace of an extern "C" decl.
* after a function definition.

This PR is very large, but it consists entirely of deletions of
semicolons in these situations.

(If there was a way to update the previous PR, which had been closed,
and that is preferable, please let me know. I couldn't figure it out.)

src/ast/dl_decl_plugin.cpp

@@ -648,7 +648,7 @@ namespace datalog {
             m_fid = m.mk_family_id(symbol("datalog_relation"));
         }
         return m_fid;
-    };
+    }
 
     arith_util& dl_decl_util::arith() const {
         if (!m_arith) m_arith = alloc(arith_util, m);
@@ -788,4 +788,4 @@ namespace datalog {
         return m.mk_app(f, num_args, args);
     }
 
-};
+}