mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-02-19 23:14:40 +00:00
Code Activity

Migrate codebase to std::string_view (except z3++.h) (#8266)

Browse source 
* Initial plan

* Update z3 codebase to use std::string_view (except z3++.h)

- Updated params.cpp/h to use string_view internally for parameter descriptions
- Updated trace.h/cpp to accept string_view for trace tag functions
- Updated hash.h/cpp to use string_view for string_hash function
- Updated all callers of string_hash to use string_view
- Properly handled nullptr to empty string_view conversions
- All tests passing

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Add missing string_view includes to headers

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-21 09:30:41 -08:00 • committed by Nikolaj Bjorner
parent 260db09e25
commit 671faf8f1c
20 changed files with 85 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/util/hash.cpp
View file

@ -29,8 +29,10 @@ static unsigned read_unsigned(const char *s) {
// I'm using Bob Jenkin's hash function.
// http://burtleburtle.net/bob/hash/doobs.html
unsigned string_hash(const char * str, unsigned length, unsigned init_value) {
unsigned string_hash(std::string_view str, unsigned init_value) {
unsigned a, b, c, len;
const char * data = str.data();
unsigned length = static_cast<unsigned>(str.length());
/* Set up the internal state */
len = length;
@ -40,49 +42,49 @@ unsigned string_hash(const char * str, unsigned length, unsigned init_value) {
/*---------------------------------------- handle most of the key */
SASSERT(sizeof(unsigned) == 4);
while (len >= 12) {
a += read_unsigned(str);
b += read_unsigned(str+4);
c += read_unsigned(str+8);
a += read_unsigned(data);
b += read_unsigned(data+4);
c += read_unsigned(data+8);
mix(a,b,c);
str += 12; len -= 12;
data += 12; len -= 12;
}
/*------------------------------------- handle the last 11 bytes */
c += length;
switch(len) { /* all the case statements fall through */
case 11:
c+=((unsigned)str[10]<<24);
c+=((unsigned)data[10]<<24);
Z3_fallthrough;
case 10:
c+=((unsigned)str[9]<<16);
c+=((unsigned)data[9]<<16);
Z3_fallthrough;
case 9 :
c+=((unsigned)str[8]<<8);
c+=((unsigned)data[8]<<8);
Z3_fallthrough;
/* the first byte of c is reserved for the length */
case 8 :
b+=((unsigned)str[7]<<24);
b+=((unsigned)data[7]<<24);
Z3_fallthrough;
case 7 :
b+=((unsigned)str[6]<<16);
b+=((unsigned)data[6]<<16);
Z3_fallthrough;
case 6 :
b+=((unsigned)str[5]<<8);
b+=((unsigned)data[5]<<8);
Z3_fallthrough;
case 5 :
b+=str[4];
b+=data[4];
Z3_fallthrough;
case 4 :
a+=((unsigned)str[3]<<24);
a+=((unsigned)data[3]<<24);
Z3_fallthrough;
case 3 :
a+=((unsigned)str[2]<<16);
a+=((unsigned)data[2]<<16);
Z3_fallthrough;
case 2 :
a+=((unsigned)str[1]<<8);
a+=((unsigned)data[1]<<8);
Z3_fallthrough;
case 1 :
a+=str[0];
a+=data[0];
/* case 0: nothing left to add */
break;
}