clear tactic user propagate state on solver destructor

src/smt/tactic/smt_tactic_core.cpp

@@ -413,16 +413,21 @@ public:
         }    
     }
 
-    void user_propagate_init(
+    void user_propagate_clear() override {
-        void* ctx,
+        m_user_ctx = nullptr;
-        user_propagator::push_eh_t& push_eh,
-        user_propagator::pop_eh_t& pop_eh,
-        user_propagator::fresh_eh_t& fresh_eh) override {
         m_vars.reset();
         m_fixed_eh = nullptr;
         m_final_eh = nullptr;
         m_eq_eh = nullptr;
         m_diseq_eh = nullptr;
+    }
+
+    void user_propagate_init(
+        void* ctx,
+        user_propagator::push_eh_t& push_eh,
+        user_propagator::pop_eh_t& pop_eh,
+        user_propagator::fresh_eh_t& fresh_eh) override {
+        user_propagate_clear();
         m_user_ctx = ctx;
         m_push_eh = push_eh;
         m_pop_eh = pop_eh;

src/solver/tactic2solver.cpp

@@ -112,6 +112,11 @@ public:
         return m_tactic->user_propagate_register(e);
     }
 
+    void user_propagate_clear() override {
+        if (m_tactic)
+            m_tactic->user_propagate_clear();
+    }
+
 
     expr_ref_vector cube(expr_ref_vector& vars, unsigned ) override {
         set_reason_unknown("cubing is not supported on tactics");
@@ -148,6 +153,7 @@ tactic2solver::tactic2solver(ast_manager & m, tactic * t, params_ref const & p,
 }
 
 tactic2solver::~tactic2solver() {
+    user_propagate_clear();
 }
 
 void tactic2solver::updt_params(params_ref const & p) {

src/tactic/tactical.cpp

@@ -192,6 +192,10 @@ public:
         return m_t2->user_propagate_register(e);
     }
 
+    void user_propagate_clear() override {
+        m_t2->user_propagate_clear();
+    }
+
 };
 
 tactic * and_then(tactic * t1, tactic * t2) {

src/tactic/user_propagator_base.h

@@ -56,6 +56,9 @@ namespace user_propagator {
         virtual unsigned user_propagate_register(expr* e) { 
             throw default_exception("user-propagators are only supported on the SMT solver");
         }
+
+        virtual void user_propagate_clear() {
+        }
        
     };