Remove empty leaf destructors. (#6211)

src/tactic/arith/add_bounds_tactic.cpp

@@ -51,7 +51,6 @@ public:
     result operator()(goal const & g) override {
         return is_unbounded(g);
     }
-    ~is_unbounded_probe() override {}
 };
 
 probe * mk_is_unbounded_probe() {

src/tactic/arith/card2bv_tactic.cpp

@@ -39,9 +39,6 @@ public:
         return alloc(card2bv_tactic, m, m_params);
     }
 
-    ~card2bv_tactic() override {
-    }
-
     char const* name() const override { return "card2bv"; }
 
     void updt_params(params_ref const & p) override {

src/tactic/arith/eq2bv_tactic.cpp

@@ -165,10 +165,6 @@ public:
         m_bounds(m) {
     }
 
-    ~eq2bv_tactic() override {
-    }
-        
-        
     void updt_params(params_ref const & p) override {
     }
     

src/tactic/arith/nla2bv_tactic.cpp

@@ -434,9 +434,6 @@ public:
         return alloc(nla2bv_tactic, m_params);
     }
 
-    ~nla2bv_tactic() override {
-    }
-
     char const* name() const override { return "nla2bv"; }
 
     void updt_params(params_ref const & p) override {

src/tactic/arith/purify_arith_tactic.cpp

@@ -902,9 +902,6 @@ public:
     tactic * translate(ast_manager & m) override {
         return alloc(purify_arith_tactic, m, m_params);
     }
-        
-    ~purify_arith_tactic() override {
-    }
 
     char const* name() const override { return "purify_arith"; }
 

src/tactic/bv/bit_blaster_model_converter.cpp

@@ -50,10 +50,7 @@ struct bit_blaster_model_converter : public model_converter {
         for (func_decl* f : newbits) 
             m_newbits.push_back(f);
     }
-    
-    ~bit_blaster_model_converter() override {
-    }
-    
+
     void collect_bits(obj_hashtable<func_decl> & bits) {
         unsigned sz = m_bits.size();
         for (unsigned i = 0; i < sz; i++) {

src/tactic/bv/bv_bound_chk_tactic.cpp

@@ -109,8 +109,6 @@ struct bv_bound_chk_rewriter : public rewriter_tpl<bv_bound_chk_rewriter_cfg> {
         updt_params(p);
     }
 
-    ~bv_bound_chk_rewriter() override {}
-
     void updt_params(params_ref const & _p) {
         m_cfg.updt_params(_p);
     }

src/tactic/bv/dt2bv_tactic.cpp

@@ -93,7 +93,6 @@ class dt2bv_tactic : public tactic {
     struct sort_pred : public i_sort_pred {
         dt2bv_tactic& m_t;
         sort_pred(dt2bv_tactic& t): m_t(t) {}
-        ~sort_pred() override {}
         bool operator()(sort* s) override {
             return m_t.m_fd_sorts.contains(s);
         }

src/tactic/converter.h

@@ -57,8 +57,6 @@ protected:
 
 public:
     concat_converter(T * c1, T * c2):m_c1(c1), m_c2(c2) {}
-    
-    ~concat_converter() override {}
 
     void cancel() override {
         m_c2->cancel();

src/tactic/core/cofactor_term_ite_tactic.cpp

@@ -50,7 +50,6 @@ public:
         return alloc(cofactor_term_ite_tactic, m, m_params);
     }
 
-    ~cofactor_term_ite_tactic() override {}
     char const* name() const override { return "cofactor"; }
     void updt_params(params_ref const & p) override { m_params.append(p); m_elim_ite.updt_params(m_params); }
     void collect_param_descrs(param_descrs & r) override { m_elim_ite.collect_param_descrs(r); }

src/tactic/core/collect_statistics_tactic.cpp

@@ -52,8 +52,6 @@ public:
         m_params(p) {
     }
 
-    ~collect_statistics_tactic() override {}
-
     char const* name() const override { return "collect_statistics"; }
 
     tactic * translate(ast_manager & m_) override {

src/tactic/core/ctx_simplify_tactic.cpp

@@ -32,7 +32,6 @@ class ctx_propagate_assertions : public ctx_simplify_tactic::simplifier {
     void assert_eq_core(expr * t, app * val);
 public:
     ctx_propagate_assertions(ast_manager& m);
-    ~ctx_propagate_assertions() override {}
     bool assert_expr(expr * t, bool sign) override;
     bool simplify(expr* t, expr_ref& result) override;
     void push();

src/tactic/core/dom_simplify_tactic.cpp

@@ -541,7 +541,6 @@ class expr_substitution_simplifier : public dom_simplifier {
 
 public:
     expr_substitution_simplifier(ast_manager& m): m(m), m_subst(m), m_scoped_substitution(m_subst), m_trail(m) {}
-    ~expr_substitution_simplifier() override {}
 
     bool assert_expr(expr * t, bool sign) override {
         expr* tt;

src/tactic/core/nnf_tactic.cpp

@@ -47,8 +47,6 @@ public:
         return alloc(nnf_tactic, m_params);
     }
 
-    ~nnf_tactic() override {}
-
     char const* name() const override { return "nnf"; }
 
     void updt_params(params_ref const & p) override { m_params.append(p); }

src/tactic/core/pb_preprocess_tactic.cpp

@@ -102,8 +102,6 @@ public:
     pb_preprocess_tactic(ast_manager& m, params_ref const& p = params_ref()): 
         m(m), m_trail(m), pb(m), m_r(m) {}
 
-    ~pb_preprocess_tactic() override {}
-
     tactic * translate(ast_manager & m) override {
         return alloc(pb_preprocess_tactic, m);
     }

src/tactic/core/reduce_invertible_tactic.cpp

@@ -45,8 +45,6 @@ public:
         m_arith(m)
     {}
 
-    ~reduce_invertible_tactic() override { }
-
     char const* name() const override { return "reduce_invertible"; }
 
     tactic * translate(ast_manager & m) override {

src/tactic/core/special_relations_tactic.h

@@ -47,8 +47,6 @@ public:
     special_relations_tactic(ast_manager & m, params_ref const & ref = params_ref()): 
         m(m), m_params(ref), m_pm(m) {}
 
-    ~special_relations_tactic() override {}
-
     void updt_params(params_ref const & p) override { m_params.append(p); }
     
     void collect_param_descrs(param_descrs & r) override { }

src/tactic/core/split_clause_tactic.cpp

@@ -52,8 +52,6 @@ class split_clause_tactic : public tactic {
         split_pc(ast_manager & m, app * cls, proof * pr):m_clause(cls, m), m_clause_pr(pr, m) {
         }
 
-        ~split_pc() override { }
-
         proof_ref operator()(ast_manager & m, unsigned num_source, proof * const * source) override {
             // Let m_clause be of the form (l_0 or ... or l_{num_source - 1})
             // Each source[i] proof is a proof for "false" using l_i as a hypothesis
@@ -87,9 +85,6 @@ public:
         t->m_largest_clause = m_largest_clause;
         return t;
     }
-    
-    ~split_clause_tactic() override {
-    }
 
     char const* name() const override { return "split_clause"; }
 

src/tactic/equiv_proof_converter.h

@@ -32,8 +32,6 @@ public:
 
     equiv_proof_converter(ast_manager& m): m(m), m_replace(m) {}
 
-    ~equiv_proof_converter() override {}
-
     proof_ref operator()(ast_manager & m, unsigned num_source, proof * const * source) override {
         return m_replace(m, num_source, source);
     }

src/tactic/fd_solver/enum2bv_solver.cpp

@@ -46,8 +46,6 @@ public:
         solver::updt_params(p);
     }
 
-    ~enum2bv_solver() override {}
-
     solver* translate(ast_manager& dst_m, params_ref const& p) override {   
         solver* result = alloc(enum2bv_solver, dst_m, p, m_solver->translate(dst_m, p));
         model_converter_ref mc = external_model_converter();

src/tactic/fd_solver/pb2bv_solver.cpp

@@ -46,8 +46,6 @@ public:
         solver::updt_params(p);
     }
 
-    ~pb2bv_solver() override {}
-
     solver* translate(ast_manager& dst_m, params_ref const& p) override {
         flush_assertions();
         solver* result = alloc(pb2bv_solver, dst_m, p, m_solver->translate(dst_m, p));

src/tactic/fd_solver/smtfd_solver.cpp

@@ -1867,9 +1867,7 @@ namespace smtfd {
             updt_params(p);
             add_toggle(m.mk_true());
         }
-        
-        ~solver() override {}
-        
+
         ::solver* translate(ast_manager& dst_m, params_ref const& p) override {
             solver* result = alloc(solver, m_indent, dst_m, p);
             if (m_fd_sat_solver) result->m_fd_sat_solver = m_fd_sat_solver->translate(dst_m, p);

src/tactic/fpa/qffp_tactic.cpp

@@ -70,7 +70,6 @@ public:
     result operator()(goal const & g) override {
         return !test<is_non_fp_qfnra_predicate>(g);
     }
-    ~is_fp_qfnra_probe() override {}
 };
 
 probe * mk_is_fp_qfnra_probe() {
@@ -145,8 +144,6 @@ public:
     result operator()(goal const & g) override {
         return !test<is_non_qffp_predicate>(g);
     }
-
-    ~is_qffp_probe() override {}
 };
 
 probe * mk_is_qffp_probe() {

src/tactic/fpa/qffplra_tactic.cpp

@@ -82,8 +82,6 @@ public:
             test<is_fpa_function>(g) && 
             !test<is_non_qffplra_predicate>(g);
     }
-
-    ~is_qffplra_probe() override {}
 };
 
 probe * mk_is_qffplra_probe() {

src/tactic/model_converter.cpp

@@ -136,8 +136,6 @@ public:
 
     model2mc(model * m, labels_vec const & r):m_model(m), m_labels(r) {}
 
-    ~model2mc() override {}
-
     void operator()(model_ref & m) override {
         if (!m || !m_model) {
             m = m_model;

src/tactic/portfolio/smt_strategic_solver.cpp

@@ -130,8 +130,7 @@ class smt_strategic_solver_factory : public solver_factory {
     symbol m_logic;
 public:
     smt_strategic_solver_factory(symbol const & logic):m_logic(logic) {}
-    
-    ~smt_strategic_solver_factory() override {}
+
     solver * operator()(ast_manager & m, params_ref const & p, bool proofs_enabled, bool models_enabled, bool unsat_core_enabled, symbol const & logic) override {
         symbol l;
         if (m_logic != symbol::null)

src/tactic/portfolio/solver_subsumption_tactic.cpp

@@ -131,8 +131,6 @@ public:
         return alloc(solver_subsumption_tactic, other_m, m_params);
     }
 
-    ~solver_subsumption_tactic() override {}
-
     char const* name() const override { return "solver_subsumption"; }
 
     void updt_params(params_ref const& p) override { 

src/tactic/proof_converter.cpp

@@ -86,7 +86,6 @@ class proof2pc : public proof_converter {
     proof_ref m_pr;
 public:
     proof2pc(ast_manager & m, proof * pr):m_pr(pr, m) {}
-    ~proof2pc() override {}
 
     proof_ref operator()(ast_manager & m, unsigned num_source, proof * const * source) override {
         SASSERT(num_source == 0);

src/tactic/proof_converter.h

@@ -25,7 +25,6 @@ class goal;
 
 class proof_converter : public converter {
 public:
-    ~proof_converter() override { }
     virtual proof_ref operator()(ast_manager & m, unsigned num_source, proof * const * source) = 0;
     virtual proof_converter * translate(ast_translation & translator) = 0;
 };

src/tactic/replace_proof_converter.h

@@ -31,8 +31,6 @@ public:
 
     replace_proof_converter(ast_manager& _m): m(_m), m_proofs(m) {}
 
-    ~replace_proof_converter() override {}
-
     proof_ref operator()(ast_manager & _m, unsigned num_source, proof * const * source) override;
 
     proof_converter * translate(ast_translation & translator) override;

src/tactic/smtlogics/qfufbv_tactic.cpp

@@ -51,8 +51,6 @@ public:
         , m_inc_use_sat(false)
     {}
 
-    ~qfufbv_ackr_tactic() override { }
-
     char const* name() const override { return "qfufbv_ackr"; }
 
     void operator()(goal_ref const & g, goal_ref_buffer & result) override {

src/tactic/tactic.h

@@ -35,7 +35,6 @@ class tactic : public user_propagator::core {
     unsigned m_ref_count;
 public:
     tactic():m_ref_count(0) {}
-    ~tactic() override {}
 
     void inc_ref() { m_ref_count++; }
     void dec_ref() { SASSERT(m_ref_count > 0); m_ref_count--; if (m_ref_count == 0) dealloc(this); }

src/tactic/tactic_exception.h

@@ -26,7 +26,6 @@ protected:
     std::string m_msg;
 public:
     tactic_exception(std::string && msg) : m_msg(std::move(msg)) {}
-    ~tactic_exception() override {}
     char const * msg() const override { return m_msg.c_str(); }
 };