From 53c14bd55482ac884885ba48304b7e6859da679c Mon Sep 17 00:00:00 2001 From: Alberto Garcia Illera Date: Wed, 22 Apr 2020 13:52:05 -0400 Subject: [PATCH] Use Position Independent Code flag on Static library builds (#4043) Not compiling libz3 with `-fPIC` may lead to errors when using it in his static flavor from a shared library. Related https://github.com/Z3Prover/z3/issues/4038 --- CMakeLists.txt | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 36ad01cb5..4ca6fdc1e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -374,17 +374,16 @@ endif() # Position independent code ################################################################################ # This is required because code built in the components will end up in a shared -# library. If not building a shared library ``-fPIC`` isn't needed and would add -# unnecessary overhead. -if (Z3_BUILD_LIBZ3_SHARED) - # Avoid adding -fPIC compiler switch if we compile with MSVC (which does not - # support the flag) or if we target Windows, which generally does not use - # position independent code for native code shared libraries (DLLs). - if (NOT (MSVC OR MINGW OR WIN32)) - z3_add_cxx_flag("-fPIC" REQUIRED) - endif() +# library. + +# Avoid adding -fPIC compiler switch if we compile with MSVC (which does not +# support the flag) or if we target Windows, which generally does not use +# position independent code for native code shared libraries (DLLs). +if (NOT (MSVC OR MINGW OR WIN32)) + z3_add_cxx_flag("-fPIC" REQUIRED) endif() + ################################################################################ # Link time optimization ################################################################################