From 32e9440855d2e76726dc5e89671c4799c2bcdb3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20Mart=C3=ADnez?= Date: Sun, 23 Nov 2025 16:42:05 -0800 Subject: [PATCH] mk_util.py: fix --gprof option (#8040) The addition of -fomit-frame-pointer was missing a space (which broke the command line), but also this option should be added only if -pg is *not* given, as they are incompatible. So, just remove this line to fix the --gprof flag in configure. Also, this option is implied by any level of `-O`, so there is no need to pass it explicitly in most cases. It could be added to debug, non-profile builds, but I'm not sure that's useful. --- scripts/mk_util.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/mk_util.py b/scripts/mk_util.py index 005c90ecb..5245b4c3c 100644 --- a/scripts/mk_util.py +++ b/scripts/mk_util.py @@ -2686,8 +2686,6 @@ def mk_config(): CPPFLAGS = '%s -DZ3DEBUG -D_DEBUG' % CPPFLAGS else: CXXFLAGS = '%s -O3' % CXXFLAGS - if GPROF: - CXXFLAGS += '-fomit-frame-pointer' CPPFLAGS = '%s -DNDEBUG -D_EXTERNAL_RELEASE' % CPPFLAGS if is_CXX_clangpp(): CXXFLAGS = '%s -Wno-unknown-pragmas -Wno-overloaded-virtual -Wno-unused-value' % CXXFLAGS