mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-06-02 07:07:52 +00:00
Code Activity

Address code review: add SASSERT for lo>hi, simplify is_to_re handling

Browse source 
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-03-11 17:23:00 +00:00
parent 194dfe6c61
commit 30c2a9ccdc
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/smt/seq/seq_parikh.cpp
View file

@ -341,6 +341,8 @@ namespace seq {
// range [lo, hi] (hi inclusive in Z3's regex representation) // range [lo, hi] (hi inclusive in Z3's regex representation)
unsigned lo = 0, hi = 0; unsigned lo = 0, hi = 0;
if (seq.re.is_range(re_expr, lo, hi)) { if (seq.re.is_range(re_expr, lo, hi)) {
// lo > hi is a degenerate range; should not arise from well-formed minterms
SASSERT(lo <= hi);
if (lo > hi) return char_set(); if (lo > hi) return char_set();
// char_range uses exclusive upper bound; Z3 hi is inclusive // char_range uses exclusive upper bound; Z3 hi is inclusive
return char_set(char_range(lo, hi + 1)); return char_set(char_range(lo, hi + 1));
@ -363,15 +365,14 @@ namespace seq {
// to_re(str.unit(c)): singleton character set // to_re(str.unit(c)): singleton character set
expr* str_arg = nullptr; expr* str_arg = nullptr;
if (seq.re.is_to_re(re_expr, str_arg)) { expr* ch_expr = nullptr;
expr* ch_expr = nullptr; unsigned char_val = 0;
unsigned char_val = 0; if (seq.re.is_to_re(re_expr, str_arg) &&
if (seq.str.is_unit(str_arg, ch_expr) && seq.str.is_unit(str_arg, ch_expr) &&
seq.is_const_char(ch_expr, char_val)) { seq.is_const_char(ch_expr, char_val)) {
char_set cs; char_set cs;
cs.add(char_val); cs.add(char_val);
return cs; return cs;
}
} }
// empty regex: no characters can appear // empty regex: no characters can appear