mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-08-26 04:56:03 +00:00
Code Activity

add statistics about how many cubes are created

Browse source 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
This commit is contained in:
Nikolaj Bjorner 2025-08-17 20:01:16 -07:00
parent 7129b98fe6
commit 2e25281d0b
2 changed files with 30 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/smt/smt_parallel.cpp
View file

@ -171,6 +171,15 @@ namespace smt {
m_num_shared_units = sz; m_num_shared_units = sz;
} }
void parallel::worker::collect_statistics(::statistics& st) const {
ctx->collect_statistics(st);
}
void parallel::worker::cancel() {
LOG_WORKER(1, " canceling\n");
m.limit().cancel();
}
void parallel::batch_manager::init_parameters_state() { void parallel::batch_manager::init_parameters_state() {
auto& smt_params = p.ctx.get_fparams(); auto& smt_params = p.ctx.get_fparams();
std::function<std::function<void(void)>(unsigned&)> inc = [](unsigned& v) { return [&]() -> void { ++v; }; }; std::function<std::function<void(void)>(unsigned&)> inc = [](unsigned& v) { return [&]() -> void { ++v; }; };
@ -425,6 +434,8 @@ namespace smt {
m_cubes.push_back(cube); m_cubes.push_back(cube);
m_cubes.back().push_back(m.mk_not(atom)); m_cubes.back().push_back(m.mk_not(atom));
m_cubes[i].push_back(atom); m_cubes[i].push_back(atom);
m_stats.m_max_cube_size = std::max(m_stats.m_max_cube_size, m_cubes.back().size());
m_stats.m_num_cubes += 2;
} }
}; };
@ -530,6 +541,12 @@ namespace smt {
m_config.m_never_cube = sp.never_cube(); m_config.m_never_cube = sp.never_cube();
} }
void parallel::batch_manager::collect_statistics(::statistics& st) const {
//ctx->collect_statistics(st);
st.update("parallel-num_cubes", m_stats.m_num_cubes);
st.update("parallel-max-cube-size", m_stats.m_max_cube_size);
}
lbool parallel::operator()(expr_ref_vector const& asms) { lbool parallel::operator()(expr_ref_vector const& asms) {
ast_manager& m = ctx.m; ast_manager& m = ctx.m;
@ -573,7 +590,8 @@ namespace smt {
th.join(); th.join();
for (auto w : m_workers) for (auto w : m_workers)
w->collect_statistics(ctx.m_aux_stats); w->collect_statistics(ctx.m_aux_stats);
m_batch_manager.collect_statistics(ctx.m_aux_stats);
} }
return m_batch_manager.get_result(); // i.e. all threads have finished all of their cubes -- so if state::is_running is still true, means the entire formula is unsat (otherwise a thread would have returned l_undef) return m_batch_manager.get_result(); // i.e. all threads have finished all of their cubes -- so if state::is_running is still true, means the entire formula is unsat (otherwise a thread would have returned l_undef)

18
src/smt/smt_parallel.h
View file

@ -50,12 +50,17 @@ namespace smt {
bool m_frugal_cube_only = false; bool m_frugal_cube_only = false;
bool m_never_cube = false; bool m_never_cube = false;
}; };
struct stats {
unsigned m_max_cube_size = 0;
unsigned m_num_cubes = 0;
};
ast_manager& m; ast_manager& m;
parallel& p; parallel& p;
std::mutex mux; std::mutex mux;
state m_state = state::is_running; state m_state = state::is_running;
config m_config; config m_config;
stats m_stats;
expr_ref_vector m_split_atoms; // atoms to split on expr_ref_vector m_split_atoms; // atoms to split on
vector<expr_ref_vector> m_cubes; vector<expr_ref_vector> m_cubes;
unsigned m_max_batch_size = 10; unsigned m_max_batch_size = 10;
@ -99,6 +104,8 @@ namespace smt {
void report_assumption_used(ast_translation& l2g, expr* assumption); void report_assumption_used(ast_translation& l2g, expr* assumption);
void collect_clause(ast_translation& l2g, unsigned source_worker_id, expr* e); void collect_clause(ast_translation& l2g, unsigned source_worker_id, expr* e);
expr_ref_vector return_shared_clauses(ast_translation& g2l, unsigned& worker_limit, unsigned worker_id); expr_ref_vector return_shared_clauses(ast_translation& g2l, unsigned& worker_limit, unsigned worker_id);
void collect_statistics(::statistics& st) const;
lbool get_result() const; lbool get_result() const;
}; };
@ -114,6 +121,7 @@ namespace smt {
bool m_share_units_initial_only = false; bool m_share_units_initial_only = false;
bool m_cube_initial_only = false; bool m_cube_initial_only = false;
}; };
unsigned id; // unique identifier for the worker unsigned id; // unique identifier for the worker
parallel& p; parallel& p;
batch_manager& b; batch_manager& b;
@ -137,13 +145,9 @@ namespace smt {
expr_ref_vector get_split_atoms(); expr_ref_vector get_split_atoms();
void collect_shared_clauses(ast_translation& g2l); void collect_shared_clauses(ast_translation& g2l);
void cancel() { void cancel();
IF_VERBOSE(1, verbose_stream() << "Worker " << id << " canceling\n"); void collect_statistics(::statistics& st) const;
m.limit().cancel();
}
void collect_statistics(::statistics& st) const {
ctx->collect_statistics(st);
}
reslimit& limit() { reslimit& limit() {
return m.limit(); return m.limit();
} }