mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-02-18 22:54:21 +00:00
Code Activity

Standardize for-loop increments to prefix form (++i) (#8199)

Browse source 
* Initial plan

* Convert postfix to prefix increment in for loops

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Fix member variable increment conversion bug

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Update API generator to produce prefix increments

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-14 19:55:31 -08:00 • committed by GitHub
parent 1bf463d77a
commit 2436943794
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
475 changed files with 3237 additions and 3237 deletions
Download patch file Download diff file Expand all files Collapse all files

32
src/util/mpn.cpp
View file

@ -57,7 +57,7 @@ bool mpn_manager::add(mpn_digit const * a, unsigned lnga,
mpn_digit k = 0;
mpn_digit r;
bool c1, c2;
for (unsigned j = 0; j < len; j++) {
for (unsigned j = 0; j < len; ++j) {
mpn_digit u_j = (j < lnga) ? a[j] : 0;
mpn_digit v_j = (j < lngb) ? b[j] : 0;
r = u_j + v_j; c1 = r < u_j;
@ -81,7 +81,7 @@ bool mpn_manager::sub(mpn_digit const * a, unsigned lnga,
mpn_digit & k = *pborrow; k = 0;
mpn_digit r;
bool c1, c2;
for (unsigned j = 0; j < len; j++) {
for (unsigned j = 0; j < len; ++j) {
mpn_digit u_j = (j < lnga) ? a[j] : 0;
mpn_digit v_j = (j < lngb) ? b[j] : 0;
r = u_j - v_j; c1 = r > u_j;
@ -104,17 +104,17 @@ bool mpn_manager::mul(mpn_digit const * a, unsigned lnga,
#define DIGIT_BITS (sizeof(mpn_digit)*8)
#define HALF_BITS (sizeof(mpn_digit)*4)
for (unsigned i = 0; i < lnga; i++)
for (unsigned i = 0; i < lnga; ++i)
c[i] = 0;
for (unsigned j = 0; j < lngb; j++) {
for (unsigned j = 0; j < lngb; ++j) {
mpn_digit v_j = b[j];
if (v_j == 0) { // This branch may be omitted according to Knuth.
c[j+lnga] = 0;
}
else {
k = 0;
for (i = 0; i < lnga; i++) {
for (i = 0; i < lnga; ++i) {
mpn_digit u_i = a[i];
mpn_double_digit t;
t = ((mpn_double_digit)u_i * (mpn_double_digit)v_j) +
@ -145,9 +145,9 @@ bool mpn_manager::div(mpn_digit const * numer, unsigned lnum,
bool res = false;
if (lnum < lden) {
for (unsigned i = 0; i < (lnum-lden+1); i++)
for (unsigned i = 0; i < (lnum-lden+1); ++i)
quot[i] = 0;
for (unsigned i = 0; i < lden; i++)
for (unsigned i = 0; i < lden; ++i)
rem[i] = (i < lnum) ? numer[i] : 0;
return false;
}
@ -160,7 +160,7 @@ bool mpn_manager::div(mpn_digit const * numer, unsigned lnum,
}
else if (lnum < lden || (lnum == lden && numer[lnum-1] < denom[lden-1])) {
*quot = 0;
for (unsigned i = 0; i < lden; i++)
for (unsigned i = 0; i < lden; ++i)
rem[i] = (i < lnum) ? numer[i] : 0;
}
else {
@ -186,7 +186,7 @@ bool mpn_manager::div(mpn_digit const * numer, unsigned lnum,
unsigned real_size;
add(temp.data(), lnum, rem, lden, temp.data(), lnum+1, &real_size);
bool ok = true;
for (unsigned i = 0; i < lnum && ok; i++)
for (unsigned i = 0; i < lnum && ok; ++i)
if (temp[i] != numer[i]) ok = false;
if (temp[lnum] != 0) ok = false;
CTRACE(mpn_dbg, !ok, tout << "DIV BUG: quot * denom + rem = "; display_raw(tout, temp.data(), lnum+1); tout << std::endl; );
@ -210,9 +210,9 @@ unsigned mpn_manager::div_normalize(mpn_digit const * numer, unsigned lnum,
if (d == 0) {
n_numer[lnum] = 0;
for (unsigned i = 0; i < lnum; i++)
for (unsigned i = 0; i < lnum; ++i)
n_numer[i] = numer[i];
for (unsigned i = 0; i < lden; i++)
for (unsigned i = 0; i < lden; ++i)
n_denom[i] = denom[i];
}
else if (lnum != 0) {
@ -238,11 +238,11 @@ unsigned mpn_manager::div_normalize(mpn_digit const * numer, unsigned lnum,
void mpn_manager::div_unnormalize(mpn_sbuffer & numer, mpn_sbuffer & denom,
unsigned d, mpn_digit * rem) const {
if (d == 0) {
for (unsigned i = 0; i < denom.size(); i++)
for (unsigned i = 0; i < denom.size(); ++i)
rem[i] = numer[i];
}
else {
for (unsigned i = 0; i < denom.size()-1; i++)
for (unsigned i = 0; i < denom.size()-1; ++i)
rem[i] = numer[i] >> d | (LAST_BITS(d, numer[i+1]) << (DIGIT_BITS-d));
rem[denom.size()-1] = numer[denom.size()-1] >> d;
}
@ -320,7 +320,7 @@ bool mpn_manager::div_n(mpn_sbuffer & numer, mpn_sbuffer const & denom,
ab.resize(n+2);
unsigned real_size;
add(denom.data(), n, &numer[j], n+1, ab.data(), n+2, &real_size);
for (unsigned i = 0; i < n+1; i++)
for (unsigned i = 0; i < n+1; ++i)
numer[j+i] = ab[i];
}
TRACE(mpn_div, tout << "q_hat=" << q_hat << " r_hat=" << r_hat;
@ -346,7 +346,7 @@ char * mpn_manager::to_string(mpn_digit const * a, unsigned lng, char * buf, uns
}
else {
mpn_sbuffer temp(lng, 0), t_numer(lng+1, 0), t_denom(1, 0);
for (unsigned i = 0; i < lng; i++)
for (unsigned i = 0; i < lng; ++i)
temp[i] = a[i];
unsigned j = 0;
@ -364,7 +364,7 @@ char * mpn_manager::to_string(mpn_digit const * a, unsigned lng, char * buf, uns
j--;
unsigned mid = (j/2) + ((j % 2) ? 1 : 0);
for (unsigned i = 0; i < mid; i++)
for (unsigned i = 0; i < mid; ++i)
std::swap(buf[i], buf[j-i]);
}