mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-04-27 14:23:35 +00:00
Code Activity

Adopt std::optional for try_get_value and try_get_size functions (#8268)

Browse source 
* Initial plan

* Convert try_get_value and try_get_size to use std::optional

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Add unit tests for std::optional conversions and fix compilation error

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Address code review comments - improve readability and reduce code duplication

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-21 12:41:50 -08:00 • committed by Nikolaj Bjorner
parent 671faf8f1c
commit 054a83e925
14 changed files with 92 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/smt/theory_dl.cpp
View file

@ -240,10 +240,10 @@ namespace smt {
}
app* max_value(sort* s) {
uint64_t sz;
VERIFY(u().try_get_size(s, sz));
SASSERT(sz > 0);
return mk_bv_constant(sz-1, s);
auto sz = u().try_get_size(s);
VERIFY(sz);
SASSERT(*sz > 0);
return mk_bv_constant(*sz-1, s);
}
void mk_lt(app* x, app* y) {