diff --git a/.github/workflows/zipt-code-reviewer.md b/.github/workflows/zipt-code-reviewer.md index bc1e7285c..06b6528b4 100644 --- a/.github/workflows/zipt-code-reviewer.md +++ b/.github/workflows/zipt-code-reviewer.md @@ -169,12 +169,10 @@ git diff > /tmp/zipt-improvements.diff cat /tmp/zipt-improvements.diff ``` -If no changes were made because no improvements were found or all were too risky, exit gracefully: +If no changes were made because no improvements were found or all were too risky, call the `noop` safe-output tool: ``` -✅ ZIPT code review complete. No concrete improvements found in this run. -Files examined: [list files] -ZIPT files compared: [list files] +noop: "ZIPT code review complete. No concrete improvements found in this run. Files examined: [list files]. ZIPT files compared: [list files]." ``` ## Phase 6: Create GitHub Issue @@ -235,7 +233,12 @@ make test-z3 *Generated by ZIPT Code Reviewer agent — comparing Z3 implementation with CEisenhofer/ZIPT@parikh* ``` -## Important Guidelines +## Important: Always Call a Safe Output Tool + +**You MUST always call at least one safe-output tool before finishing.** Failing to do so is reported as a workflow failure. + +- If you found and applied improvements → call `create_issue` +- If ZIPT is unreachable, no improvements were found, or all improvements are out of scope → call `noop` with a brief explanation ### Scope - **Only** examine the files listed in Phase 1 @@ -249,7 +252,12 @@ make test-z3 - Prefer small, surgical changes over large refactors ### Exit Conditions -Exit without creating an issue if: +Call `noop` (instead of creating an issue) if: - ZIPT repository is unreachable - No concrete, safe improvements can be identified - All identified improvements require architectural changes beyond the scope of a single diff + +Example noop call: +``` +noop: "ZIPT code review complete. No improvements applied: [brief reason, e.g. ZIPT unreachable / no safe changes identified]. Files reviewed: [list]." +```