From 23cb00706812465b3ff2c3ecf02ed9a3a27b40a3 Mon Sep 17 00:00:00 2001
From: Krystine Sherwin <93062060+KrystalDelusion@users.noreply.github.com>
Date: Mon, 5 May 2025 10:04:13 +1200
Subject: [PATCH 1/2] verilog_parser.y: Delete unused TOK_ID

Fixes memory leak when parameter has no value.
---
 frontends/verilog/verilog_parser.y | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/frontends/verilog/verilog_parser.y b/frontends/verilog/verilog_parser.y
index fe86626b8..9d0956c8e 100644
--- a/frontends/verilog/verilog_parser.y
+++ b/frontends/verilog/verilog_parser.y
@@ -2249,7 +2249,8 @@ cell_parameter:
 		node->children.push_back($1);
 	} |
 	'.' TOK_ID '(' ')' {
-		// just ignore empty parameters
+		// delete unused TOK_ID
+		delete $2;
 	} |
 	'.' TOK_ID '(' expr ')' {
 		AstNode *node = new AstNode(AST_PARASET);

From 7c2b00c448ee37e9af27cf497f24d0526a57c40b Mon Sep 17 00:00:00 2001
From: Krystine Sherwin <93062060+KrystalDelusion@users.noreply.github.com>
Date: Mon, 5 May 2025 10:18:52 +1200
Subject: [PATCH 2/2] tests: Add default param test file

Just loads, fails ASAN without fix.
---
 tests/verilog/param_default.ys | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 tests/verilog/param_default.ys

diff --git a/tests/verilog/param_default.ys b/tests/verilog/param_default.ys
new file mode 100644
index 000000000..59023c477
--- /dev/null
+++ b/tests/verilog/param_default.ys
@@ -0,0 +1,24 @@
+logger -expect-no-warnings
+read_verilog << EOF
+module bar (
+	input portname
+);
+	parameter paramname = 7;
+endmodule
+ 
+module empty (
+);
+ 	bar #() barinstance ();
+endmodule
+
+module implicit (
+);
+ 	bar #(.paramname()) barinstance (.portname());
+endmodule
+
+module explicit (
+	input a
+);
+	bar #(.paramname(3)) barinstance (.portname(a));
+endmodule
+EOF