mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2026-05-31 22:27:50 +00:00
Code Activity

Refactor hierarchy ports.

Browse source
This commit is contained in:
nella 2026-05-06 11:27:58 +02:00
parent 343538becc
commit e0ef8bb9e9
5 changed files with 146 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

1
passes/hierarchy/util/Makefile.inc
View file

@ -2,6 +2,7 @@ OBJS += passes/hierarchy/util/clean.o
OBJS += passes/hierarchy/util/generate.o OBJS += passes/hierarchy/util/generate.o
OBJS += passes/hierarchy/util/interfaces.o OBJS += passes/hierarchy/util/interfaces.o
OBJS += passes/hierarchy/util/misc.o OBJS += passes/hierarchy/util/misc.o
OBJS += passes/hierarchy/util/ports.o
OBJS += passes/hierarchy/util/positionals.o OBJS += passes/hierarchy/util/positionals.o
OBJS += passes/hierarchy/util/top.o OBJS += passes/hierarchy/util/top.o
OBJS += passes/hierarchy/util/verilog.o OBJS += passes/hierarchy/util/verilog.o

104
passes/hierarchy/util/ports.cc Normal file
View file

@ -0,0 +1,104 @@
/*
* yosys -- Yosys Open SYnthesis Suite
*
* Copyright (C) 2012 Claire Xenia Wolf <claire@yosyshq.com>
* Copyright (C) 2018 Ruben Undheim <ruben.undheim@gmail.com>
*
* Permission to use, copy, modify, and/or distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
*/
#include "kernel/yosys_common.h"
#include "passes/hierarchy/util/ports.h"
YOSYS_NAMESPACE_BEGIN
namespace Hierarchy {
void check_and_adjust_ports(Module* module, std::set<Module*>& blackbox_derivatives, bool keep_portwidths, bool top_is_from_verific) {
Design* design = module->design;
for (auto cell : module->cells())
{
Module *m = design->module(cell->type);
if (m == nullptr)
continue;
bool boxed_params = false;
if (m->get_blackbox_attribute() && !cell->parameters.empty()) {
if (m->get_bool_attribute(ID::dynports)) {
IdString new_m_name = m->derive(design, cell->parameters, true);
if (new_m_name.empty())
continue;
if (new_m_name != m->name) {
m = design->module(new_m_name);
blackbox_derivatives.insert(m);
}
} else {
boxed_params = true;
}
}
for (auto &conn : cell->connections())
{
Wire *w = m->wire(conn.first);
if (w == nullptr || w->port_id == 0)
continue;
if (GetSize(conn.second) == 0)
continue;
SigSpec sig = conn.second;
bool resize_widths = !keep_portwidths && GetSize(w) != GetSize(conn.second);
if (resize_widths && top_is_from_verific && boxed_params)
log_debug("Ignoring width mismatch on %s.%s.%s from verific, is port width parametrizable?\n",
log_id(module), log_id(cell), log_id(conn.first)
);
else if (resize_widths) {
if (GetSize(w) < GetSize(conn.second))
{
int n = GetSize(conn.second) - GetSize(w);
if (!w->port_input && w->port_output)
{
RTLIL::SigSpec out = sig.extract(0, GetSize(w));
out.extend_u0(GetSize(sig), w->is_signed);
module->connect(sig.extract(GetSize(w), n), out.extract(GetSize(w), n));
}
sig.remove(GetSize(w), n);
}
else
{
int n = GetSize(w) - GetSize(conn.second);
if (w->port_input && !w->port_output)
sig.extend_u0(GetSize(w), sig.is_wire() && sig.as_wire()->is_signed);
else
sig.append(module->addWire(NEW_ID, n));
}
if (!conn.second.is_fully_const() || !w->port_input || w->port_output)
log_warning("Resizing cell port %s.%s.%s from %d bits to %d bits.\n", log_id(module), log_id(cell),
log_id(conn.first), GetSize(conn.second), GetSize(sig));
cell->setPort(conn.first, sig);
}
if (w->port_output && !w->port_input && sig.has_const())
log_error("Output port %s.%s.%s (%s) is connected to constants: %s\n",
log_id(module), log_id(cell), log_id(conn.first), log_id(cell->type), log_signal(sig));
}
}
}
};
YOSYS_NAMESPACE_END

34
passes/hierarchy/util/ports.h Normal file
View file

@ -0,0 +1,34 @@
/*
* yosys -- Yosys Open SYnthesis Suite
*
* Copyright (C) 2012 Claire Xenia Wolf <claire@yosyshq.com>
* Copyright (C) 2018 Ruben Undheim <ruben.undheim@gmail.com>
*
* Permission to use, copy, modify, and/or distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
*/
#ifndef HIERARCHY_PORTS_H
#define HIERARCHY_PORTS_H
#include "kernel/yosys.h"
YOSYS_NAMESPACE_BEGIN
namespace Hierarchy {
void check_and_adjust_ports(Module* module, std::set<Module*>& blackbox_derivatives, bool keep_portwidths, bool top_is_from_verific);
};
YOSYS_NAMESPACE_END
#endif /* HIERARCHY_PORTS_H */

80
passes/hierarchy/util/verilog.cc
View file

@ -21,6 +21,7 @@
#include "kernel/yosys_common.h" #include "kernel/yosys_common.h"
#include "passes/hierarchy/util/verilog.h" #include "passes/hierarchy/util/verilog.h"
#include "passes/hierarchy/util/positionals.h" #include "passes/hierarchy/util/positionals.h"
#include "passes/hierarchy/util/ports.h"
PRIVATE_NAMESPACE_BEGIN PRIVATE_NAMESPACE_BEGIN
USING_YOSYS_NAMESPACE USING_YOSYS_NAMESPACE
@ -88,7 +89,10 @@ namespace Hierarchy {
} }
for (auto module : design_modules) for (auto module : design_modules)
resolve_wand_wor(module, blackbox_derivatives, keep_portwidths, top_is_from_verific); resolve_wand_wor(module);
for (auto module : design_modules)
check_and_adjust_ports(module, blackbox_derivatives, keep_portwidths, top_is_from_verific);
for (auto module : blackbox_derivatives) for (auto module : blackbox_derivatives)
design->remove(module); design->remove(module);
@ -141,8 +145,7 @@ namespace Hierarchy {
cell->attributes.erase(ID::wildcard_port_conns); cell->attributes.erase(ID::wildcard_port_conns);
} }
void resolve_wand_wor(Module* module, std::set<Module*>& blackbox_derivatives, bool keep_portwidths, bool top_is_from_verific) { void resolve_wand_wor(Module* module) {
Design* design = module->design;
pool<Wire*> wand_wor_index; pool<Wire*> wand_wor_index;
dict<Wire*, SigSpec> wand_map, wor_map; dict<Wire*, SigSpec> wand_map, wor_map;
vector<SigSig> new_connections; vector<SigSig> new_connections;
@ -257,77 +260,6 @@ namespace Hierarchy {
module->connect(w, s); module->connect(w, s);
} }
for (auto cell : module->cells())
{
Module *m = design->module(cell->type);
if (m == nullptr)
continue;
bool boxed_params = false;
if (m->get_blackbox_attribute() && !cell->parameters.empty()) {
if (m->get_bool_attribute(ID::dynports)) {
IdString new_m_name = m->derive(design, cell->parameters, true);
if (new_m_name.empty())
continue;
if (new_m_name != m->name) {
m = design->module(new_m_name);
blackbox_derivatives.insert(m);
}
} else {
boxed_params = true;
}
}
for (auto &conn : cell->connections())
{
Wire *w = m->wire(conn.first);
if (w == nullptr || w->port_id == 0)
continue;
if (GetSize(conn.second) == 0)
continue;
SigSpec sig = conn.second;
bool resize_widths = !keep_portwidths && GetSize(w) != GetSize(conn.second);
if (resize_widths && top_is_from_verific && boxed_params)
log_debug("Ignoring width mismatch on %s.%s.%s from verific, is port width parametrizable?\n",
log_id(module), log_id(cell), log_id(conn.first)
);
else if (resize_widths) {
if (GetSize(w) < GetSize(conn.second))
{
int n = GetSize(conn.second) - GetSize(w);
if (!w->port_input && w->port_output)
{
RTLIL::SigSpec out = sig.extract(0, GetSize(w));
out.extend_u0(GetSize(sig), w->is_signed);
module->connect(sig.extract(GetSize(w), n), out.extract(GetSize(w), n));
}
sig.remove(GetSize(w), n);
}
else
{
int n = GetSize(w) - GetSize(conn.second);
if (w->port_input && !w->port_output)
sig.extend_u0(GetSize(w), sig.is_wire() && sig.as_wire()->is_signed);
else
sig.append(module->addWire(NEW_ID, n));
}
if (!conn.second.is_fully_const() || !w->port_input || w->port_output)
log_warning("Resizing cell port %s.%s.%s from %d bits to %d bits.\n", log_id(module), log_id(cell),
log_id(conn.first), GetSize(conn.second), GetSize(sig));
cell->setPort(conn.first, sig);
}
if (w->port_output && !w->port_input && sig.has_const())
log_error("Output port %s.%s.%s (%s) is connected to constants: %s\n",
log_id(module), log_id(cell), log_id(conn.first), log_id(cell->type), log_signal(sig));
}
}
} }
void check_supported_formal(Design* design) { void check_supported_formal(Design* design) {
for (auto mod : design->modules()) { for (auto mod : design->modules()) {

2
passes/hierarchy/util/verilog.h
View file

@ -28,7 +28,7 @@ YOSYS_NAMESPACE_BEGIN
namespace Hierarchy { namespace Hierarchy {
void resolve_verilog(Design* design, bool nodefaults, bool keep_positionals, bool keep_portwidths, bool top_is_from_verific); void resolve_verilog(Design* design, bool nodefaults, bool keep_positionals, bool keep_portwidths, bool top_is_from_verific);
void resolve_wildcards(Cell* cell, std::set<Module*>& blackbox_derivatives, bool nodefaults, dict<IdString, dict<IdString, Const>>& defaults_db); void resolve_wildcards(Cell* cell, std::set<Module*>& blackbox_derivatives, bool nodefaults, dict<IdString, dict<IdString, Const>>& defaults_db);
void resolve_wand_wor(Module* module, std::set<Module*>& blackbox_derivatives, bool keep_portwidths, bool top_is_from_verific); void resolve_wand_wor(Module* module);
void check_supported_formal(Design* design); void check_supported_formal(Design* design);
}; };