mirror of
https://github.com/YosysHQ/yosys
synced 2025-04-23 00:55:32 +00:00
sv: support for parameters without default values
- Modules with a parameter without a default value will be automatically deferred until the hierarchy pass - Allows for parameters without defaults as module items, rather than just int the `parameter_port_list`, despite being forbidden in the LRM - Check for parameters without defaults that haven't been overriden - Add location info to parameter/localparam declarations
This commit is contained in:
parent
375af199ef
commit
d738b2c127
12 changed files with 225 additions and 5 deletions
17
tests/verilog/localparam_no_default_1.ys
Normal file
17
tests/verilog/localparam_no_default_1.ys
Normal file
|
@ -0,0 +1,17 @@
|
|||
logger -expect-no-warnings
|
||||
read_verilog -sv <<EOF
|
||||
module Module #(
|
||||
localparam X = 1
|
||||
);
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
design -reset
|
||||
|
||||
logger -expect error "localparam initialization is missing!" 1
|
||||
read_verilog <<EOF
|
||||
module Module #(
|
||||
localparam X
|
||||
);
|
||||
endmodule
|
||||
EOF
|
15
tests/verilog/localparam_no_default_2.ys
Normal file
15
tests/verilog/localparam_no_default_2.ys
Normal file
|
@ -0,0 +1,15 @@
|
|||
logger -expect-no-warnings
|
||||
read_verilog -sv <<EOF
|
||||
module Module;
|
||||
localparam X = 1;
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
design -reset
|
||||
|
||||
logger -expect error "localparam initialization is missing!" 1
|
||||
read_verilog <<EOF
|
||||
module Module;
|
||||
localparam X;
|
||||
endmodule
|
||||
EOF
|
52
tests/verilog/param_no_default.sv
Normal file
52
tests/verilog/param_no_default.sv
Normal file
|
@ -0,0 +1,52 @@
|
|||
module example #(
|
||||
parameter w,
|
||||
parameter x = 1,
|
||||
parameter byte y,
|
||||
parameter byte z = 3
|
||||
) (
|
||||
output a, b,
|
||||
output byte c, d
|
||||
);
|
||||
assign a = w;
|
||||
assign b = x;
|
||||
assign c = y;
|
||||
assign d = z;
|
||||
endmodule
|
||||
|
||||
module top;
|
||||
wire a1, b1;
|
||||
wire a2, b2;
|
||||
wire a3, b3;
|
||||
wire a4, b4;
|
||||
byte c1, d1;
|
||||
byte c2, d2;
|
||||
byte c3, d3;
|
||||
byte c4, d4;
|
||||
|
||||
example #(0, 1, 2) e1(a1, b1, c1, d1);
|
||||
example #(.w(1), .y(4)) e2(a2, b2, c2, d2);
|
||||
example #(.x(0), .w(1), .y(5)) e3(a3, b3, c3, d3);
|
||||
example #(1, 0, 9, 10) e4(a4, b4, c4, d4);
|
||||
|
||||
always @* begin
|
||||
assert (a1 == 0);
|
||||
assert (b1 == 1);
|
||||
assert (c1 == 2);
|
||||
assert (d1 == 3);
|
||||
|
||||
assert (a2 == 1);
|
||||
assert (b2 == 1);
|
||||
assert (c2 == 4);
|
||||
assert (d3 == 3);
|
||||
|
||||
assert (a3 == 1);
|
||||
assert (b3 == 0);
|
||||
assert (c3 == 5);
|
||||
assert (d3 == 3);
|
||||
|
||||
assert (a4 == 1);
|
||||
assert (b4 == 0);
|
||||
assert (c4 == 9);
|
||||
assert (d4 == 10);
|
||||
end
|
||||
endmodule
|
7
tests/verilog/param_no_default.ys
Normal file
7
tests/verilog/param_no_default.ys
Normal file
|
@ -0,0 +1,7 @@
|
|||
read_verilog -sv param_no_default.sv
|
||||
hierarchy
|
||||
proc
|
||||
flatten
|
||||
opt -full
|
||||
select -module top
|
||||
sat -verify -seq 1 -tempinduct -prove-asserts -show-all
|
26
tests/verilog/param_no_default_not_svmode.ys
Normal file
26
tests/verilog/param_no_default_not_svmode.ys
Normal file
|
@ -0,0 +1,26 @@
|
|||
logger -expect-no-warnings
|
||||
read_verilog -sv <<EOF
|
||||
module Module;
|
||||
parameter X;
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
design -reset
|
||||
|
||||
logger -expect-no-warnings
|
||||
read_verilog -sv <<EOF
|
||||
module Module #(
|
||||
parameter X
|
||||
);
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
design -reset
|
||||
|
||||
logger -expect error "Parameter defaults can only be omitted in SystemVerilog mode!" 1
|
||||
read_verilog <<EOF
|
||||
module Module #(
|
||||
parameter X
|
||||
);
|
||||
endmodule
|
||||
EOF
|
12
tests/verilog/param_no_default_unbound_1.ys
Normal file
12
tests/verilog/param_no_default_unbound_1.ys
Normal file
|
@ -0,0 +1,12 @@
|
|||
read_verilog -sv <<EOF
|
||||
module Example #(
|
||||
parameter X
|
||||
);
|
||||
endmodule
|
||||
module top;
|
||||
Example e();
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1
|
||||
hierarchy -top top
|
12
tests/verilog/param_no_default_unbound_2.ys
Normal file
12
tests/verilog/param_no_default_unbound_2.ys
Normal file
|
@ -0,0 +1,12 @@
|
|||
read_verilog -sv <<EOF
|
||||
module Example #(
|
||||
parameter X, Y
|
||||
);
|
||||
endmodule
|
||||
module top;
|
||||
Example e();
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1
|
||||
hierarchy -top top
|
12
tests/verilog/param_no_default_unbound_3.ys
Normal file
12
tests/verilog/param_no_default_unbound_3.ys
Normal file
|
@ -0,0 +1,12 @@
|
|||
read_verilog -sv <<EOF
|
||||
module Example #(
|
||||
parameter X, Y
|
||||
);
|
||||
endmodule
|
||||
module top;
|
||||
Example #(1) e();
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
logger -expect error "Parameter `\\Y' has no default value and has not been overridden!" 1
|
||||
hierarchy -top top
|
12
tests/verilog/param_no_default_unbound_4.ys
Normal file
12
tests/verilog/param_no_default_unbound_4.ys
Normal file
|
@ -0,0 +1,12 @@
|
|||
read_verilog -sv <<EOF
|
||||
module Example #(
|
||||
parameter X, Y
|
||||
);
|
||||
endmodule
|
||||
module top;
|
||||
Example #(.Y(1)) e();
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1
|
||||
hierarchy -top top
|
12
tests/verilog/param_no_default_unbound_5.ys
Normal file
12
tests/verilog/param_no_default_unbound_5.ys
Normal file
|
@ -0,0 +1,12 @@
|
|||
read_verilog -sv <<EOF
|
||||
module Example #(
|
||||
parameter X, Y = 2
|
||||
);
|
||||
endmodule
|
||||
module top;
|
||||
Example #(.Y(1)) e();
|
||||
endmodule
|
||||
EOF
|
||||
|
||||
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1
|
||||
hierarchy -top top
|
Loading…
Add table
Add a link
Reference in a new issue