From 92809bb1d3c225ab0c846a55979f6914dcfbd886 Mon Sep 17 00:00:00 2001 From: Diego H Date: Mon, 30 Mar 2020 17:18:13 -0600 Subject: [PATCH 1/2] Adding error message for when size (width) of number literal is zero --- frontends/verilog/const2ast.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frontends/verilog/const2ast.cc b/frontends/verilog/const2ast.cc index 49281f7e7..25d257867 100644 --- a/frontends/verilog/const2ast.cc +++ b/frontends/verilog/const2ast.cc @@ -139,6 +139,10 @@ static void my_strtobin(std::vector &data, const char *str, int le data.resize(len_in_bits, msb); } + if (len_in_bits == 0) + log_error("Illegal integer constant size of zero in %s:%d (IEEE 1800-2012, 5.7).\n", + current_filename.c_str(), get_line_num()); + if (len > len_in_bits) log_warning("Literal has a width of %d bit, but value requires %d bit. (%s:%d)\n", len_in_bits, len, current_filename.c_str(), get_line_num()); From c859bcf71bddbcceb36d276221a5eb490ed1cf4c Mon Sep 17 00:00:00 2001 From: Diego H Date: Tue, 31 Mar 2020 12:01:29 -0600 Subject: [PATCH 2/2] Replacing log_error for log_file_error due consistency --- frontends/verilog/const2ast.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/frontends/verilog/const2ast.cc b/frontends/verilog/const2ast.cc index 25d257867..230dfadbf 100644 --- a/frontends/verilog/const2ast.cc +++ b/frontends/verilog/const2ast.cc @@ -140,8 +140,7 @@ static void my_strtobin(std::vector &data, const char *str, int le } if (len_in_bits == 0) - log_error("Illegal integer constant size of zero in %s:%d (IEEE 1800-2012, 5.7).\n", - current_filename.c_str(), get_line_num()); + log_file_error(current_filename, get_line_num(), "Illegal integer constant size of zero (IEEE 1800-2012, 5.7).\n"); if (len > len_in_bits) log_warning("Literal has a width of %d bit, but value requires %d bit. (%s:%d)\n",