From c497b3b24c4168659288be344c6548163f604a45 Mon Sep 17 00:00:00 2001 From: "Emil J. Tywoniak" Date: Fri, 14 Nov 2025 15:32:10 +0100 Subject: [PATCH] Revert "rtlil: make tracing optional in IdString garbage collection" This reverts commit 8c76f93fcef412605d0ef01e7987a903be6c9e99. --- kernel/rtlil.cc | 9 ++++----- kernel/rtlil.h | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/rtlil.cc b/kernel/rtlil.cc index ee53afe41..d18a709c9 100644 --- a/kernel/rtlil.cc +++ b/kernel/rtlil.cc @@ -246,15 +246,14 @@ struct IdStringCollector { int64_t RTLIL::OwningIdString::gc_ns; int RTLIL::OwningIdString::gc_count; -void RTLIL::OwningIdString::collect_garbage(bool trace) +void RTLIL::OwningIdString::collect_garbage() { int64_t start = PerformanceTimer::query(); #ifndef YOSYS_NO_IDS_REFCNT IdStringCollector collector; - if (trace) - for (auto &[idx, design] : *RTLIL::Design::get_all_designs()) { - collector.trace(*design); - } + for (auto &[idx, design] : *RTLIL::Design::get_all_designs()) { + collector.trace(*design); + } int size = GetSize(global_id_storage_); for (int i = static_cast(StaticId::STATIC_ID_END); i < size; ++i) { RTLIL::IdString::Storage &storage = global_id_storage_.at(i); diff --git a/kernel/rtlil.h b/kernel/rtlil.h index 6098d916b..584c4e11b 100644 --- a/kernel/rtlil.h +++ b/kernel/rtlil.h @@ -574,7 +574,7 @@ struct RTLIL::OwningIdString : public RTLIL::IdString { } // Collect all non-owning references. - static void collect_garbage(bool trace = true); + static void collect_garbage(); static int64_t garbage_collection_ns() { return gc_ns; } static int garbage_collection_count() { return gc_count; }