mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-06-06 22:23:23 +00:00
Code Activity

verilog: revise hot comment warnings

Browse source
This commit is contained in:
Zachary Snow 2021-03-29 11:03:46 -04:00 • committed by Zachary Snow
parent 8c5f379435
commit ba2ff1ea98
1 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

27
frontends/verilog/verilog_lexer.l
View file

@ -431,8 +431,13 @@ supply1 { return TOK_SUPPLY1; }
"/*"[ \t]*(synopsys|synthesis)[ \t]*translate_off[ \t]*"*/" { "/*"[ \t]*(synopsys|synthesis)[ \t]*translate_off[ \t]*"*/" {
static bool printed_warning = false; static bool printed_warning = false;
if (!printed_warning) { if (!printed_warning) {
log_warning("Found one of those horrible `(synopsys|synthesis) translate_off' comments.\n" log_warning(
"Yosys does support them but it is recommended to use `ifdef constructs instead!\n"); "Encountered `translate_off' comment! Such legacy hot "
"comments are supported by Yosys, but are not part of "
"any formal language specification. Using a portable "
"and standards-compliant construct such as `ifdef is "
"recommended!\n"
);
printed_warning = true; printed_warning = true;
} }
BEGIN(SYNOPSYS_TRANSLATE_OFF); BEGIN(SYNOPSYS_TRANSLATE_OFF);
@ -447,8 +452,13 @@ supply1 { return TOK_SUPPLY1; }
<SYNOPSYS_FLAGS>full_case { <SYNOPSYS_FLAGS>full_case {
static bool printed_warning = false; static bool printed_warning = false;
if (!printed_warning) { if (!printed_warning) {
log_warning("Found one of those horrible `(synopsys|synthesis) full_case' comments.\n" log_warning(
"Yosys does support them but it is recommended to use Verilog `full_case' attributes instead!\n"); "Encountered `full_case' comment! Such legacy hot "
"comments are supported by Yosys, but are not part of "
"any formal language specification. Using the Verilog "
"`full_case' attribute or the SystemVerilog `unique' "
"or `unique0' keywords is recommended!\n"
);
printed_warning = true; printed_warning = true;
} }
return TOK_SYNOPSYS_FULL_CASE; return TOK_SYNOPSYS_FULL_CASE;
@ -456,8 +466,13 @@ supply1 { return TOK_SUPPLY1; }
<SYNOPSYS_FLAGS>parallel_case { <SYNOPSYS_FLAGS>parallel_case {
static bool printed_warning = false; static bool printed_warning = false;
if (!printed_warning) { if (!printed_warning) {
log_warning("Found one of those horrible `(synopsys|synthesis) parallel_case' comments.\n" log_warning(
"Yosys does support them but it is recommended to use Verilog `parallel_case' attributes instead!\n"); "Encountered `parallel_case' comment! Such legacy hot "
"comments are supported by Yosys, but are not part of "
"any formal language specification. Using the Verilog "
"`parallel_case' attribute or the SystemVerilog "
"`unique' or `priority' keywords is recommended!\n"
);
printed_warning = true; printed_warning = true;
} }
return TOK_SYNOPSYS_PARALLEL_CASE; return TOK_SYNOPSYS_PARALLEL_CASE;