3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-07-19 10:52:03 +00:00

Use ID() macro

This commit is contained in:
Eddie Hung 2019-09-19 16:13:22 -07:00
parent 595fb611a5
commit a8bc460805
2 changed files with 209 additions and 209 deletions

View file

@ -65,21 +65,21 @@ void create_ice40_dsp(ice40_dsp_pm &pm)
} }
Cell *cell = st.mul; Cell *cell = st.mul;
if (cell->type == "$mul") { if (cell->type == ID($mul)) {
log(" replacing %s with SB_MAC16 cell.\n", log_id(st.mul->type)); log(" replacing %s with SB_MAC16 cell.\n", log_id(st.mul->type));
cell = pm.module->addCell(NEW_ID, "\\SB_MAC16"); cell = pm.module->addCell(NEW_ID, ID(SB_MAC16));
pm.module->swap_names(cell, st.mul); pm.module->swap_names(cell, st.mul);
} }
else log_assert(cell->type == "\\SB_MAC16"); else log_assert(cell->type == ID(SB_MAC16));
// SB_MAC16 Input Interface // SB_MAC16 Input Interface
SigSpec A = st.sigA; SigSpec A = st.sigA;
A.extend_u0(16, st.mul->getParam("\\A_SIGNED").as_bool()); A.extend_u0(16, st.mul->getParam(ID(A_SIGNED)).as_bool());
log_assert(GetSize(A) == 16); log_assert(GetSize(A) == 16);
SigSpec B = st.sigB; SigSpec B = st.sigB;
B.extend_u0(16, st.mul->getParam("\\B_SIGNED").as_bool()); B.extend_u0(16, st.mul->getParam(ID(B_SIGNED)).as_bool());
log_assert(GetSize(B) == 16); log_assert(GetSize(B) == 16);
SigSpec CD = st.sigCD; SigSpec CD = st.sigCD;
@ -88,51 +88,51 @@ void create_ice40_dsp(ice40_dsp_pm &pm)
else else
log_assert(GetSize(CD) == 32); log_assert(GetSize(CD) == 32);
cell->setPort("\\A", A); cell->setPort(ID::A, A);
cell->setPort("\\B", B); cell->setPort(ID::B, B);
cell->setPort("\\C", CD.extract(16, 16)); cell->setPort(ID(C), CD.extract(16, 16));
cell->setPort("\\D", CD.extract(0, 16)); cell->setPort(ID(D), CD.extract(0, 16));
cell->setParam("\\A_REG", st.ffA ? State::S1 : State::S0); cell->setParam(ID(A_REG), st.ffA ? State::S1 : State::S0);
cell->setParam("\\B_REG", st.ffB ? State::S1 : State::S0); cell->setParam(ID(B_REG), st.ffB ? State::S1 : State::S0);
cell->setParam("\\C_REG", st.ffCD ? State::S1 : State::S0); cell->setParam(ID(C_REG), st.ffCD ? State::S1 : State::S0);
cell->setParam("\\D_REG", st.ffCD ? State::S1 : State::S0); cell->setParam(ID(D_REG), st.ffCD ? State::S1 : State::S0);
SigSpec AHOLD, BHOLD, CDHOLD; SigSpec AHOLD, BHOLD, CDHOLD;
if (st.ffAholdmux) if (st.ffAholdmux)
AHOLD = st.ffAholdpol ? st.ffAholdmux->getPort("\\S") : pm.module->Not(NEW_ID, st.ffAholdmux->getPort("\\S")); AHOLD = st.ffAholdpol ? st.ffAholdmux->getPort(ID(S)) : pm.module->Not(NEW_ID, st.ffAholdmux->getPort(ID(S)));
else else
AHOLD = State::S0; AHOLD = State::S0;
if (st.ffBholdmux) if (st.ffBholdmux)
BHOLD = st.ffBholdpol ? st.ffBholdmux->getPort("\\S") : pm.module->Not(NEW_ID, st.ffBholdmux->getPort("\\S")); BHOLD = st.ffBholdpol ? st.ffBholdmux->getPort(ID(S)) : pm.module->Not(NEW_ID, st.ffBholdmux->getPort(ID(S)));
else else
BHOLD = State::S0; BHOLD = State::S0;
if (st.ffCDholdmux) if (st.ffCDholdmux)
CDHOLD = st.ffCDholdpol ? st.ffCDholdmux->getPort("\\S") : pm.module->Not(NEW_ID, st.ffCDholdmux->getPort("\\S")); CDHOLD = st.ffCDholdpol ? st.ffCDholdmux->getPort(ID(S)) : pm.module->Not(NEW_ID, st.ffCDholdmux->getPort(ID(S)));
else else
CDHOLD = State::S0; CDHOLD = State::S0;
cell->setPort("\\AHOLD", AHOLD); cell->setPort(ID(AHOLD), AHOLD);
cell->setPort("\\BHOLD", BHOLD); cell->setPort(ID(BHOLD), BHOLD);
cell->setPort("\\CHOLD", CDHOLD); cell->setPort(ID(CHOLD), CDHOLD);
cell->setPort("\\DHOLD", CDHOLD); cell->setPort(ID(DHOLD), CDHOLD);
SigSpec IRSTTOP, IRSTBOT; SigSpec IRSTTOP, IRSTBOT;
if (st.ffArstmux) if (st.ffArstmux)
IRSTTOP = st.ffArstpol ? st.ffArstmux->getPort("\\S") : pm.module->Not(NEW_ID, st.ffArstmux->getPort("\\S")); IRSTTOP = st.ffArstpol ? st.ffArstmux->getPort(ID(S)) : pm.module->Not(NEW_ID, st.ffArstmux->getPort(ID(S)));
else else
IRSTTOP = State::S0; IRSTTOP = State::S0;
if (st.ffBrstmux) if (st.ffBrstmux)
IRSTBOT = st.ffBrstpol ? st.ffBrstmux->getPort("\\S") : pm.module->Not(NEW_ID, st.ffBrstmux->getPort("\\S")); IRSTBOT = st.ffBrstpol ? st.ffBrstmux->getPort(ID(S)) : pm.module->Not(NEW_ID, st.ffBrstmux->getPort(ID(S)));
else else
IRSTBOT = State::S0; IRSTBOT = State::S0;
cell->setPort("\\IRSTTOP", IRSTTOP); cell->setPort(ID(IRSTTOP), IRSTTOP);
cell->setPort("\\IRSTBOT", IRSTBOT); cell->setPort(ID(IRSTBOT), IRSTBOT);
if (st.clock != SigBit()) if (st.clock != SigBit())
{ {
cell->setPort("\\CLK", st.clock); cell->setPort(ID(CLK), st.clock);
cell->setPort("\\CE", State::S1); cell->setPort(ID(CE), State::S1);
cell->setParam("\\NEG_TRIGGER", st.clock_pol ? State::S0 : State::S1); cell->setParam(ID(NEG_TRIGGER), st.clock_pol ? State::S0 : State::S1);
log(" clock: %s (%s)", log_signal(st.clock), st.clock_pol ? "posedge" : "negedge"); log(" clock: %s (%s)", log_signal(st.clock), st.clock_pol ? "posedge" : "negedge");
@ -158,20 +158,20 @@ void create_ice40_dsp(ice40_dsp_pm &pm)
} }
else else
{ {
cell->setPort("\\CLK", State::S0); cell->setPort(ID(CLK), State::S0);
cell->setPort("\\CE", State::S0); cell->setPort(ID(CE), State::S0);
cell->setParam("\\NEG_TRIGGER", State::S0); cell->setParam(ID(NEG_TRIGGER), State::S0);
} }
// SB_MAC16 Cascade Interface // SB_MAC16 Cascade Interface
cell->setPort("\\SIGNEXTIN", State::Sx); cell->setPort(ID(SIGNEXTIN), State::Sx);
cell->setPort("\\SIGNEXTOUT", pm.module->addWire(NEW_ID)); cell->setPort(ID(SIGNEXTOUT), pm.module->addWire(NEW_ID));
cell->setPort("\\CI", State::Sx); cell->setPort(ID(CI), State::Sx);
cell->setPort("\\ACCUMCI", State::Sx); cell->setPort(ID(ACCUMCI), State::Sx);
cell->setPort("\\ACCUMCO", pm.module->addWire(NEW_ID)); cell->setPort(ID(ACCUMCO), pm.module->addWire(NEW_ID));
// SB_MAC16 Output Interface // SB_MAC16 Output Interface
@ -180,91 +180,91 @@ void create_ice40_dsp(ice40_dsp_pm &pm)
if (O_width == 33) { if (O_width == 33) {
log_assert(st.add); log_assert(st.add);
// If we have a signed multiply-add, then perform sign extension // If we have a signed multiply-add, then perform sign extension
if (st.add->getParam("\\A_SIGNED").as_bool() && st.add->getParam("\\B_SIGNED").as_bool()) if (st.add->getParam(ID(A_SIGNED)).as_bool() && st.add->getParam(ID(B_SIGNED)).as_bool())
pm.module->connect(O[32], O[31]); pm.module->connect(O[32], O[31]);
else else
cell->setPort("\\CO", O[32]); cell->setPort(ID(CO), O[32]);
O.remove(O_width-1); O.remove(O_width-1);
} }
else else
cell->setPort("\\CO", pm.module->addWire(NEW_ID)); cell->setPort(ID(CO), pm.module->addWire(NEW_ID));
log_assert(GetSize(O) <= 32); log_assert(GetSize(O) <= 32);
if (GetSize(O) < 32) if (GetSize(O) < 32)
O.append(pm.module->addWire(NEW_ID, 32-GetSize(O))); O.append(pm.module->addWire(NEW_ID, 32-GetSize(O)));
cell->setPort("\\O", O); cell->setPort(ID(O), O);
bool accum = false; bool accum = false;
if (st.add) { if (st.add) {
accum = (st.ffO && st.add->getPort(st.addAB == "\\A" ? "\\B" : "\\A") == st.sigO); accum = (st.ffO && st.add->getPort(st.addAB == ID::A ? ID::B : ID::A) == st.sigO);
if (accum) if (accum)
log(" accumulator %s (%s)\n", log_id(st.add), log_id(st.add->type)); log(" accumulator %s (%s)\n", log_id(st.add), log_id(st.add->type));
else else
log(" adder %s (%s)\n", log_id(st.add), log_id(st.add->type)); log(" adder %s (%s)\n", log_id(st.add), log_id(st.add->type));
cell->setPort("\\ADDSUBTOP", st.add->type == "$add" ? State::S0 : State::S1); cell->setPort(ID(ADDSUBTOP), st.add->type == ID($add) ? State::S0 : State::S1);
cell->setPort("\\ADDSUBBOT", st.add->type == "$add" ? State::S0 : State::S1); cell->setPort(ID(ADDSUBBOT), st.add->type == ID($add) ? State::S0 : State::S1);
} else { } else {
cell->setPort("\\ADDSUBTOP", State::S0); cell->setPort(ID(ADDSUBTOP), State::S0);
cell->setPort("\\ADDSUBBOT", State::S0); cell->setPort(ID(ADDSUBBOT), State::S0);
} }
SigSpec OHOLD; SigSpec OHOLD;
if (st.ffOholdmux) if (st.ffOholdmux)
OHOLD = st.ffOholdpol ? st.ffOholdmux->getPort("\\S") : pm.module->Not(NEW_ID, st.ffOholdmux->getPort("\\S")); OHOLD = st.ffOholdpol ? st.ffOholdmux->getPort(ID(S)) : pm.module->Not(NEW_ID, st.ffOholdmux->getPort(ID(S)));
else else
OHOLD = State::S0; OHOLD = State::S0;
cell->setPort("\\OHOLDTOP", OHOLD); cell->setPort(ID(OHOLDTOP), OHOLD);
cell->setPort("\\OHOLDBOT", OHOLD); cell->setPort(ID(OHOLDBOT), OHOLD);
SigSpec ORST; SigSpec ORST;
if (st.ffOrstmux) if (st.ffOrstmux)
ORST = st.ffOrstpol ? st.ffOrstmux->getPort("\\S") : pm.module->Not(NEW_ID, st.ffOrstmux->getPort("\\S")); ORST = st.ffOrstpol ? st.ffOrstmux->getPort(ID(S)) : pm.module->Not(NEW_ID, st.ffOrstmux->getPort(ID(S)));
else else
ORST = State::S0; ORST = State::S0;
cell->setPort("\\ORSTTOP", ORST); cell->setPort(ID(ORSTTOP), ORST);
cell->setPort("\\ORSTBOT", ORST); cell->setPort(ID(ORSTBOT), ORST);
SigSpec acc_reset = State::S0; SigSpec acc_reset = State::S0;
if (st.mux) { if (st.mux) {
if (st.muxAB == "\\A") if (st.muxAB == ID::A)
acc_reset = st.mux->getPort("\\S"); acc_reset = st.mux->getPort(ID(S));
else else
acc_reset = pm.module->Not(NEW_ID, st.mux->getPort("\\S")); acc_reset = pm.module->Not(NEW_ID, st.mux->getPort(ID(S)));
} }
cell->setPort("\\OLOADTOP", acc_reset); cell->setPort(ID(OLOADTOP), acc_reset);
cell->setPort("\\OLOADBOT", acc_reset); cell->setPort(ID(OLOADBOT), acc_reset);
// SB_MAC16 Remaining Parameters // SB_MAC16 Remaining Parameters
cell->setParam("\\TOP_8x8_MULT_REG", st.ffFJKG ? State::S1 : State::S0); cell->setParam(ID(TOP_8x8_MULT_REG), st.ffFJKG ? State::S1 : State::S0);
cell->setParam("\\BOT_8x8_MULT_REG", st.ffFJKG ? State::S1 : State::S0); cell->setParam(ID(BOT_8x8_MULT_REG), st.ffFJKG ? State::S1 : State::S0);
cell->setParam("\\PIPELINE_16x16_MULT_REG1", st.ffFJKG ? State::S1 : State::S0); cell->setParam(ID(PIPELINE_16x16_MULT_REG1), st.ffFJKG ? State::S1 : State::S0);
cell->setParam("\\PIPELINE_16x16_MULT_REG2", st.ffH ? State::S1 : State::S0); cell->setParam(ID(PIPELINE_16x16_MULT_REG2), st.ffH ? State::S1 : State::S0);
cell->setParam("\\TOPADDSUB_LOWERINPUT", Const(2, 2)); cell->setParam(ID(TOPADDSUB_LOWERINPUT), Const(2, 2));
cell->setParam("\\TOPADDSUB_UPPERINPUT", accum ? State::S0 : State::S1); cell->setParam(ID(TOPADDSUB_UPPERINPUT), accum ? State::S0 : State::S1);
cell->setParam("\\TOPADDSUB_CARRYSELECT", Const(3, 2)); cell->setParam(ID(TOPADDSUB_CARRYSELECT), Const(3, 2));
cell->setParam("\\BOTADDSUB_LOWERINPUT", Const(2, 2)); cell->setParam(ID(BOTADDSUB_LOWERINPUT), Const(2, 2));
cell->setParam("\\BOTADDSUB_UPPERINPUT", accum ? State::S0 : State::S1); cell->setParam(ID(BOTADDSUB_UPPERINPUT), accum ? State::S0 : State::S1);
cell->setParam("\\BOTADDSUB_CARRYSELECT", Const(0, 2)); cell->setParam(ID(BOTADDSUB_CARRYSELECT), Const(0, 2));
cell->setParam("\\MODE_8x8", State::S0); cell->setParam(ID(MODE_8x8), State::S0);
cell->setParam("\\A_SIGNED", st.mul->getParam("\\A_SIGNED").as_bool()); cell->setParam(ID(A_SIGNED), st.mul->getParam(ID(A_SIGNED)).as_bool());
cell->setParam("\\B_SIGNED", st.mul->getParam("\\B_SIGNED").as_bool()); cell->setParam(ID(B_SIGNED), st.mul->getParam(ID(B_SIGNED)).as_bool());
if (st.ffO) { if (st.ffO) {
if (st.o_lo) if (st.o_lo)
cell->setParam("\\TOPOUTPUT_SELECT", Const(st.add ? 0 : 3, 2)); cell->setParam(ID(TOPOUTPUT_SELECT), Const(st.add ? 0 : 3, 2));
else else
cell->setParam("\\TOPOUTPUT_SELECT", Const(1, 2)); cell->setParam(ID(TOPOUTPUT_SELECT), Const(1, 2));
st.ffO->connections_.at("\\Q").replace(O, pm.module->addWire(NEW_ID, GetSize(O))); st.ffO->connections_.at(ID(Q)).replace(O, pm.module->addWire(NEW_ID, GetSize(O)));
cell->setParam("\\BOTOUTPUT_SELECT", Const(1, 2)); cell->setParam(ID(BOTOUTPUT_SELECT), Const(1, 2));
} }
else { else {
cell->setParam("\\TOPOUTPUT_SELECT", Const(st.add ? 0 : 3, 2)); cell->setParam(ID(TOPOUTPUT_SELECT), Const(st.add ? 0 : 3, 2));
cell->setParam("\\BOTOUTPUT_SELECT", Const(st.add ? 0 : 3, 2)); cell->setParam(ID(BOTOUTPUT_SELECT), Const(st.add ? 0 : 3, 2));
} }
if (cell != st.mul) if (cell != st.mul)

View file

@ -27,36 +27,36 @@ PRIVATE_NAMESPACE_BEGIN
#include "passes/pmgen/xilinx_dsp_pm.h" #include "passes/pmgen/xilinx_dsp_pm.h"
static Cell* addDsp(Module *module) { static Cell* addDsp(Module *module) {
Cell *cell = module->addCell(NEW_ID, "\\DSP48E1"); Cell *cell = module->addCell(NEW_ID, ID(DSP48E1));
cell->setParam("\\ACASCREG", 0); cell->setParam(ID(ACASCREG), 0);
cell->setParam("\\ADREG", 0); cell->setParam(ID(ADREG), 0);
cell->setParam("\\A_INPUT", Const("DIRECT")); cell->setParam(ID(A_INPUT), Const("DIRECT"));
cell->setParam("\\ALUMODEREG", 0); cell->setParam(ID(ALUMODEREG), 0);
cell->setParam("\\AREG", 0); cell->setParam(ID(AREG), 0);
cell->setParam("\\BCASCREG", 0); cell->setParam(ID(BCASCREG), 0);
cell->setParam("\\B_INPUT", Const("DIRECT")); cell->setParam(ID(B_INPUT), Const("DIRECT"));
cell->setParam("\\BREG", 0); cell->setParam(ID(BREG), 0);
cell->setParam("\\CARRYINREG", 0); cell->setParam(ID(CARRYINREG), 0);
cell->setParam("\\CARRYINSELREG", 0); cell->setParam(ID(CARRYINSELREG), 0);
cell->setParam("\\CREG", 0); cell->setParam(ID(CREG), 0);
cell->setParam("\\DREG", 0); cell->setParam(ID(DREG), 0);
cell->setParam("\\INMODEREG", 0); cell->setParam(ID(INMODEREG), 0);
cell->setParam("\\MREG", 0); cell->setParam(ID(MREG), 0);
cell->setParam("\\OPMODEREG", 0); cell->setParam(ID(OPMODEREG), 0);
cell->setParam("\\PREG", 0); cell->setParam(ID(PREG), 0);
cell->setParam("\\USE_MULT", Const("NONE")); cell->setParam(ID(USE_MULT), Const("NONE"));
cell->setParam("\\USE_SIMD", Const("ONE48")); cell->setParam(ID(USE_SIMD), Const("ONE48"));
cell->setParam("\\USE_DPORT", Const("FALSE")); cell->setParam(ID(USE_DPORT), Const("FALSE"));
cell->setPort("\\D", Const(0, 24)); cell->setPort(ID(D), Const(0, 24));
cell->setPort("\\INMODE", Const(0, 5)); cell->setPort(ID(INMODE), Const(0, 5));
cell->setPort("\\ALUMODE", Const(0, 4)); cell->setPort(ID(ALUMODE), Const(0, 4));
cell->setPort("\\OPMODE", Const(0, 7)); cell->setPort(ID(OPMODE), Const(0, 7));
cell->setPort("\\CARRYINSEL", Const(0, 3)); cell->setPort(ID(CARRYINSEL), Const(0, 3));
cell->setPort("\\ACIN", Const(0, 30)); cell->setPort(ID(ACIN), Const(0, 30));
cell->setPort("\\BCIN", Const(0, 18)); cell->setPort(ID(BCIN), Const(0, 18));
cell->setPort("\\PCIN", Const(0, 48)); cell->setPort(ID(PCIN), Const(0, 48));
cell->setPort("\\CARRYIN", Const(0, 1)); cell->setPort(ID(CARRYIN), Const(0, 1));
return cell; return cell;
} }
@ -66,25 +66,25 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
std::deque<Cell*> simd24_add, simd24_sub; std::deque<Cell*> simd24_add, simd24_sub;
for (auto cell : selected_cells) { for (auto cell : selected_cells) {
if (!cell->type.in("$add", "$sub")) if (!cell->type.in(ID($add), ID($sub)))
continue; continue;
SigSpec Y = cell->getPort("\\Y"); SigSpec Y = cell->getPort(ID(Y));
if (!Y.is_chunk()) if (!Y.is_chunk())
continue; continue;
if (!Y.as_chunk().wire->get_strpool_attribute("\\use_dsp").count("simd")) if (!Y.as_chunk().wire->get_strpool_attribute(ID(use_dsp)).count("simd"))
continue; continue;
if (GetSize(Y) > 25) if (GetSize(Y) > 25)
continue; continue;
SigSpec A = cell->getPort("\\A"); SigSpec A = cell->getPort(ID(A));
SigSpec B = cell->getPort("\\B"); SigSpec B = cell->getPort(ID(B));
if (GetSize(Y) <= 13) { if (GetSize(Y) <= 13) {
if (GetSize(A) > 12) if (GetSize(A) > 12)
continue; continue;
if (GetSize(B) > 12) if (GetSize(B) > 12)
continue; continue;
if (cell->type == "$add") if (cell->type == ID($add))
simd12_add.push_back(cell); simd12_add.push_back(cell);
else if (cell->type == "$sub") else if (cell->type == ID($sub))
simd12_sub.push_back(cell); simd12_sub.push_back(cell);
} }
else if (GetSize(Y) <= 25) { else if (GetSize(Y) <= 25) {
@ -92,9 +92,9 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
continue; continue;
if (GetSize(B) > 24) if (GetSize(B) > 24)
continue; continue;
if (cell->type == "$add") if (cell->type == ID($add))
simd24_add.push_back(cell); simd24_add.push_back(cell);
else if (cell->type == "$sub") else if (cell->type == ID($sub))
simd24_sub.push_back(cell); simd24_sub.push_back(cell);
} }
else else
@ -102,11 +102,11 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
} }
auto f12 = [module](SigSpec &AB, SigSpec &C, SigSpec &P, SigSpec &CARRYOUT, Cell *lane) { auto f12 = [module](SigSpec &AB, SigSpec &C, SigSpec &P, SigSpec &CARRYOUT, Cell *lane) {
SigSpec A = lane->getPort("\\A"); SigSpec A = lane->getPort(ID(A));
SigSpec B = lane->getPort("\\B"); SigSpec B = lane->getPort(ID(B));
SigSpec Y = lane->getPort("\\Y"); SigSpec Y = lane->getPort(ID(Y));
A.extend_u0(12, lane->getParam("\\A_SIGNED").as_bool()); A.extend_u0(12, lane->getParam(ID(A_SIGNED)).as_bool());
B.extend_u0(12, lane->getParam("\\B_SIGNED").as_bool()); B.extend_u0(12, lane->getParam(ID(B_SIGNED)).as_bool());
AB.append(A); AB.append(A);
C.append(B); C.append(B);
if (GetSize(Y) < 13) if (GetSize(Y) < 13)
@ -139,11 +139,11 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
log("Analysing %s.%s for Xilinx DSP SIMD12 packing.\n", log_id(module), log_id(lane1)); log("Analysing %s.%s for Xilinx DSP SIMD12 packing.\n", log_id(module), log_id(lane1));
Cell *cell = addDsp(module); Cell *cell = addDsp(module);
cell->setParam("\\USE_SIMD", Const("FOUR12")); cell->setParam(ID(USE_SIMD), Const("FOUR12"));
// X = A:B // X = A:B
// Y = 0 // Y = 0
// Z = C // Z = C
cell->setPort("\\OPMODE", Const::from_string("0110011")); cell->setPort(ID(OPMODE), Const::from_string("0110011"));
log_assert(lane1); log_assert(lane1);
log_assert(lane2); log_assert(lane2);
@ -170,13 +170,13 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
log_assert(GetSize(C) == 48); log_assert(GetSize(C) == 48);
log_assert(GetSize(P) == 48); log_assert(GetSize(P) == 48);
log_assert(GetSize(CARRYOUT) == 4); log_assert(GetSize(CARRYOUT) == 4);
cell->setPort("\\A", AB.extract(18, 30)); cell->setPort(ID(A), AB.extract(18, 30));
cell->setPort("\\B", AB.extract(0, 18)); cell->setPort(ID(B), AB.extract(0, 18));
cell->setPort("\\C", C); cell->setPort(ID(C), C);
cell->setPort("\\P", P); cell->setPort(ID(P), P);
cell->setPort("\\CARRYOUT", CARRYOUT); cell->setPort(ID(CARRYOUT), CARRYOUT);
if (lane1->type == "$sub") if (lane1->type == ID($sub))
cell->setPort("\\ALUMODE", Const::from_string("0011")); cell->setPort(ID(ALUMODE), Const::from_string("0011"));
module->remove(lane1); module->remove(lane1);
module->remove(lane2); module->remove(lane2);
@ -190,11 +190,11 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
g12(simd12_sub); g12(simd12_sub);
auto f24 = [module](SigSpec &AB, SigSpec &C, SigSpec &P, SigSpec &CARRYOUT, Cell *lane) { auto f24 = [module](SigSpec &AB, SigSpec &C, SigSpec &P, SigSpec &CARRYOUT, Cell *lane) {
SigSpec A = lane->getPort("\\A"); SigSpec A = lane->getPort(ID(A));
SigSpec B = lane->getPort("\\B"); SigSpec B = lane->getPort(ID(B));
SigSpec Y = lane->getPort("\\Y"); SigSpec Y = lane->getPort(ID(Y));
A.extend_u0(24, lane->getParam("\\A_SIGNED").as_bool()); A.extend_u0(24, lane->getParam(ID(A_SIGNED)).as_bool());
B.extend_u0(24, lane->getParam("\\B_SIGNED").as_bool()); B.extend_u0(24, lane->getParam(ID(B_SIGNED)).as_bool());
C.append(A); C.append(A);
AB.append(B); AB.append(B);
if (GetSize(Y) < 25) if (GetSize(Y) < 25)
@ -220,11 +220,11 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
log("Analysing %s.%s for Xilinx DSP SIMD24 packing.\n", log_id(module), log_id(lane1)); log("Analysing %s.%s for Xilinx DSP SIMD24 packing.\n", log_id(module), log_id(lane1));
Cell *cell = addDsp(module); Cell *cell = addDsp(module);
cell->setParam("\\USE_SIMD", Const("TWO24")); cell->setParam(ID(USE_SIMD), Const("TWO24"));
// X = A:B // X = A:B
// Y = 0 // Y = 0
// Z = C // Z = C
cell->setPort("\\OPMODE", Const::from_string("0110011")); cell->setPort(ID(OPMODE), Const::from_string("0110011"));
log_assert(lane1); log_assert(lane1);
log_assert(lane2); log_assert(lane2);
@ -234,13 +234,13 @@ void pack_xilinx_simd(Module *module, const std::vector<Cell*> &selected_cells)
log_assert(GetSize(C) == 48); log_assert(GetSize(C) == 48);
log_assert(GetSize(P) == 48); log_assert(GetSize(P) == 48);
log_assert(GetSize(CARRYOUT) == 4); log_assert(GetSize(CARRYOUT) == 4);
cell->setPort("\\A", AB.extract(18, 30)); cell->setPort(ID(A), AB.extract(18, 30));
cell->setPort("\\B", AB.extract(0, 18)); cell->setPort(ID(B), AB.extract(0, 18));
cell->setPort("\\C", C); cell->setPort(ID(C), C);
cell->setPort("\\P", P); cell->setPort(ID(P), P);
cell->setPort("\\CARRYOUT", CARRYOUT); cell->setPort(ID(CARRYOUT), CARRYOUT);
if (lane1->type == "$sub") if (lane1->type == ID($sub))
cell->setPort("\\ALUMODE", Const::from_string("0011")); cell->setPort(ID(ALUMODE), Const::from_string("0011"));
module->remove(lane1); module->remove(lane1);
module->remove(lane2); module->remove(lane2);
@ -281,37 +281,37 @@ void pack_xilinx_dsp(dict<SigBit, Cell*> &bit_to_driver, xilinx_dsp_pm &pm)
if (st.preAdd) { if (st.preAdd) {
log(" preadder %s (%s)\n", log_id(st.preAdd), log_id(st.preAdd->type)); log(" preadder %s (%s)\n", log_id(st.preAdd), log_id(st.preAdd->type));
bool A_SIGNED = st.preAdd->getParam("\\A_SIGNED").as_bool(); bool A_SIGNED = st.preAdd->getParam(ID(A_SIGNED)).as_bool();
bool D_SIGNED = st.preAdd->getParam("\\B_SIGNED").as_bool(); bool D_SIGNED = st.preAdd->getParam(ID(B_SIGNED)).as_bool();
if (st.sigA == st.preAdd->getPort("\\B")) if (st.sigA == st.preAdd->getPort(ID(B)))
std::swap(A_SIGNED, D_SIGNED); std::swap(A_SIGNED, D_SIGNED);
st.sigA.extend_u0(30, A_SIGNED); st.sigA.extend_u0(30, A_SIGNED);
st.sigD.extend_u0(25, D_SIGNED); st.sigD.extend_u0(25, D_SIGNED);
cell->setPort("\\A", st.sigA); cell->setPort(ID(A), st.sigA);
cell->setPort("\\D", st.sigD); cell->setPort(ID(D), st.sigD);
cell->connections_.at("\\INMODE") = Const::from_string("00100"); cell->connections_.at(ID(INMODE)) = Const::from_string("00100");
if (st.ffAD) { if (st.ffAD) {
if (st.ffADcemux) { if (st.ffADcemux) {
SigSpec S = st.ffADcemux->getPort("\\S"); SigSpec S = st.ffADcemux->getPort(ID(S));
cell->setPort("\\CEAD", st.ffADcepol ? S : pm.module->Not(NEW_ID, S)); cell->setPort(ID(CEAD), st.ffADcepol ? S : pm.module->Not(NEW_ID, S));
} }
else else
cell->setPort("\\CEAD", State::S1); cell->setPort(ID(CEAD), State::S1);
cell->setParam("\\ADREG", 1); cell->setParam(ID(ADREG), 1);
} }
cell->setParam("\\USE_DPORT", Const("TRUE")); cell->setParam(ID(USE_DPORT), Const("TRUE"));
pm.autoremove(st.preAdd); pm.autoremove(st.preAdd);
} }
if (st.postAdd) { if (st.postAdd) {
log(" postadder %s (%s)\n", log_id(st.postAdd), log_id(st.postAdd->type)); log(" postadder %s (%s)\n", log_id(st.postAdd), log_id(st.postAdd->type));
SigSpec &opmode = cell->connections_.at("\\OPMODE"); SigSpec &opmode = cell->connections_.at(ID(OPMODE));
if (st.postAddMux) { if (st.postAddMux) {
log_assert(st.ffP); log_assert(st.ffP);
opmode[4] = st.postAddMux->getPort("\\S"); opmode[4] = st.postAddMux->getPort(ID(S));
pm.autoremove(st.postAddMux); pm.autoremove(st.postAddMux);
} }
else if (st.ffP && st.sigC == st.sigP) else if (st.ffP && st.sigC == st.sigP)
@ -322,23 +322,23 @@ void pack_xilinx_dsp(dict<SigBit, Cell*> &bit_to_driver, xilinx_dsp_pm &pm)
opmode[5] = State::S1; opmode[5] = State::S1;
if (opmode[4] != State::S0) { if (opmode[4] != State::S0) {
if (st.postAddMuxAB == "\\A") if (st.postAddMuxAB == ID(A))
st.sigC.extend_u0(48, st.postAdd->getParam("\\B_SIGNED").as_bool()); st.sigC.extend_u0(48, st.postAdd->getParam(ID(B_SIGNED)).as_bool());
else else
st.sigC.extend_u0(48, st.postAdd->getParam("\\A_SIGNED").as_bool()); st.sigC.extend_u0(48, st.postAdd->getParam(ID(A_SIGNED)).as_bool());
cell->setPort("\\C", st.sigC); cell->setPort(ID(C), st.sigC);
} }
pm.autoremove(st.postAdd); pm.autoremove(st.postAdd);
} }
if (st.overflow) { if (st.overflow) {
log(" overflow %s (%s)\n", log_id(st.overflow), log_id(st.overflow->type)); log(" overflow %s (%s)\n", log_id(st.overflow), log_id(st.overflow->type));
cell->setParam("\\USE_PATTERN_DETECT", Const("PATDET")); cell->setParam(ID(USE_PATTERN_DETECT), Const("PATDET"));
cell->setParam("\\SEL_PATTERN", Const("PATTERN")); cell->setParam(ID(SEL_PATTERN), Const("PATTERN"));
cell->setParam("\\SEL_MASK", Const("MASK")); cell->setParam(ID(SEL_MASK), Const("MASK"));
if (st.overflow->type == "$ge") { if (st.overflow->type == ID($ge)) {
Const B = st.overflow->getPort("\\B").as_const(); Const B = st.overflow->getPort(ID(B)).as_const();
log_assert(std::count(B.bits.begin(), B.bits.end(), State::S1) == 1); log_assert(std::count(B.bits.begin(), B.bits.end(), State::S1) == 1);
// Since B is an exact power of 2, subtract 1 // Since B is an exact power of 2, subtract 1
// by inverting all bits up until hitting // by inverting all bits up until hitting
@ -351,9 +351,9 @@ void pack_xilinx_dsp(dict<SigBit, Cell*> &bit_to_driver, xilinx_dsp_pm &pm)
} }
B.extu(48); B.extu(48);
cell->setParam("\\MASK", B); cell->setParam(ID(MASK), B);
cell->setParam("\\PATTERN", Const(0, 48)); cell->setParam(ID(PATTERN), Const(0, 48));
cell->setPort("\\OVERFLOW", st.overflow->getPort("\\Y")); cell->setPort(ID(OVERFLOW), st.overflow->getPort(ID(Y)));
} }
else log_abort(); else log_abort();
@ -362,29 +362,29 @@ void pack_xilinx_dsp(dict<SigBit, Cell*> &bit_to_driver, xilinx_dsp_pm &pm)
if (st.clock != SigBit()) if (st.clock != SigBit())
{ {
cell->setPort("\\CLK", st.clock); cell->setPort(ID(CLK), st.clock);
auto f = [&pm,cell](SigSpec &A, Cell* ff, Cell* cemux, bool cepol, IdString ceport, Cell* rstmux, bool rstpol, IdString rstport) { auto f = [&pm,cell](SigSpec &A, Cell* ff, Cell* cemux, bool cepol, IdString ceport, Cell* rstmux, bool rstpol, IdString rstport) {
SigSpec D = ff->getPort("\\D"); SigSpec D = ff->getPort(ID(D));
SigSpec Q = pm.sigmap(ff->getPort("\\Q")); SigSpec Q = pm.sigmap(ff->getPort(ID(Q)));
if (!A.empty()) if (!A.empty())
A.replace(Q, D); A.replace(Q, D);
if (rstmux) { if (rstmux) {
SigSpec Y = rstmux->getPort("\\Y"); SigSpec Y = rstmux->getPort(ID(Y));
SigSpec AB = rstmux->getPort(rstpol ? "\\A" : "\\B"); SigSpec AB = rstmux->getPort(rstpol ? ID(A) : ID(B));
if (!A.empty()) if (!A.empty())
A.replace(Y, AB); A.replace(Y, AB);
if (rstport != IdString()) { if (rstport != IdString()) {
SigSpec S = rstmux->getPort("\\S"); SigSpec S = rstmux->getPort(ID(S));
cell->setPort(rstport, rstpol ? S : pm.module->Not(NEW_ID, S)); cell->setPort(rstport, rstpol ? S : pm.module->Not(NEW_ID, S));
} }
} }
else if (rstport != IdString()) else if (rstport != IdString())
cell->setPort(rstport, State::S0); cell->setPort(rstport, State::S0);
if (cemux) { if (cemux) {
SigSpec Y = cemux->getPort("\\Y"); SigSpec Y = cemux->getPort(ID(Y));
SigSpec BA = cemux->getPort(cepol ? "\\B" : "\\A"); SigSpec BA = cemux->getPort(cepol ? ID(B) : ID(A));
SigSpec S = cemux->getPort("\\S"); SigSpec S = cemux->getPort(ID(S));
if (!A.empty()) if (!A.empty())
A.replace(Y, BA); A.replace(Y, BA);
cell->setPort(ceport, cepol ? S : pm.module->Not(NEW_ID, S)); cell->setPort(ceport, cepol ? S : pm.module->Not(NEW_ID, S));
@ -393,7 +393,7 @@ void pack_xilinx_dsp(dict<SigBit, Cell*> &bit_to_driver, xilinx_dsp_pm &pm)
cell->setPort(ceport, State::S1); cell->setPort(ceport, State::S1);
for (auto c : Q.chunks()) { for (auto c : Q.chunks()) {
auto it = c.wire->attributes.find("\\init"); auto it = c.wire->attributes.find(ID(init));
if (it == c.wire->attributes.end()) if (it == c.wire->attributes.end())
continue; continue;
for (int i = c.offset; i < c.offset+c.width; i++) { for (int i = c.offset; i < c.offset+c.width; i++) {
@ -404,50 +404,50 @@ void pack_xilinx_dsp(dict<SigBit, Cell*> &bit_to_driver, xilinx_dsp_pm &pm)
}; };
if (st.ffA2) { if (st.ffA2) {
SigSpec &A = cell->connections_.at("\\A"); SigSpec &A = cell->connections_.at(ID(A));
f(A, st.ffA2, st.ffA2cemux, st.ffA2cepol, "\\CEA2", st.ffA2rstmux, st.ffArstpol, "\\RSTA"); f(A, st.ffA2, st.ffA2cemux, st.ffA2cepol, ID(CEA2), st.ffA2rstmux, st.ffArstpol, ID(RSTA));
pm.add_siguser(A, cell); pm.add_siguser(A, cell);
if (st.ffA1) { if (st.ffA1) {
f(A, st.ffA1, st.ffA1cemux, st.ffA1cepol, "\\CEA1", st.ffA1rstmux, st.ffArstpol, IdString()); f(A, st.ffA1, st.ffA1cemux, st.ffA1cepol, ID(CEA1), st.ffA1rstmux, st.ffArstpol, IdString());
cell->setParam("\\AREG", 2); cell->setParam(ID(AREG), 2);
} }
else else
cell->setParam("\\AREG", 1); cell->setParam(ID(AREG), 1);
} }
if (st.ffB2) { if (st.ffB2) {
SigSpec &B = cell->connections_.at("\\B"); SigSpec &B = cell->connections_.at(ID(B));
f(B, st.ffB2, st.ffB2cemux, st.ffB2cepol, "\\CEB2", st.ffB2rstmux, st.ffBrstpol, "\\RSTB"); f(B, st.ffB2, st.ffB2cemux, st.ffB2cepol, ID(CEB2), st.ffB2rstmux, st.ffBrstpol, ID(RSTB));
pm.add_siguser(B, cell); pm.add_siguser(B, cell);
if (st.ffB1) { if (st.ffB1) {
f(B, st.ffB1, st.ffB1cemux, st.ffB1cepol, "\\CEB1", st.ffB1rstmux, st.ffBrstpol, IdString()); f(B, st.ffB1, st.ffB1cemux, st.ffB1cepol, ID(CEB1), st.ffB1rstmux, st.ffBrstpol, IdString());
cell->setParam("\\BREG", 2); cell->setParam(ID(BREG), 2);
} }
else else
cell->setParam("\\BREG", 1); cell->setParam(ID(BREG), 1);
} }
if (st.ffC) { if (st.ffC) {
SigSpec &C = cell->connections_.at("\\C"); SigSpec &C = cell->connections_.at(ID(C));
f(C, st.ffC, st.ffCcemux, st.ffCcepol, "\\CEC", st.ffCrstmux, st.ffCrstpol, "\\RSTC"); f(C, st.ffC, st.ffCcemux, st.ffCcepol, ID(CEC), st.ffCrstmux, st.ffCrstpol, ID(RSTC));
pm.add_siguser(C, cell); pm.add_siguser(C, cell);
cell->setParam("\\CREG", 1); cell->setParam(ID(CREG), 1);
} }
if (st.ffD) { if (st.ffD) {
SigSpec &D = cell->connections_.at("\\D"); SigSpec &D = cell->connections_.at(ID(D));
f(D, st.ffD, st.ffDcemux, st.ffDcepol, "\\CED", st.ffDrstmux, st.ffDrstpol, "\\RSTD"); f(D, st.ffD, st.ffDcemux, st.ffDcepol, ID(CED), st.ffDrstmux, st.ffDrstpol, ID(RSTD));
pm.add_siguser(D, cell); pm.add_siguser(D, cell);
cell->setParam("\\DREG", 1); cell->setParam(ID(DREG), 1);
} }
if (st.ffM) { if (st.ffM) {
SigSpec M; // unused SigSpec M; // unused
f(M, st.ffM, st.ffMcemux, st.ffMcepol, "\\CEM", st.ffMrstmux, st.ffMrstpol, "\\RSTM"); f(M, st.ffM, st.ffMcemux, st.ffMcepol, ID(CEM), st.ffMrstmux, st.ffMrstpol, ID(RSTM));
st.ffM->connections_.at("\\Q").replace(st.sigM, pm.module->addWire(NEW_ID, GetSize(st.sigM))); st.ffM->connections_.at(ID(Q)).replace(st.sigM, pm.module->addWire(NEW_ID, GetSize(st.sigM)));
cell->setParam("\\MREG", State::S1); cell->setParam(ID(MREG), State::S1);
} }
if (st.ffP) { if (st.ffP) {
SigSpec P; // unused SigSpec P; // unused
f(P, st.ffP, st.ffPcemux, st.ffPcepol, "\\CEP", st.ffPrstmux, st.ffPrstpol, "\\RSTP"); f(P, st.ffP, st.ffPcemux, st.ffPcepol, ID(CEP), st.ffPrstmux, st.ffPrstpol, ID(RSTP));
st.ffP->connections_.at("\\Q").replace(st.sigP, pm.module->addWire(NEW_ID, GetSize(st.sigP))); st.ffP->connections_.at(ID(Q)).replace(st.sigP, pm.module->addWire(NEW_ID, GetSize(st.sigP)));
cell->setParam("\\PREG", State::S1); cell->setParam(ID(PREG), State::S1);
} }
log(" clock: %s (%s)", log_signal(st.clock), "posedge"); log(" clock: %s (%s)", log_signal(st.clock), "posedge");
@ -485,7 +485,7 @@ void pack_xilinx_dsp(dict<SigBit, Cell*> &bit_to_driver, xilinx_dsp_pm &pm)
SigSpec P = st.sigP; SigSpec P = st.sigP;
if (GetSize(P) < 48) if (GetSize(P) < 48)
P.append(pm.module->addWire(NEW_ID, 48-GetSize(P))); P.append(pm.module->addWire(NEW_ID, 48-GetSize(P)));
cell->setPort("\\P", P); cell->setPort(ID(P), P);
bit_to_driver.insert(std::make_pair(P[0], cell)); bit_to_driver.insert(std::make_pair(P[0], cell));
bit_to_driver.insert(std::make_pair(P[17], cell)); bit_to_driver.insert(std::make_pair(P[17], cell));
@ -553,14 +553,14 @@ struct XilinxDspPass : public Pass {
// NB: Needs to be done after pattern matcher has folded all // NB: Needs to be done after pattern matcher has folded all
// $add cells into the DSP // $add cells into the DSP
for (auto cell : module->cells()) { for (auto cell : module->cells()) {
if (cell->type != "\\DSP48E1") if (cell->type != ID(DSP48E1))
continue; continue;
if (cell->parameters.at("\\CREG", State::S1).as_bool()) if (cell->parameters.at(ID(CREG), State::S1).as_bool())
continue; continue;
SigSpec &opmode = cell->connections_.at("\\OPMODE"); SigSpec &opmode = cell->connections_.at(ID(OPMODE));
if (opmode.extract(4,3) != Const::from_string("011")) if (opmode.extract(4,3) != Const::from_string("011"))
continue; continue;
SigSpec C = unextend(pm.sigmap(cell->getPort("\\C"))); SigSpec C = unextend(pm.sigmap(cell->getPort(ID(C))));
if (!C[0].wire) if (!C[0].wire)
continue; continue;
auto it = bit_to_driver.find(C[0]); auto it = bit_to_driver.find(C[0]);
@ -568,22 +568,22 @@ struct XilinxDspPass : public Pass {
continue; continue;
auto driver = it->second; auto driver = it->second;
SigSpec P = driver->getPort("\\P"); SigSpec P = driver->getPort(ID(P));
if (GetSize(P) >= GetSize(C) && P.extract(0, GetSize(C)) == C) { if (GetSize(P) >= GetSize(C) && P.extract(0, GetSize(C)) == C) {
cell->setPort("\\C", Const(0, 48)); cell->setPort(ID(C), Const(0, 48));
Wire *cascade = module->addWire(NEW_ID, 48); Wire *cascade = module->addWire(NEW_ID, 48);
driver->setPort("\\PCOUT", cascade); driver->setPort(ID(PCOUT), cascade);
cell->setPort("\\PCIN", cascade); cell->setPort(ID(PCIN), cascade);
opmode[6] = State::S0; opmode[6] = State::S0;
opmode[5] = State::S0; opmode[5] = State::S0;
opmode[4] = State::S1; opmode[4] = State::S1;
bit_to_driver.erase(it); bit_to_driver.erase(it);
} }
else if (GetSize(P) >= GetSize(C)+17 && P.extract(17, GetSize(C)) == C) { else if (GetSize(P) >= GetSize(C)+17 && P.extract(17, GetSize(C)) == C) {
cell->setPort("\\C", Const(0, 48)); cell->setPort(ID(C), Const(0, 48));
Wire *cascade = module->addWire(NEW_ID, 48); Wire *cascade = module->addWire(NEW_ID, 48);
driver->setPort("\\PCOUT", cascade); driver->setPort(ID(PCOUT), cascade);
cell->setPort("\\PCIN", cascade); cell->setPort(ID(PCIN), cascade);
opmode[6] = State::S1; opmode[6] = State::S1;
opmode[5] = State::S0; opmode[5] = State::S0;
opmode[4] = State::S1; opmode[4] = State::S1;