mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-04-12 20:18:20 +00:00
Code Activity

Fix static shift operands, neg result type, minor formatting

Browse source 
Static shift operands must be constants.
The result of FIRRTL's neg operator is signed.
Fix poor indentation for gen_read().
This commit is contained in:
Jim Lawson 2019-05-21 13:04:56 -07:00
parent 489c555b41
commit a5131e2896
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
backends/firrtl/firrtl.cc
View file

@ -146,7 +146,7 @@ struct FirrtlWorker
if (!mask.is_fully_def()) if (!mask.is_fully_def())
this->ena = SigSpec(RTLIL::Const(1)); this->ena = SigSpec(RTLIL::Const(1));
} }
string gen_read(const char * /* indent */) { string gen_read(const char * /* indent */) {
log_error("gen_read called on write_port: %s\n", name.c_str()); log_error("gen_read called on write_port: %s\n", name.c_str());
return stringf("gen_read called on write_port: %s\n", name.c_str()); return stringf("gen_read called on write_port: %s\n", name.c_str());
} }
@ -449,8 +449,10 @@ struct FirrtlWorker
string primop; string primop;
bool always_uint = false; bool always_uint = false;
if (cell->type == "$not") primop = "not"; if (cell->type == "$not") primop = "not";
else if (cell->type == "$neg") primop = "neg"; else if (cell->type == "$neg") {
else if (cell->type == "$logic_not") { primop = "neg";
is_signed = true; // Result of "neg" is signed (an SInt).
} else if (cell->type == "$logic_not") {
primop = "eq"; primop = "eq";
a_expr = stringf("%s, UInt(0)", a_expr.c_str()); a_expr = stringf("%s, UInt(0)", a_expr.c_str());
} }
@ -562,6 +564,7 @@ struct FirrtlWorker
auto b_sig = cell->getPort("\\B"); auto b_sig = cell->getPort("\\B");
if (b_sig.is_fully_const()) { if (b_sig.is_fully_const()) {
primop = "shl"; primop = "shl";
b_expr = std::to_string(b_sig.as_int());
} else { } else {
primop = "dshl"; primop = "dshl";
// Convert from FIRRTL left shift semantics. // Convert from FIRRTL left shift semantics.
@ -575,6 +578,7 @@ struct FirrtlWorker
auto b_sig = cell->getPort("\\B"); auto b_sig = cell->getPort("\\B");
if (b_sig.is_fully_const()) { if (b_sig.is_fully_const()) {
primop = "shr"; primop = "shr";
b_expr = std::to_string(b_sig.as_int());
} else { } else {
primop = "dshr"; primop = "dshr";
} }