mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-06-13 17:36:16 +00:00
Code Activity

Merge pull request #3988 from YosysHQ/micko/fix_leak

Browse source 
Fix readline/editline memory leak
This commit is contained in:
Lofty 2023-10-07 20:50:01 +01:00 • committed by GitHub
commit a1923a5f77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
kernel/yosys.cc
View file

@ -1353,8 +1353,12 @@ void shell(RTLIL::Design *design)
if ((command = fgets(command_buffer, 4096, stdin)) == NULL) if ((command = fgets(command_buffer, 4096, stdin)) == NULL)
break; break;
#endif #endif
if (command[strspn(command, " \t\r\n")] == 0) if (command[strspn(command, " \t\r\n")] == 0) {
#if defined(YOSYS_ENABLE_READLINE) || defined(YOSYS_ENABLE_EDITLINE)
free(command);
#endif
continue; continue;
}
#if defined(YOSYS_ENABLE_READLINE) || defined(YOSYS_ENABLE_EDITLINE) #if defined(YOSYS_ENABLE_READLINE) || defined(YOSYS_ENABLE_EDITLINE)
add_history(command); add_history(command);
#endif #endif
@ -1376,10 +1380,17 @@ void shell(RTLIL::Design *design)
log_reset_stack(); log_reset_stack();
} }
design->check(); design->check();
#if defined(YOSYS_ENABLE_READLINE) || defined(YOSYS_ENABLE_EDITLINE)
if (command)
free(command);
#endif
} }
if (command == NULL) if (command == NULL)
printf("exit\n"); printf("exit\n");
#if defined(YOSYS_ENABLE_READLINE) || defined(YOSYS_ENABLE_EDITLINE)
else
free(command);
#endif
recursion_counter--; recursion_counter--;
log_cmd_error_throw = false; log_cmd_error_throw = false;
} }