From bccfdef05de76e387df92891a5267a2ee12cd77a Mon Sep 17 00:00:00 2001 From: Miodrag Milanovic Date: Wed, 18 Mar 2026 17:48:28 +0100 Subject: [PATCH 1/2] Check results properly --- .github/workflows/extra-builds.yml | 12 ++++++++++-- .github/workflows/test-build.yml | 12 ++++++++++-- .github/workflows/test-compile.yml | 10 +++++++++- .github/workflows/test-sanitizers.yml | 12 ++++++++++-- .github/workflows/test-verific.yml | 10 +++++++++- 5 files changed, 48 insertions(+), 8 deletions(-) diff --git a/.github/workflows/extra-builds.yml b/.github/workflows/extra-builds.yml index d301ea882..33fa0fd2f 100644 --- a/.github/workflows/extra-builds.yml +++ b/.github/workflows/extra-builds.yml @@ -138,6 +138,14 @@ jobs: - vs-build - wasi-build - nix-build - if: always() && !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') + if: always() steps: - - run: echo "All good" \ No newline at end of file + - name: Check results + run: | + echo "Needs results: ${{ join(needs.*.result, ',') }}" + if [[ "${{ join(needs.*.result, ',') }}" == *failure* ]] || \ + [[ "${{ join(needs.*.result, ',') }}" == *cancelled* ]]; then + echo "Some jobs failed or were cancelled" + exit 1 + fi + - run: echo "All good" diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml index ac5591b5c..29820f3c0 100644 --- a/.github/workflows/test-build.yml +++ b/.github/workflows/test-build.yml @@ -287,6 +287,14 @@ jobs: - test-cells - test-docs - test-docs-build - if: always() && !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') + if: always() steps: - - run: echo "All good" \ No newline at end of file + - name: Check results + run: | + echo "Needs results: ${{ join(needs.*.result, ',') }}" + if [[ "${{ join(needs.*.result, ',') }}" == *failure* ]] || \ + [[ "${{ join(needs.*.result, ',') }}" == *cancelled* ]]; then + echo "Some jobs failed or were cancelled" + exit 1 + fi + - run: echo "All good" diff --git a/.github/workflows/test-compile.yml b/.github/workflows/test-compile.yml index 7536ecebe..7632a0308 100644 --- a/.github/workflows/test-compile.yml +++ b/.github/workflows/test-compile.yml @@ -100,6 +100,14 @@ jobs: runs-on: ubuntu-latest needs: - test-compile - if: always() && !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') + if: always() steps: + - name: Check results + run: | + echo "Needs results: ${{ join(needs.*.result, ',') }}" + if [[ "${{ join(needs.*.result, ',') }}" == *failure* ]] || \ + [[ "${{ join(needs.*.result, ',') }}" == *cancelled* ]]; then + echo "Some jobs failed or were cancelled" + exit 1 + fi - run: echo "All good" diff --git a/.github/workflows/test-sanitizers.yml b/.github/workflows/test-sanitizers.yml index 85417f746..4cdc865c2 100644 --- a/.github/workflows/test-sanitizers.yml +++ b/.github/workflows/test-sanitizers.yml @@ -86,6 +86,14 @@ jobs: runs-on: ubuntu-latest needs: - run_san - if: always() && !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') + if: always() steps: - - run: echo "All good" + - name: Check results + run: | + echo "Needs results: ${{ join(needs.*.result, ',') }}" + if [[ "${{ join(needs.*.result, ',') }}" == *failure* ]] || \ + [[ "${{ join(needs.*.result, ',') }}" == *cancelled* ]]; then + echo "Some jobs failed or were cancelled" + exit 1 + fi + - run: echo "All good" \ No newline at end of file diff --git a/.github/workflows/test-verific.yml b/.github/workflows/test-verific.yml index cd88f547e..65efca79f 100644 --- a/.github/workflows/test-verific.yml +++ b/.github/workflows/test-verific.yml @@ -129,6 +129,14 @@ jobs: needs: - test-verific - test-pyosys - if: always() && !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') + if: always() steps: + - name: Check results + run: | + echo "Needs results: ${{ join(needs.*.result, ',') }}" + if [[ "${{ join(needs.*.result, ',') }}" == *failure* ]] || \ + [[ "${{ join(needs.*.result, ',') }}" == *cancelled* ]]; then + echo "Some jobs failed or were cancelled" + exit 1 + fi - run: echo "All good" From c4cc53a72e4967868ec801fd07022414585b221f Mon Sep 17 00:00:00 2001 From: Lofty Date: Wed, 18 Mar 2026 16:56:08 +0000 Subject: [PATCH 2/2] synth: fix after abc -fast removal --- techlibs/common/synth.cc | 8 ++++---- tests/techmap/abc9.ys | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/techlibs/common/synth.cc b/techlibs/common/synth.cc index 0dbb7cbec..0623bf43d 100644 --- a/techlibs/common/synth.cc +++ b/techlibs/common/synth.cc @@ -326,13 +326,13 @@ struct SynthPass : public ScriptPass { if ((!noabc && !flowmap) || help_mode) { #ifdef YOSYS_ENABLE_ABC if (help_mode) { - run(abc + " -fast", " (unless -noabc, unless -lut)"); - run(abc + " -fast -lut k", "(unless -noabc, if -lut)"); + run(abc, " (unless -noabc, unless -lut)"); + run(abc + " -lut k", "(unless -noabc, if -lut)"); } else { if (lut) - run(stringf("%s -fast -lut %d", abc, lut)); + run(stringf("%s -lut %d", abc, lut)); else - run(abc + " -fast"); + run(abc); } run("opt -fast", " (unless -noabc)"); #endif diff --git a/tests/techmap/abc9.ys b/tests/techmap/abc9.ys index 2140dde26..c7a97ec4f 100644 --- a/tests/techmap/abc9.ys +++ b/tests/techmap/abc9.ys @@ -17,7 +17,8 @@ design -save gold abc9 -lut 4 design -load gold -abc9 -lut 4 -fast +scratchpad -copy abc9.script.default.fast abc9.script +abc9 -lut 4 design -load gold scratchpad -copy abc9.script.default.area abc9.script