mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-04-06 17:44:09 +00:00
Code Activity

Merge pull request #4922 from Anhijkt/fix-splitcells-assert

Browse source 
splitcells: Fix the assertion bug caused by out-of-bound offset
This commit is contained in:
KrystalDelusion 2025-03-14 16:52:38 +13:00 committed by GitHub
parent 9fa1f0e70c be3dfdc5ad
commit 9f1271bee0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 45 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
passes/cmds/splitcells.cc
View file

@ -103,8 +103,7 @@ struct SplitcellsWorker
auto slice_signal = [&](SigSpec old_sig) -> SigSpec { auto slice_signal = [&](SigSpec old_sig) -> SigSpec {
SigSpec new_sig; SigSpec new_sig;
for (int i = 0; i < GetSize(old_sig); i += GetSize(outsig)) { for (int offset = slice_lsb; offset < GetSize(old_sig); offset += GetSize(outsig)) {
int offset = i+slice_lsb;
int length = std::min(GetSize(old_sig)-offset, slice_msb-slice_lsb+1); int length = std::min(GetSize(old_sig)-offset, slice_msb-slice_lsb+1);
new_sig.append(old_sig.extract(offset, length)); new_sig.append(old_sig.extract(offset, length));
} }

44
tests/various/bug4909.ys Normal file
View file

@ -0,0 +1,44 @@
read_rtlil << EOF
autoidx 20
attribute \src "3510.v:2.1-26.10"
attribute \cells_not_processed 1
attribute \tamara_triplicate 1
module \top
attribute \src "3510.v:14.3-17.8"
wire width 4 $0\reg5[3:0]
attribute $bugpoint 1
wire width 4 $auto$bugpoint.cc:258:simplify_something$12
wire $delete_wire$14
attribute \src "3510.v:13.19-13.59"
wire width 4 $xnor$3510.v:13$1_Y
attribute \src "3510.v:11.23-11.27"
wire width 4 \reg5
attribute \src "3510.v:8.24-8.29"
wire width 3 \wire4
attribute \src "3510.v:3.33-3.34"
wire width 12 output 1 \y
attribute \src "3510.v:13.19-13.59"
cell $xnor $xnor$3510.v:13$1
parameter \A_SIGNED 0
parameter \A_WIDTH 3
parameter \B_SIGNED 0
parameter \B_WIDTH 4
parameter \Y_WIDTH 4
connect \A 3'x
connect \B $auto$bugpoint.cc:258:simplify_something$12
connect \Y $xnor$3510.v:13$1_Y
end
attribute \src "3510.v:14.3-17.8"
process $proc$3510.v:14$2
assign $0\reg5[3:0] { \wire4 [2] \wire4 }
sync posedge $delete_wire$14
update \reg5 $0\reg5[3:0]
end
connect \y [4:0] { \reg5 1'0 }
connect \wire4 $xnor$3510.v:13$1_Y [2:0]
end
EOF
prep
splitcells