From 818aad7542154962e1168ab3ef1e584c30dab519 Mon Sep 17 00:00:00 2001 From: "Emil J. Tywoniak" Date: Thu, 26 Feb 2026 01:41:22 +0100 Subject: [PATCH] opt_clean: resolve TODOs --- passes/opt/opt_clean/cells_all.cc | 4 ---- passes/opt/opt_clean/wires.cc | 11 +++++------ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/passes/opt/opt_clean/cells_all.cc b/passes/opt/opt_clean/cells_all.cc index b4d40f506..aa97851e3 100644 --- a/passes/opt/opt_clean/cells_all.cc +++ b/passes/opt/opt_clean/cells_all.cc @@ -112,7 +112,6 @@ struct WireDriversCollisionHandler { }; using Wire2Drivers = ShardedHashtable; -// TODO difference from DeferredLogs ? struct ConflictLogs { ShardedVector> logs; ConflictLogs(ParallelDispatchThreadPool::Subpool &subpool) : logs(subpool) {} @@ -177,9 +176,6 @@ struct CellAnalysis { } }; - - -// TODO name ConflictLogs explore(CellAnalysis& analysis, CellTraversal& traversal, const SigMap& wire_map, AnalysisContext& actx, CleanRunContext &clean_ctx) { ConflictLogs logs(actx.subpool); Wire2Drivers::Builder wire2driver_builder(actx.subpool); diff --git a/passes/opt/opt_clean/wires.cc b/passes/opt/opt_clean/wires.cc index 55836457b..c8bcf5209 100644 --- a/passes/opt/opt_clean/wires.cc +++ b/passes/opt/opt_clean/wires.cc @@ -322,14 +322,13 @@ struct DeferredUpdates { DeferredUpdates(ParallelDispatchThreadPool::Subpool &subpool) : update_connections(subpool), initialized_wires(subpool) {} }; struct UsedSignals { - // here, "used" means "driven or driving something" - // meanwhile, "unused" means "driving nothing" - // TODO ... - // used signals sigmapped + // here, "connected" means "driven or driving something" + // meanwhile, "used" means "driving something" + // sigmapped ShardedSigPool connected; - // used signals pre-sigmapped + // pre-sigmapped ShardedSigPool raw_connected; - // used signals sigmapped, ignoring drivers (we keep track of this to set `unused_bits`) + // sigmapped ShardedSigPool used; void clear(ParallelDispatchThreadPool::Subpool &subpool) {