mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-11-04 05:19:11 +00:00
Code Activity

Out of bounds checking for struct/union members

Browse source 
Currently, only constant indices are checked.
This commit is contained in:
Dag Lem 2023-02-19 23:25:08 +01:00
parent f0116330bc
commit 79043cb849
3 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
frontends/ast/genrtlil.cc
View file

@ -1444,6 +1444,19 @@ RTLIL::SigSpec AstNode::genRTLIL(int width_hint, bool sign_hint)
log_file_error(filename, location.first_line, "Single range expected.\n"); log_file_error(filename, location.first_line, "Single range expected.\n");
int source_width = id2ast->range_left - id2ast->range_right + 1; int source_width = id2ast->range_left - id2ast->range_right + 1;
int source_offset = id2ast->range_right; int source_offset = id2ast->range_right;
int item_left = source_width - 1;
int item_right = 0;
// Check for item in struct/union.
AST::AstNode *item_node;
if (attributes.count(ID::wiretype) && (item_node = attributes[ID::wiretype]) &&
(item_node->type == AST_STRUCT_ITEM || item_node->type == AST_STRUCT || item_node->type == AST_UNION))
{
// Clamp chunk to range of item within struct/union.
item_left = item_node->range_left;
item_right = item_node->range_right;
}
if (!children[0]->range_valid) { if (!children[0]->range_valid) {
AstNode *left_at_zero_ast = children[0]->children[0]->clone(); AstNode *left_at_zero_ast = children[0]->children[0]->clone();
AstNode *right_at_zero_ast = children[0]->children.size() >= 2 ? children[0]->children[1]->clone() : left_at_zero_ast->clone(); AstNode *right_at_zero_ast = children[0]->children.size() >= 2 ? children[0]->children[1]->clone() : left_at_zero_ast->clone();
@ -1481,7 +1494,7 @@ RTLIL::SigSpec AstNode::genRTLIL(int width_hint, bool sign_hint)
chunk.offset = children[0]->range_right - source_offset; chunk.offset = children[0]->range_right - source_offset;
if (id2ast->range_swapped) if (id2ast->range_swapped)
chunk.offset = (id2ast->range_left - id2ast->range_right + 1) - (chunk.offset + chunk.width); chunk.offset = (id2ast->range_left - id2ast->range_right + 1) - (chunk.offset + chunk.width);
if (chunk.offset >= source_width || chunk.offset + chunk.width < 0) { if (chunk.offset > item_left || chunk.offset + chunk.width < item_right) {
if (chunk.width == 1) if (chunk.width == 1)
log_file_warning(filename, location.first_line, "Range select out of bounds on signal `%s': Setting result bit to undef.\n", log_file_warning(filename, location.first_line, "Range select out of bounds on signal `%s': Setting result bit to undef.\n",
str.c_str()); str.c_str());
@ -1490,12 +1503,12 @@ RTLIL::SigSpec AstNode::genRTLIL(int width_hint, bool sign_hint)
children[0]->range_left, children[0]->range_right, str.c_str(), chunk.width); children[0]->range_left, children[0]->range_right, str.c_str(), chunk.width);
chunk = RTLIL::SigChunk(RTLIL::State::Sx, chunk.width); chunk = RTLIL::SigChunk(RTLIL::State::Sx, chunk.width);
} else { } else {
if (chunk.width + chunk.offset > source_width) { if (chunk.offset + chunk.width - 1 > item_left) {
add_undef_bits_msb = (chunk.width + chunk.offset) - source_width; add_undef_bits_msb = (chunk.offset + chunk.width - 1) - item_left;
chunk.width -= add_undef_bits_msb; chunk.width -= add_undef_bits_msb;
} }
if (chunk.offset < 0) { if (chunk.offset < item_right) {
add_undef_bits_lsb = -chunk.offset; add_undef_bits_lsb = item_right - chunk.offset;
chunk.width -= add_undef_bits_lsb; chunk.width -= add_undef_bits_lsb;
chunk.offset += add_undef_bits_lsb; chunk.offset += add_undef_bits_lsb;
} }

2
tests/gen-tests-makefile.sh
View file

@ -75,7 +75,7 @@ generate_tests() {
if [[ $do_sv = true ]]; then if [[ $do_sv = true ]]; then
for x in *.sv; do for x in *.sv; do
if [ ! -f "${x%.sv}.ys" ]; then if [ ! -f "${x%.sv}.ys" ]; then
generate_ys_test "$x" "-p \"prep -top top; sat -verify -prove-asserts\" $yosys_args" generate_ys_test "$x" "-p \"prep -top top; sat -enable_undef -verify -prove-asserts\" $yosys_args"
fi; fi;
done done
fi; fi;

3
tests/svtypes/struct_array.sv
View file

@ -18,6 +18,9 @@ module top;
end end
always_comb assert(s==64'h4200_0012_3400_FFFC); always_comb assert(s==64'h4200_0012_3400_FFFC);
always_comb assert(s.b[23:16]===8'hxx);
always_comb assert(s.b[19:12]===8'hxf);
always_comb assert(s.a[0][3:-4]===8'h0x);
struct packed { struct packed {
bit [7:0] [7:0] a; // 8 element packed array of bytes bit [7:0] [7:0] a; // 8 element packed array of bytes