mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-04-13 04:28:18 +00:00
Code Activity

Retry on fixing TODOs

Browse source
This commit is contained in:
Eddie Hung 2019-10-04 13:38:09 -07:00
parent 52583ecff8
commit 77d7a5c14a
2 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
passes/pmgen/xilinx_dsp.pmg
View file

@ -100,14 +100,10 @@ code sigA sigB sigC sigD sigM clock
sigM.append(P[i]); sigM.append(P[i]);
} }
log_assert(nusers(P.extract_end(i)) <= 1); log_assert(nusers(P.extract_end(i)) <= 1);
log_assert(!sigM.empty());
} }
else else
sigM = P; sigM = P;
// TODO: Check if necessary
// This sigM could have no users if downstream $add
// is narrower than $mul result, for example
if (sigM.empty())
reject;
clock = port(dsp, \CLK, SigBit()); clock = port(dsp, \CLK, SigBit());
endcode endcode
@ -160,12 +156,9 @@ match preAdd
endmatch endmatch
code sigA sigD code sigA sigD
// TODO: Check if this is necessary?
if (preAdd) { if (preAdd) {
sigA = port(preAdd, \A); sigA = port(preAdd, \A);
sigD = port(preAdd, \B); sigD = port(preAdd, \B);
if (GetSize(sigA) < GetSize(sigD))
std::swap(sigA, sigD);
} }
endcode endcode

5
passes/pmgen/xilinx_dsp_CREG.pmg
View file

@ -79,11 +79,6 @@ endcode
// (attached to at most two $mux cells that implement clock-enable or // (attached to at most two $mux cells that implement clock-enable or
// reset functionality, using the in_dffe subpattern) // reset functionality, using the in_dffe subpattern)
code argQ ffC ffCcemux ffCrstmux ffCcepol ffCrstpol sigC clock code argQ ffC ffCcemux ffCrstmux ffCcepol ffCrstpol sigC clock
// TODO: Any downside to allowing this?
// If this DSP implements an accumulator, do not attempt to match
if (sigC == sigP)
reject;
argQ = sigC; argQ = sigC;
subpattern(in_dffe); subpattern(in_dffe);
if (dff) { if (dff) {