mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-06-21 13:23:40 +00:00
Code Activity

sim: Evaluate all cells once

Browse source 
If a cell starts with undefined inputs and the value of those inputs is
never changed, `sim` code will never evaluate that cell. This means its
output will be left at undefined, but in some edge cases such cell can
evaluate to a defined value. To address those cases evaluate all cells
at least once.
This commit is contained in:
Martin Povišer 2023-11-24 16:16:33 +01:00
parent c95298225d
commit 6b5fbe37f0
1 changed files with 13 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

20
passes/sat/sim.cc
View file

@ -287,16 +287,18 @@ struct SimInstance
if (mod != nullptr) { if (mod != nullptr) {
dirty_children.insert(new SimInstance(shared, scope + "." + RTLIL::unescape_id(cell->name), mod, cell, this)); dirty_children.insert(new SimInstance(shared, scope + "." + RTLIL::unescape_id(cell->name), mod, cell, this));
} } else {
for (auto &port : cell->connections())
for (auto &port : cell->connections()) {
if (cell->input(port.first)) if (cell->input(port.first))
for (auto bit : sigmap(port.second)) { for (auto bit : sigmap(port.second))
upd_cells[bit].insert(cell); upd_cells[bit].insert(cell);
// Make sure cell inputs connected to constants are updated in the first cycle
if (bit.wire == nullptr) // Update all cells in the first cycle (to propagate constants but also to
dirty_bits.insert(bit); // handle edge cases in which cells have defined output values in presence of
} // undefined inputs). This is with the exception of few cells which don't have
// any inputs and should never be queued up for updating.
if (!cell->type.in(ID($initstate), ID($anyconst), ID($anyseq), ID($allconst), ID($allseq)))
dirty_cells.insert(cell);
} }
if (RTLIL::builtin_ff_cell_types().count(cell->type) || cell->type == ID($anyinit)) { if (RTLIL::builtin_ff_cell_types().count(cell->type) || cell->type == ID($anyinit)) {
@ -492,6 +494,8 @@ struct SimInstance
void update_cell(Cell *cell) void update_cell(Cell *cell)
{ {
log_assert(!cell->type.in(ID($initstate), ID($anyconst), ID($anyseq), ID($allconst), ID($allseq)));
if (ff_database.count(cell)) if (ff_database.count(cell))
return; return;