mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-04-13 04:28:18 +00:00
Code Activity

Minor changes to opt_demorgan requested during code review

Browse source
This commit is contained in:
Andrew Zonenberg 2017-09-14 10:34:45 -07:00
parent 6da5d36968
commit 66e8986ae7
2 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
passes/opt/Makefile.inc
View file

@ -6,11 +6,11 @@ OBJS += passes/opt/opt_reduce.o
OBJS += passes/opt/opt_rmdff.o OBJS += passes/opt/opt_rmdff.o
OBJS += passes/opt/opt_clean.o OBJS += passes/opt/opt_clean.o
OBJS += passes/opt/opt_expr.o OBJS += passes/opt/opt_expr.o
OBJS += passes/opt/opt_demorgan.o
OBJS += passes/opt/rmports.o
ifneq ($(SMALL),1) ifneq ($(SMALL),1)
OBJS += passes/opt/share.o OBJS += passes/opt/share.o
OBJS += passes/opt/wreduce.o OBJS += passes/opt/wreduce.o
OBJS += passes/opt/opt_demorgan.o
OBJS += passes/opt/rmports.o
endif endif

32
passes/opt/opt_demorgan.cc
View file

@ -39,9 +39,9 @@ void demorgan_worker(
return; return;
auto insig = sigmap(cell->getPort("\\A")); auto insig = sigmap(cell->getPort("\\A"));
log("Inspecting %s cell %s (%d inputs)\n", log_id(cell->type), log_id(cell->name), insig.size()); log("Inspecting %s cell %s (%d inputs)\n", log_id(cell->type), log_id(cell->name), GetSize(insig));
int num_inverted = 0; int num_inverted = 0;
for(int i=0; i<insig.size(); i++) for(int i=0; i<GetSize(insig); i++)
{ {
auto b = insig[i]; auto b = insig[i];
@ -63,19 +63,19 @@ void demorgan_worker(
} }
//Stop if less than half of the inputs are inverted //Stop if less than half of the inputs are inverted
if(num_inverted*2 < insig.size()) if(num_inverted*2 < GetSize(insig))
{ {
log(" %d / %d inputs are inverted, not pushing\n", num_inverted, insig.size()); log(" %d / %d inputs are inverted, not pushing\n", num_inverted, GetSize(insig));
return; return;
} }
//More than half of the inputs are inverted! Push through //More than half of the inputs are inverted! Push through
cells_changed ++; cells_changed ++;
log(" %d / %d inputs are inverted, pushing inverter through reduction\n", num_inverted, insig.size()); log(" %d / %d inputs are inverted, pushing inverter through reduction\n", num_inverted, GetSize(insig));
//For each input, either add or remove the inverter as needed //For each input, either add or remove the inverter as needed
//TODO: this duplicates the loop up above, can we refactor it? //TODO: this duplicates the loop up above, can we refactor it?
for(int i=0; i<insig.size(); i++) for(int i=0; i<GetSize(insig); i++)
{ {
auto b = insig[i]; auto b = insig[i];
@ -110,10 +110,10 @@ void demorgan_worker(
//Reductions are all commutative, so there's no point in having them in a weird order //Reductions are all commutative, so there's no point in having them in a weird order
bool same_signal = true; bool same_signal = true;
RTLIL::Wire* srcwire = insig[0].wire; RTLIL::Wire* srcwire = insig[0].wire;
std::map<int, int> seen_bits; dict<int, int> seen_bits;
for(int i=0; i<insig.size(); i++) for(int i=0; i<GetSize(insig); i++)
seen_bits[i] = 0; seen_bits[i] = 0;
for(int i=0; i<insig.size(); i++) for(int i=0; i<GetSize(insig); i++)
{ {
seen_bits[insig[i].offset] ++; seen_bits[insig[i].offset] ++;
if(insig[i].wire != srcwire) if(insig[i].wire != srcwire)
@ -126,7 +126,7 @@ void demorgan_worker(
{ {
//Make sure we've seen every bit exactly once //Make sure we've seen every bit exactly once
bool every_bit_once = true; bool every_bit_once = true;
for(int i=0; i<insig.size(); i++) for(int i=0; i<GetSize(insig); i++)
{ {
if(seen_bits[i] != 1) if(seen_bits[i] != 1)
{ {
@ -139,12 +139,12 @@ void demorgan_worker(
//We do have to swap MSB to LSB b/c that's the way the reduction cells seem to work? //We do have to swap MSB to LSB b/c that's the way the reduction cells seem to work?
//Unclear on why this isn't sorting properly //Unclear on why this isn't sorting properly
//TODO: can we do SigChunks instead of single bits if we have subsets of a bus? //TODO: can we do SigChunks instead of single bits if we have subsets of a bus?
if(every_bit_once && (insig.size() == srcwire->width) ) if(every_bit_once && (GetSize(insig) == srcwire->width) )
{ {
log("Rearranging bits\n"); log("Rearranging bits\n");
RTLIL::SigSpec newsig; RTLIL::SigSpec newsig;
for(int i=0; i<insig.size(); i++) for(int i=0; i<GetSize(insig); i++)
newsig.append(RTLIL::SigBit(srcwire, insig.size() - i - 1)); newsig.append(RTLIL::SigBit(srcwire, GetSize(insig) - i - 1));
insig = newsig; insig = newsig;
insig.sort(); insig.sort();
} }
@ -179,12 +179,12 @@ struct OptDemorganPass : public Pass {
log("overall gate count of the circuit\n"); log("overall gate count of the circuit\n");
log("\n"); log("\n");
} }
virtual void execute(std::vector<std::string> /*args*/, RTLIL::Design *design) virtual void execute(std::vector<std::string> args, RTLIL::Design *design)
{ {
log_header(design, "Executing OPT_DEMORGAN pass (push inverters through $reduce_* cells).\n"); log_header(design, "Executing OPT_DEMORGAN pass (push inverters through $reduce_* cells).\n");
//int argidx = 0; int argidx = 0;
//extra_args(args, argidx, design); extra_args(args, argidx, design);
unsigned int cells_changed = 0; unsigned int cells_changed = 0;
for (auto module : design->selected_modules()) for (auto module : design->selected_modules())