mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-06-07 06:33:24 +00:00
Code Activity

cxxrtl: don't use signed divide with unsigned/pos values

Browse source 
Incorrect for unsigned, wasted effort for positive signed.
This commit is contained in:
Charlotte 2023-06-28 11:51:19 +10:00 • committed by Marcelina Kościelnicka
parent b0f69f2cd5
commit 52dc397a50
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
backends/cxxrtl/cxxrtl.h
View file

@ -904,10 +904,12 @@ std::ostream &operator<<(std::ostream &os, const value_formatted<Bits> &vf)
val = val.neg(); val = val.neg();
if (val.is_zero()) if (val.is_zero())
buf += '0'; buf += '0';
// TODO: rigorously check our signed behaviour here
while (!val.is_zero()) { while (!val.is_zero()) {
value<Bits> quotient; value<Bits> quotient;
val.signedDivideWithRemainder(value<Bits>{10u}, quotient); if (negative)
val.signedDivideWithRemainder(value<Bits>{10u}, quotient);
else
val.divideWithRemainder(value<Bits>{10u}, quotient);
buf += '0' + val.template slice<3, 0>().val().template get<uint8_t>(); buf += '0' + val.template slice<3, 0>().val().template get<uint8_t>();
val = quotient; val = quotient;
} }