3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-04-23 00:55:32 +00:00

Add support for parsing the SystemVerilog 'bind' construct

This doesn't do anything useful yet: the patch just adds support for
the syntax to the lexer and parser and adds some tests to check the
syntax parses properly. This generates AST nodes, but doesn't yet
generate RTLIL.

Since our existing hierarchical_identifier parser doesn't allow bit
selects (so you can't do something like foo[1].bar[2].baz), I've also
not added support for a trailing bit select (the "constant_bit_select"
non-terminal in "bind_target_instance" in the spec). If we turn out to
need this in future, we'll want to augment hierarchical_identifier and
its other users too.

Note that you can't easily use the BNF from the spec:

    bind_directive ::=
        "bind" bind_target_scope [ : bind_target_instance_list]
               bind_instantiation ;
      | "bind" bind_target_instance bind_instantiation ;

even if you fix the lookahead problem, because code like this matches
both branches in the BNF:

    bind a b b_i (.*);

The problem is that 'a' could either be a module name or a degenerate
hierarchical reference. This seems to be a genuine syntactic
ambiguity, which the spec resolves (p739) by saying that we have to
wait until resolution time (the hierarchy pass) and take whatever is
defined, treating 'a' as an instance name if it names both an instance
and a module.

To keep the parser simple, it currently accepts this invalid syntax:

    bind a.b : c d e (.*);

This is invalid because we're in the first branch of the BNF above, so
the "a.b" term should match bind_target_scope: a module or interface
identifier, not an arbitrary hierarchical identifier.

This will fail in the hierarchy pass (when it's implemented in a
future patch).
This commit is contained in:
Rupert Swarbrick 2020-05-21 17:36:29 +01:00 committed by Zachary Snow
parent 2db4137514
commit 414154dd27
19 changed files with 247 additions and 4 deletions

2
tests/bind/.gitignore vendored Normal file
View file

@ -0,0 +1,2 @@
*.log
run-test.mk

20
tests/bind/basic.sv Normal file
View file

@ -0,0 +1,20 @@
// A basic example of the bind construct
module foo (input logic a, input logic b, output logic c);
// Magic happens here...
endmodule
module bar (input a, input b, output c);
assign c = a ^ b;
endmodule
module top ();
logic u, v, w;
foo foo_i (.a (u), .b (v), .c (w));
bind foo bar bound_i (.*);
always_comb begin
assert(w == u ^ v);
end
endmodule

1
tests/bind/basic.ys Normal file
View file

@ -0,0 +1 @@
read_verilog -sv basic.sv

26
tests/bind/cell_list.sv Normal file
View file

@ -0,0 +1,26 @@
// An example of specifying multiple bind instances in a single directive. This
// also uses explicit bound names.
module foo (input logic a0, input logic b0, output logic c0,
input logic a1, input logic b1, output logic c1);
// Magic happens here...
endmodule
module bar (input a, input b, output c);
assign c = a ^ b;
endmodule
module top ();
logic u0, v0, w0;
logic u1, v1, w1;
foo foo0 (.a0 (u0), .b0 (v0), .c0 (w0),
.a1 (u1), .b1 (v1), .c1 (w1));
bind foo bar bar0 (.a(a0), .b(b0), .c(c0)), bar1 (.a(a1), .b(b1), .c(c1));
always_comb begin
assert(w0 == u0 ^ v0);
assert(w1 == u1 ^ v1);
end
endmodule

1
tests/bind/cell_list.ys Normal file
View file

@ -0,0 +1 @@
read_verilog -sv cell_list.sv

20
tests/bind/hier.sv Normal file
View file

@ -0,0 +1,20 @@
// An example of the bind construct using a hierarchical reference starting with $root
module foo (input logic a, input logic b, output logic c);
// Magic happens here...
endmodule
module bar (input a, input b, output c);
assign c = a ^ b;
endmodule
module top ();
logic u, v, w;
foo foo_i (.a (u), .b (v), .c (w));
always_comb begin
assert(w == u ^ v);
end
endmodule
bind $root.top.foo_i bar bound_i (.*);

1
tests/bind/hier.ys Normal file
View file

@ -0,0 +1 @@
read_verilog -sv hier.sv

24
tests/bind/inst_list.sv Normal file
View file

@ -0,0 +1,24 @@
// An example of specifying multiple bind targets with an instance list
module foo (input logic a, input logic b, output logic c);
// Magic happens here...
endmodule
module bar (input a, input b, output c);
assign c = a ^ b;
endmodule
module top ();
logic u0, v0, w0;
logic u1, v1, w1;
foo foo0 (.a (u0), .b (v0), .c (w0));
foo foo1 (.a (u1), .b (v1), .c (w1));
bind foo : foo0, foo1 bar bound_i (.*);
always_comb begin
assert(w0 == u0 ^ v0);
assert(w1 == u1 ^ v1);
end
endmodule

1
tests/bind/inst_list.ys Normal file
View file

@ -0,0 +1 @@
read_verilog -sv inst_list.sv

26
tests/bind/param.sv Normal file
View file

@ -0,0 +1,26 @@
// An example showing how parameters get inferred when binding
module foo (input logic a, input logic b, output logic c);
parameter doit = 1;
// Magic happens here...
endmodule
module bar (input a, input b, output c);
parameter doit = 1;
assign c = doit ? a ^ b : 0;
endmodule
module top (input u0, input v0, output w0,
input u1, input v1, output w1);
foo #(.doit (0)) foo0 (.a (u0), .b (v0), .c (w0));
foo #(.doit (1)) foo1 (.a (u1), .b (v1), .c (w1));
bind foo bar #(.doit (doit)) bound_i (.*);
always_comb begin
assert (w0 == '0);
assert (w1 == u1 ^ v1);
end
endmodule

1
tests/bind/param.ys Normal file
View file

@ -0,0 +1 @@
read_verilog -sv param.sv

20
tests/bind/run-test.sh Executable file
View file

@ -0,0 +1,20 @@
#!/usr/bin/env bash
set -e
{
echo "all::"
for x in *.ys; do
echo "all:: run-$x"
echo "run-$x:"
echo " @echo 'Running $x..'"
echo " @../../yosys -ql ${x%.ys}.log $x"
done
for s in *.sh; do
if [ "$s" != "run-test.sh" ]; then
echo "all:: run-$s"
echo "run-$s:"
echo " @echo 'Running $s..'"
echo " @bash $s"
fi
done
} > run-test.mk
exec ${MAKE:-make} -f run-test.mk

20
tests/bind/toplevel.sv Normal file
View file

@ -0,0 +1,20 @@
// The bind construct occurring at top-level in the script
module foo (input logic a, input logic b, output logic c);
// Magic happens here...
endmodule
module bar (input a, input b, output c);
assign c = a ^ b;
endmodule
module top ();
logic u, v, w;
foo foo_i (.a (u), .b (v), .c (w));
always_comb begin
assert(w == u ^ v);
end
endmodule
bind top.foo_i bar bound_i (.*);

1
tests/bind/toplevel.ys Normal file
View file

@ -0,0 +1 @@
read_verilog -sv toplevel.sv