mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-06-13 01:16:16 +00:00
Code Activity

Merge pull request #5148 from georgerennie/george/convertible_to_int_fix

Browse source 
Fix convertible_to_int handling of 32 bit unsigned ints with MSB set.
This commit is contained in:
George Rennie 2025-05-29 10:33:12 +01:00 • committed by GitHub
commit 3ef4c91c31
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 65 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

31
kernel/rtlil.cc
View file

@ -383,7 +383,23 @@ int RTLIL::Const::as_int(bool is_signed) const
bool RTLIL::Const::convertible_to_int(bool is_signed) const
{
auto size = get_min_size(is_signed);
return (size > 0 && size <= 32);
if (size <= 0)
return false;
// If it fits in 31 bits it is definitely convertible
if (size <= 31)
return true;
// If it fits in 32 bits, it is convertible if signed or if unsigned and the
// leading bit is not 1
if (size == 32) {
if (is_signed)
return true;
return get_bits().at(31) != State::S1;
}
return false;
}
std::optional<int> RTLIL::Const::try_as_int(bool is_signed) const
@ -439,18 +455,7 @@ void RTLIL::Const::compress(bool is_signed)
std::optional<int> RTLIL::Const::as_int_compress(bool is_signed) const
{
auto size = get_min_size(is_signed);
if(size == 0 || size > 32)
return std::nullopt;
int32_t ret = 0;
for (auto i = 0; i < size && i < 32; i++)
if ((*this)[i] == State::S1)
ret |= 1 << i;
if (is_signed && (*this)[size-1] == State::S1)
for (auto i = size; i < 32; i++)
ret |= 1 << i;
return ret;
return try_as_int(is_signed);
}
std::string RTLIL::Const::as_string(const char* any) const