mirror of
				https://github.com/YosysHQ/yosys
				synced 2025-10-31 03:32:29 +00:00 
			
		
		
		
	Consistent use of 'override' for virtual methods in derived classes.
o Not all derived methods were marked 'override', but it is a great feature of C++11 that we should make use of. o While at it: touched header files got a -*- c++ -*- for emacs to provide support for that language. o use YS_OVERRIDE for all override keywords (though we should probably use the plain keyword going forward now that C++11 is established)
This commit is contained in:
		
							parent
							
								
									323f6f6f60
								
							
						
					
					
						commit
						3aa4484a3c
					
				
					 170 changed files with 414 additions and 416 deletions
				
			
		|  | @ -1,4 +1,4 @@ | |||
| /*
 | ||||
| /* -*- c++ -*-
 | ||||
|  *  yosys -- Yosys Open SYnthesis Suite | ||||
|  * | ||||
|  *  Copyright (C) 2012  Clifford Wolf <clifford@clifford.at> | ||||
|  | @ -38,7 +38,7 @@ struct FwdCellEdgesDatabase : AbstractCellEdgesDatabase | |||
| 	dict<SigBit, pool<SigBit>> db; | ||||
| 	FwdCellEdgesDatabase(SigMap &sigmap) : sigmap(sigmap) { } | ||||
| 
 | ||||
| 	virtual void add_edge(RTLIL::Cell *cell, RTLIL::IdString from_port, int from_bit, RTLIL::IdString to_port, int to_bit, int) override { | ||||
| 	void add_edge(RTLIL::Cell *cell, RTLIL::IdString from_port, int from_bit, RTLIL::IdString to_port, int to_bit, int) YS_OVERRIDE { | ||||
| 		SigBit from_sigbit = sigmap(cell->getPort(from_port)[from_bit]); | ||||
| 		SigBit to_sigbit = sigmap(cell->getPort(to_port)[to_bit]); | ||||
| 		db[from_sigbit].insert(to_sigbit); | ||||
|  | @ -51,7 +51,7 @@ struct RevCellEdgesDatabase : AbstractCellEdgesDatabase | |||
| 	dict<SigBit, pool<SigBit>> db; | ||||
| 	RevCellEdgesDatabase(SigMap &sigmap) : sigmap(sigmap) { } | ||||
| 
 | ||||
| 	virtual void add_edge(RTLIL::Cell *cell, RTLIL::IdString from_port, int from_bit, RTLIL::IdString to_port, int to_bit, int) override { | ||||
| 	void add_edge(RTLIL::Cell *cell, RTLIL::IdString from_port, int from_bit, RTLIL::IdString to_port, int to_bit, int) YS_OVERRIDE { | ||||
| 		SigBit from_sigbit = sigmap(cell->getPort(from_port)[from_bit]); | ||||
| 		SigBit to_sigbit = sigmap(cell->getPort(to_port)[to_bit]); | ||||
| 		db[to_sigbit].insert(from_sigbit); | ||||
|  |  | |||
|  | @ -1,4 +1,4 @@ | |||
| /*
 | ||||
| /* -*- c++ -*-
 | ||||
|  *  yosys -- Yosys Open SYnthesis Suite | ||||
|  * | ||||
|  *  Copyright (C) 2012  Clifford Wolf <clifford@clifford.at> | ||||
|  | @ -158,7 +158,7 @@ struct ModIndex : public RTLIL::Monitor | |||
| #endif | ||||
| 	} | ||||
| 
 | ||||
| 	virtual void notify_connect(RTLIL::Cell *cell, const RTLIL::IdString &port, const RTLIL::SigSpec &old_sig, RTLIL::SigSpec &sig) YS_OVERRIDE | ||||
| 	void notify_connect(RTLIL::Cell *cell, const RTLIL::IdString &port, const RTLIL::SigSpec &old_sig, RTLIL::SigSpec &sig) YS_OVERRIDE | ||||
| 	{ | ||||
| 		log_assert(module == cell->module); | ||||
| 
 | ||||
|  | @ -169,7 +169,7 @@ struct ModIndex : public RTLIL::Monitor | |||
| 		port_add(cell, port, sig); | ||||
| 	} | ||||
| 
 | ||||
| 	virtual void notify_connect(RTLIL::Module *mod YS_ATTRIBUTE(unused), const RTLIL::SigSig &sigsig) YS_OVERRIDE | ||||
| 	void notify_connect(RTLIL::Module *mod YS_ATTRIBUTE(unused), const RTLIL::SigSig &sigsig) YS_OVERRIDE | ||||
| 	{ | ||||
| 		log_assert(module == mod); | ||||
| 
 | ||||
|  | @ -214,13 +214,13 @@ struct ModIndex : public RTLIL::Monitor | |||
| 		} | ||||
| 	} | ||||
| 
 | ||||
| 	virtual void notify_connect(RTLIL::Module *mod YS_ATTRIBUTE(unused), const std::vector<RTLIL::SigSig>&) YS_OVERRIDE | ||||
| 	void notify_connect(RTLIL::Module *mod YS_ATTRIBUTE(unused), const std::vector<RTLIL::SigSig>&) YS_OVERRIDE | ||||
| 	{ | ||||
| 		log_assert(module == mod); | ||||
| 		auto_reload_module = true; | ||||
| 	} | ||||
| 
 | ||||
| 	virtual void notify_blackout(RTLIL::Module *mod YS_ATTRIBUTE(unused)) YS_OVERRIDE | ||||
| 	void notify_blackout(RTLIL::Module *mod YS_ATTRIBUTE(unused)) YS_OVERRIDE | ||||
| 	{ | ||||
| 		log_assert(module == mod); | ||||
| 		auto_reload_module = true; | ||||
|  |  | |||
|  | @ -615,7 +615,7 @@ static struct CellHelpMessages { | |||
| 
 | ||||
| struct HelpPass : public Pass { | ||||
| 	HelpPass() : Pass("help", "display help messages") { } | ||||
| 	virtual void help() | ||||
| 	void help() YS_OVERRIDE | ||||
| 	{ | ||||
| 		log("\n"); | ||||
| 		log("    help  ................  list all commands\n"); | ||||
|  | @ -684,7 +684,7 @@ struct HelpPass : public Pass { | |||
| 
 | ||||
| 		fclose(f); | ||||
| 	} | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design*) | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design*) YS_OVERRIDE | ||||
| 	{ | ||||
| 		if (args.size() == 1) { | ||||
| 			log("\n"); | ||||
|  | @ -768,7 +768,7 @@ struct HelpPass : public Pass { | |||
| 
 | ||||
| struct EchoPass : public Pass { | ||||
| 	EchoPass() : Pass("echo", "turning echoing back of commands on and off") { } | ||||
| 	virtual void help() | ||||
| 	void help() YS_OVERRIDE | ||||
| 	{ | ||||
| 		log("\n"); | ||||
| 		log("    echo on\n"); | ||||
|  | @ -781,7 +781,7 @@ struct EchoPass : public Pass { | |||
| 		log("Do not print all commands to log before executing them. (default)\n"); | ||||
| 		log("\n"); | ||||
| 	} | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design*) | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design*) YS_OVERRIDE | ||||
| 	{ | ||||
| 		if (args.size() > 2) | ||||
| 			cmd_error(args, 2, "Unexpected argument."); | ||||
|  | @ -806,10 +806,9 @@ struct MinisatSatSolver : public SatSolver { | |||
| 	MinisatSatSolver() : SatSolver("minisat") { | ||||
| 		yosys_satsolver = this; | ||||
| 	} | ||||
| 	virtual ezSAT *create() YS_OVERRIDE { | ||||
| 	ezSAT *create() YS_OVERRIDE { | ||||
| 		return new ezMiniSAT(); | ||||
| 	} | ||||
| } MinisatSatSolver; | ||||
| 
 | ||||
| YOSYS_NAMESPACE_END | ||||
| 
 | ||||
|  |  | |||
|  | @ -1,4 +1,4 @@ | |||
| /*
 | ||||
| /* -*- c++ -*-
 | ||||
|  *  yosys -- Yosys Open SYnthesis Suite | ||||
|  * | ||||
|  *  Copyright (C) 2012  Clifford Wolf <clifford@clifford.at> | ||||
|  | @ -88,9 +88,9 @@ struct Frontend : Pass | |||
| 
 | ||||
| 	std::string frontend_name; | ||||
| 	Frontend(std::string name, std::string short_help = "** document me **"); | ||||
| 	virtual void run_register() YS_OVERRIDE; | ||||
| 	virtual ~Frontend(); | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE YS_FINAL; | ||||
| 	void run_register() YS_OVERRIDE; | ||||
| 	~Frontend() YS_OVERRIDE; | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE YS_FINAL; | ||||
| 	virtual void execute(std::istream *&f, std::string filename, std::vector<std::string> args, RTLIL::Design *design) = 0; | ||||
| 
 | ||||
| 	static std::vector<std::string> next_args; | ||||
|  | @ -104,9 +104,9 @@ struct Backend : Pass | |||
| { | ||||
| 	std::string backend_name; | ||||
| 	Backend(std::string name, std::string short_help = "** document me **"); | ||||
| 	virtual void run_register() YS_OVERRIDE; | ||||
| 	virtual ~Backend(); | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE YS_FINAL; | ||||
| 	void run_register() YS_OVERRIDE; | ||||
| 	~Backend() YS_OVERRIDE; | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE YS_FINAL; | ||||
| 	virtual void execute(std::ostream *&f, std::string filename,  std::vector<std::string> args, RTLIL::Design *design) = 0; | ||||
| 
 | ||||
| 	void extra_args(std::ostream *&f, std::string &filename, std::vector<std::string> args, size_t argidx); | ||||
|  |  | |||
|  | @ -1,4 +1,4 @@ | |||
| /*
 | ||||
| /* -*- c++ -*-
 | ||||
|  *  yosys -- Yosys Open SYnthesis Suite | ||||
|  * | ||||
|  *  Copyright (C) 2012  Clifford Wolf <clifford@clifford.at> | ||||
|  |  | |||
|  | @ -1,4 +1,4 @@ | |||
| /*
 | ||||
| /* -*- c++ -*-
 | ||||
|  *  yosys -- Yosys Open SYnthesis Suite | ||||
|  * | ||||
|  *  Copyright (C) 2012  Clifford Wolf <clifford@clifford.at> | ||||
|  |  | |||
|  | @ -636,7 +636,7 @@ extern Tcl_Interp *yosys_get_tcl_interp() | |||
| 
 | ||||
| struct TclPass : public Pass { | ||||
| 	TclPass() : Pass("tcl", "execute a TCL script file") { } | ||||
| 	virtual void help() { | ||||
| 	void help() YS_OVERRIDE { | ||||
| 		log("\n"); | ||||
| 		log("    tcl <filename>\n"); | ||||
| 		log("\n"); | ||||
|  | @ -649,7 +649,7 @@ struct TclPass : public Pass { | |||
| 		log("in order to avoid a name collision with the built in commands.\n"); | ||||
| 		log("\n"); | ||||
| 	} | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design *design) { | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE { | ||||
| 		if (args.size() < 2) | ||||
| 			log_cmd_error("Missing script file.\n"); | ||||
| 		if (args.size() > 2) | ||||
|  | @ -1111,7 +1111,7 @@ void shell(RTLIL::Design *design) | |||
| 
 | ||||
| struct ShellPass : public Pass { | ||||
| 	ShellPass() : Pass("shell", "enter interactive command mode") { } | ||||
| 	virtual void help() { | ||||
| 	void help() YS_OVERRIDE { | ||||
| 		log("\n"); | ||||
| 		log("    shell\n"); | ||||
| 		log("\n"); | ||||
|  | @ -1143,7 +1143,7 @@ struct ShellPass : public Pass { | |||
| 		log("Press Ctrl-D or type 'exit' to leave the interactive shell.\n"); | ||||
| 		log("\n"); | ||||
| 	} | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design *design) { | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE { | ||||
| 		extra_args(args, 1, design, false); | ||||
| 		shell(design); | ||||
| 	} | ||||
|  | @ -1152,7 +1152,7 @@ struct ShellPass : public Pass { | |||
| #if defined(YOSYS_ENABLE_READLINE) || defined(YOSYS_ENABLE_EDITLINE) | ||||
| struct HistoryPass : public Pass { | ||||
| 	HistoryPass() : Pass("history", "show last interactive commands") { } | ||||
| 	virtual void help() { | ||||
| 	void help() YS_OVERRIDE { | ||||
| 		log("\n"); | ||||
| 		log("    history\n"); | ||||
| 		log("\n"); | ||||
|  | @ -1161,7 +1161,7 @@ struct HistoryPass : public Pass { | |||
| 		log("from executed scripts.\n"); | ||||
| 		log("\n"); | ||||
| 	} | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design *design) { | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE { | ||||
| 		extra_args(args, 1, design, false); | ||||
| #ifdef YOSYS_ENABLE_READLINE | ||||
| 		for(HIST_ENTRY **list = history_list(); *list != NULL; list++) | ||||
|  | @ -1176,7 +1176,7 @@ struct HistoryPass : public Pass { | |||
| 
 | ||||
| struct ScriptCmdPass : public Pass { | ||||
| 	ScriptCmdPass() : Pass("script", "execute commands from script file") { } | ||||
| 	virtual void help() { | ||||
| 	void help() YS_OVERRIDE { | ||||
| 		log("\n"); | ||||
| 		log("    script <filename> [<from_label>:<to_label>]\n"); | ||||
| 		log("\n"); | ||||
|  | @ -1191,7 +1191,7 @@ struct ScriptCmdPass : public Pass { | |||
| 		log("marked with that label (until the next label) is executed.\n"); | ||||
| 		log("\n"); | ||||
| 	} | ||||
| 	virtual void execute(std::vector<std::string> args, RTLIL::Design *design) { | ||||
| 	void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE { | ||||
| 		if (args.size() < 2) | ||||
| 			log_cmd_error("Missing script file.\n"); | ||||
| 		else if (args.size() == 2) | ||||
|  |  | |||
|  | @ -1,4 +1,4 @@ | |||
| /*
 | ||||
| /* -*- c++ -*-
 | ||||
|  *  yosys -- Yosys Open SYnthesis Suite | ||||
|  * | ||||
|  *  Copyright (C) 2012  Clifford Wolf <clifford@clifford.at> | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue