mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-04-07 01:54:10 +00:00
Code Activity

peepopt: avoid shift-amount underflow

Browse source
This commit is contained in:
phsauter 2024-06-13 22:40:12 +02:00
parent 62bff3a204
commit 34b5c6d062
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
passes/pmgen/peepopt_shiftadd.pmg
View file

@ -66,7 +66,8 @@ match add
define <bool> offset_negative ((port(add, constport).bits().back() == State::S1) ^ (is_sub && varport_A)) define <bool> offset_negative ((port(add, constport).bits().back() == State::S1) ^ (is_sub && varport_A))
// checking some value boundaries as well: // checking some value boundaries as well:
// data[...-c +:W1] is fine for +/-var (pad at LSB, all data still accessible) // data[...-c +:W1] is fine for any signed var (pad at LSB, all data still accessible)
// unsigned shift may underflow (eg var-3 with var<3) -> cannot be converted
// data[...+c +:W1] is only fine for +var(add) and var unsigned // data[...+c +:W1] is only fine for +var(add) and var unsigned
// (+c cuts lower C bits, making them inaccessible, a signed var could try to access them) // (+c cuts lower C bits, making them inaccessible, a signed var could try to access them)
// either its an add or the variable port is A (it must be positive) // either its an add or the variable port is A (it must be positive)
@ -74,6 +75,8 @@ match add
// -> data[var+c +:W1] (with var signed) is illegal // -> data[var+c +:W1] (with var signed) is illegal
filter !(!offset_negative && varport_signed) filter !(!offset_negative && varport_signed)
// -> data >> (var-c) (with var unsigned) is illegal
filter !(offset_negative && !varport_signed)
// state-variables are assigned at the end only: // state-variables are assigned at the end only:
// shift the log2scale offset in-front of add to get true value: (var+c)<<N -> (var<<N)+(c<<N) // shift the log2scale offset in-front of add to get true value: (var+c)<<N -> (var<<N)+(c<<N)

15
tests/opt/bug4413.ys Normal file
View file

@ -0,0 +1,15 @@
read_verilog <<EOT
module top(
input wire shift,
input wire [4:0] data,
output wire out
);
wire [1:0] shift2 = shift - 1'b1;
assign out = data >> shift2;
endmodule
EOT
equiv_opt -assert peepopt