mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2026-08-10 08:01:14 +00:00
Code Activity

driver: disable exec unless --enable-exec

Browse source
This commit is contained in:
Emil J. Tywoniak 2026-08-03 11:21:52 +02:00
parent 07a615a283
commit 2bbde420a6
6 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
kernel/driver.cc
View file

@ -165,6 +165,7 @@ int main(int argc, char **argv)
cxxopts::value<std::vector<std::string>>(), "<plugin>")
("D,define", "set the specified Verilog define to <value> if supplied via command \"read -define\"",
cxxopts::value<std::vector<std::string>>(), "<define>[=<value>]")
("enable-exec", "enable the 'exec' command, which runs arbitrary shell commands")
("S,synth", "shortcut for calling the \"synth\" command, a default script for transforming " \
"the Verilog input to a gate-level netlist. For example: " \
"yosys -o output.blif -S input.v " \
@ -261,6 +262,7 @@ int main(int argc, char **argv)
passes_commands.push_back("synth");
run_shell = false;
}
if (result.count("enable-exec")) yosys_enable_exec = true;
if (result.count("C")) run_tcl_shell = true;
if (result.count("g")) log_force_debug++;
if (result.count("m")) plugin_filenames = result["m"].as<std::vector<std::string>>();

2
kernel/register.cc
View file

@ -218,6 +218,8 @@ void Pass::call(RTLIL::Design *design, std::string command)
return;
if (tok[0] == '!') {
if (!yosys_enable_exec)
log_cmd_error("The shell escape ('!') is disabled. Run Yosys with --enable-exec to enable it.\n");
#if defined(YOSYS_ENABLE_SPAWN)
cmd_buf = command.substr(command.find('!') + 1);
while (!cmd_buf.empty() && (cmd_buf.back() == ' ' || cmd_buf.back() == '\t' ||

1
kernel/yosys.cc
View file

@ -84,6 +84,7 @@ YOSYS_NAMESPACE_BEGIN
Autoidx autoidx(1);
int yosys_xtrace = 0;
bool yosys_write_versions = true;
bool yosys_enable_exec = false;
const char* yosys_maybe_version() {
if (yosys_write_versions)
return yosys_version_str;

1
kernel/yosys_common.h
View file

@ -296,6 +296,7 @@ private:
extern Autoidx autoidx;
extern int yosys_xtrace;
extern bool yosys_write_versions;
extern bool yosys_enable_exec;
const std::string *create_id_prefix(std::string_view file, int line, std::string_view func);
RTLIL::IdString new_id_suffix(std::string_view file, int line, std::string_view func, std::string_view suffix);

6
passes/cmds/exec.cc
View file

@ -49,7 +49,8 @@ struct ExecPass : public Pass {
log("\n");
log(" exec [options] -- [command]\n");
log("\n");
log("Execute a command in the operating system shell. All supplied arguments are\n");
log("Execute a command in the operating system shell. Enabled only\n");
log("when Yosys is run with --enable-exec. All supplied arguments are\n");
log("concatenated and passed as a command to popen(3). Whitespace is not guaranteed\n");
log("to be preserved, even if quoted. stdin and stderr are not connected, while\n");
log("stdout is logged unless the \"-q\" option is specified.\n");
@ -78,6 +79,9 @@ struct ExecPass : public Pass {
}
void execute(std::vector<std::string> args, RTLIL::Design *design) override
{
if (!yosys_enable_exec)
log_cmd_error("The 'exec' command is disabled. Run Yosys with --enable-exec to enable it.\n");
std::string cmd = "";
char buf[1024] = {};
std::string linebuf = "";

2
tests/gen_tests_makefile.py
View file

@ -26,12 +26,14 @@ def generate_target(name, command, deps = None):
print(f"\t@$(call run_test,{target}, $({target}_cmd))")
def generate_ys_test(ys_file, yosys_args="", commands=""):
yosys_args = f"--enable-exec {yosys_args}".strip()
cmd = f'$(YOSYS) -l {ys_file}.err {yosys_args} {ys_file} && mv {ys_file}.err {ys_file}.log'
if commands:
cmd += f"; \\\n{commands}"
generate_target(ys_file, cmd)
def generate_tcl_test(tcl_file, yosys_args="", commands=""):
yosys_args = f"--enable-exec {yosys_args}".strip()
cmd = f'$(YOSYS) -l {tcl_file}.err {yosys_args} {tcl_file} && mv {tcl_file}.err {tcl_file}.log'
if commands:
cmd += f"; \\\n{commands}"