mirrors/yosys
3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-11-03 21:09:12 +00:00
Code Activity

Merge pull request #3629 from YosysHQ/micko/clang_fixes

Browse source 
Fixes for some of clang scan-build detected issues
This commit is contained in:
Miodrag Milanović 2023-01-23 16:24:22 +01:00 • committed by GitHub
commit 245884a101
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 39 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

1
passes/cmds/bugpoint.cc
View file

@ -393,6 +393,7 @@ struct BugpointPass : public Pass {
}
}
}
delete design_copy;
return nullptr;
}

5
passes/cmds/design.cc
View file

@ -118,6 +118,9 @@ struct DesignPass : public Pass {
std::string save_name, load_name, as_name, delete_name;
std::vector<RTLIL::Module*> copy_src_modules;
if (!design)
log_cmd_error("No default design.\n");
size_t argidx;
for (argidx = 1; argidx < args.size(); argidx++)
{
@ -280,7 +283,7 @@ struct DesignPass : public Pass {
done[mod->name] = prefix;
}
while (!queue.empty())
while (!queue.empty() && copy_from_design)
{
pool<Module*> old_queue;
old_queue.swap(queue);

3
passes/opt/opt_ffinv.cc
View file

@ -64,6 +64,7 @@ struct OptFfInvWorker
log_assert(d_inv == nullptr);
d_inv = port.cell;
}
if (!d_inv) return false;
if (index.query_is_output(ff.sig_q))
return false;
@ -140,6 +141,7 @@ struct OptFfInvWorker
log_assert(d_lut == nullptr);
d_lut = port.cell;
}
if (!d_lut) return false;
if (index.query_is_output(ff.sig_q))
return false;
@ -167,6 +169,7 @@ struct OptFfInvWorker
log_assert(q_inv == nullptr);
q_inv = port.cell;
}
if (!q_inv) return false;
ff.flip_rst_bits({0});
ff.sig_q = q_inv->getPort(ID::Y);

2
passes/proc/proc_dff.cc
View file

@ -302,7 +302,7 @@ void proc_dff(RTLIL::Module *mod, RTLIL::Process *proc, ConstEval &ce)
ce.assign_map.apply(rstval);
ce.assign_map.apply(sig);
if (rstval == sig) {
if (rstval == sig && sync_level) {
if (sync_level->type == RTLIL::SyncType::ST1)
insig = mod->Mux(NEW_ID, insig, sig, sync_level->signal);
else