mirror of
https://code.forgejo.org/actions/checkout.git
synced 2026-03-19 14:53:12 +00:00
- Kill git process on timeout: use child_process.spawn directly for
timeout-eligible operations so we have a ChildProcess handle to send
SIGTERM (then SIGKILL after 5s). On Windows, SIGTERM is a forced kill
so the SIGKILL fallback is effectively a no-op there.
- Fix timeout:0 not working: replace falsy || coalescion with explicit
empty-string check so that '0' is not replaced by the default '300'.
- Refactor execGit to use an options object instead of 5 positional
parameters, eliminating error-prone filler args (false, false, {}).
- Pass allowAllExitCodes through to execGitWithTimeout so both code
paths have consistent behavior for non-zero exit codes.
- Add settled guard to prevent double-reject when both close and error
events fire on the spawned process.
- Handle null exit code (process killed by signal) as an error rather
than silently treating it as success.
- Capture stderr in error messages for the timeout path, matching the
information level of the non-timeout exec path.
- Log SIGKILL failures at debug level instead of empty catch block.
- Warn on customListeners being ignored in the timeout path.
- Emit core.warning() when invalid input values are silently replaced
with defaults, so users know their configuration was rejected.
- Add input validation in setTimeout (reject negative values).
- Clarify retry-max-attempts semantics: total attempts including the
initial attempt (3 = 1 initial + 2 retries).
- Remove Kubernetes probe references from descriptions.
- Use non-exhaustive list (e.g.) for network operations in docs to
avoid staleness if new operations are added.
- Add tests for timeout/retry input parsing (defaults, timeout:0,
custom values, invalid input with warnings, backoff clamping) and
command manager configuration (setTimeout, setRetryConfig, fetch).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
577 lines
15 KiB
TypeScript
577 lines
15 KiB
TypeScript
import * as exec from '@actions/exec'
|
|
import * as fshelper from '../lib/fs-helper'
|
|
import * as commandManager from '../lib/git-command-manager'
|
|
|
|
let git: commandManager.IGitCommandManager
|
|
let mockExec = jest.fn()
|
|
|
|
function createMockGit(): Promise<commandManager.IGitCommandManager> {
|
|
mockExec.mockImplementation((path, args, options) => {
|
|
if (args.includes('version')) {
|
|
options.listeners.stdout(Buffer.from('2.18'))
|
|
}
|
|
return 0
|
|
})
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
return commandManager.createCommandManager('test', false, false)
|
|
}
|
|
|
|
describe('git-auth-helper tests', () => {
|
|
beforeAll(async () => {})
|
|
|
|
beforeEach(async () => {
|
|
jest.spyOn(fshelper, 'fileExistsSync').mockImplementation(jest.fn())
|
|
jest.spyOn(fshelper, 'directoryExistsSync').mockImplementation(jest.fn())
|
|
})
|
|
|
|
afterEach(() => {
|
|
jest.restoreAllMocks()
|
|
})
|
|
|
|
afterAll(() => {})
|
|
|
|
it('branch list matches', async () => {
|
|
mockExec.mockImplementation((path, args, options) => {
|
|
console.log(args, options.listeners.stdout)
|
|
|
|
if (args.includes('version')) {
|
|
options.listeners.stdout(Buffer.from('2.18'))
|
|
return 0
|
|
}
|
|
|
|
if (args.includes('rev-parse')) {
|
|
options.listeners.stdline(Buffer.from('refs/heads/foo'))
|
|
options.listeners.stdline(Buffer.from('refs/heads/bar'))
|
|
return 0
|
|
}
|
|
|
|
return 1
|
|
})
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
|
|
let branches = await git.branchList(false)
|
|
|
|
expect(branches).toHaveLength(2)
|
|
expect(branches.sort()).toEqual(['foo', 'bar'].sort())
|
|
})
|
|
|
|
it('ambiguous ref name output is captured', async () => {
|
|
mockExec.mockImplementation((path, args, options) => {
|
|
console.log(args, options.listeners.stdout)
|
|
|
|
if (args.includes('version')) {
|
|
options.listeners.stdout(Buffer.from('2.18'))
|
|
return 0
|
|
}
|
|
|
|
if (args.includes('rev-parse')) {
|
|
options.listeners.stdline(Buffer.from('refs/heads/foo'))
|
|
// If refs/tags/v1 and refs/heads/tags/v1 existed on this repository
|
|
options.listeners.errline(
|
|
Buffer.from("error: refname 'tags/v1' is ambiguous")
|
|
)
|
|
return 0
|
|
}
|
|
|
|
return 1
|
|
})
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
|
|
let branches = await git.branchList(false)
|
|
|
|
expect(branches).toHaveLength(1)
|
|
expect(branches.sort()).toEqual(['foo'].sort())
|
|
})
|
|
})
|
|
|
|
describe('Test fetchDepth and fetchTags options', () => {
|
|
beforeEach(async () => {
|
|
jest.spyOn(fshelper, 'fileExistsSync').mockImplementation(jest.fn())
|
|
jest.spyOn(fshelper, 'directoryExistsSync').mockImplementation(jest.fn())
|
|
mockExec.mockImplementation((path, args, options) => {
|
|
console.log(args, options.listeners.stdout)
|
|
|
|
if (args.includes('version')) {
|
|
options.listeners.stdout(Buffer.from('2.18'))
|
|
}
|
|
|
|
return 0
|
|
})
|
|
})
|
|
|
|
afterEach(() => {
|
|
jest.restoreAllMocks()
|
|
})
|
|
|
|
it('should call execGit with the correct arguments when fetchDepth is 0', async () => {
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
|
|
const refSpec = ['refspec1', 'refspec2']
|
|
const options = {
|
|
filter: 'filterValue',
|
|
fetchDepth: 0
|
|
}
|
|
|
|
await git.fetch(refSpec, options)
|
|
|
|
expect(mockExec).toHaveBeenCalledWith(
|
|
expect.any(String),
|
|
[
|
|
'-c',
|
|
'protocol.version=2',
|
|
'fetch',
|
|
'--no-tags',
|
|
'--prune',
|
|
'--no-recurse-submodules',
|
|
'--filter=filterValue',
|
|
'origin',
|
|
'refspec1',
|
|
'refspec2'
|
|
],
|
|
expect.any(Object)
|
|
)
|
|
})
|
|
|
|
it('should call execGit with the correct arguments when fetchDepth is 0 and refSpec includes tags', async () => {
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
const refSpec = ['refspec1', 'refspec2', '+refs/tags/*:refs/tags/*']
|
|
const options = {
|
|
filter: 'filterValue',
|
|
fetchDepth: 0
|
|
}
|
|
|
|
await git.fetch(refSpec, options)
|
|
|
|
expect(mockExec).toHaveBeenCalledWith(
|
|
expect.any(String),
|
|
[
|
|
'-c',
|
|
'protocol.version=2',
|
|
'fetch',
|
|
'--no-tags',
|
|
'--prune',
|
|
'--no-recurse-submodules',
|
|
'--filter=filterValue',
|
|
'origin',
|
|
'refspec1',
|
|
'refspec2',
|
|
'+refs/tags/*:refs/tags/*'
|
|
],
|
|
expect.any(Object)
|
|
)
|
|
})
|
|
|
|
it('should call execGit with the correct arguments when fetchDepth is 1', async () => {
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
const refSpec = ['refspec1', 'refspec2']
|
|
const options = {
|
|
filter: 'filterValue',
|
|
fetchDepth: 1
|
|
}
|
|
|
|
await git.fetch(refSpec, options)
|
|
|
|
expect(mockExec).toHaveBeenCalledWith(
|
|
expect.any(String),
|
|
[
|
|
'-c',
|
|
'protocol.version=2',
|
|
'fetch',
|
|
'--no-tags',
|
|
'--prune',
|
|
'--no-recurse-submodules',
|
|
'--filter=filterValue',
|
|
'--depth=1',
|
|
'origin',
|
|
'refspec1',
|
|
'refspec2'
|
|
],
|
|
expect.any(Object)
|
|
)
|
|
})
|
|
|
|
it('should call execGit with the correct arguments when fetchDepth is 1 and refSpec includes tags', async () => {
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
const refSpec = ['refspec1', 'refspec2', '+refs/tags/*:refs/tags/*']
|
|
const options = {
|
|
filter: 'filterValue',
|
|
fetchDepth: 1
|
|
}
|
|
|
|
await git.fetch(refSpec, options)
|
|
|
|
expect(mockExec).toHaveBeenCalledWith(
|
|
expect.any(String),
|
|
[
|
|
'-c',
|
|
'protocol.version=2',
|
|
'fetch',
|
|
'--no-tags',
|
|
'--prune',
|
|
'--no-recurse-submodules',
|
|
'--filter=filterValue',
|
|
'--depth=1',
|
|
'origin',
|
|
'refspec1',
|
|
'refspec2',
|
|
'+refs/tags/*:refs/tags/*'
|
|
],
|
|
expect.any(Object)
|
|
)
|
|
})
|
|
|
|
it('should call execGit with the correct arguments when showProgress is true', async () => {
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
const refSpec = ['refspec1', 'refspec2']
|
|
const options = {
|
|
filter: 'filterValue',
|
|
showProgress: true
|
|
}
|
|
|
|
await git.fetch(refSpec, options)
|
|
|
|
expect(mockExec).toHaveBeenCalledWith(
|
|
expect.any(String),
|
|
[
|
|
'-c',
|
|
'protocol.version=2',
|
|
'fetch',
|
|
'--no-tags',
|
|
'--prune',
|
|
'--no-recurse-submodules',
|
|
'--progress',
|
|
'--filter=filterValue',
|
|
'origin',
|
|
'refspec1',
|
|
'refspec2'
|
|
],
|
|
expect.any(Object)
|
|
)
|
|
})
|
|
|
|
it('should call execGit with the correct arguments when fetchDepth is 42 and showProgress is true', async () => {
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
const refSpec = ['refspec1', 'refspec2']
|
|
const options = {
|
|
filter: 'filterValue',
|
|
fetchDepth: 42,
|
|
showProgress: true
|
|
}
|
|
|
|
await git.fetch(refSpec, options)
|
|
|
|
expect(mockExec).toHaveBeenCalledWith(
|
|
expect.any(String),
|
|
[
|
|
'-c',
|
|
'protocol.version=2',
|
|
'fetch',
|
|
'--no-tags',
|
|
'--prune',
|
|
'--no-recurse-submodules',
|
|
'--progress',
|
|
'--filter=filterValue',
|
|
'--depth=42',
|
|
'origin',
|
|
'refspec1',
|
|
'refspec2'
|
|
],
|
|
expect.any(Object)
|
|
)
|
|
})
|
|
|
|
it('should call execGit with the correct arguments when showProgress is true and refSpec includes tags', async () => {
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
const refSpec = ['refspec1', 'refspec2', '+refs/tags/*:refs/tags/*']
|
|
const options = {
|
|
filter: 'filterValue',
|
|
showProgress: true
|
|
}
|
|
|
|
await git.fetch(refSpec, options)
|
|
|
|
expect(mockExec).toHaveBeenCalledWith(
|
|
expect.any(String),
|
|
[
|
|
'-c',
|
|
'protocol.version=2',
|
|
'fetch',
|
|
'--no-tags',
|
|
'--prune',
|
|
'--no-recurse-submodules',
|
|
'--progress',
|
|
'--filter=filterValue',
|
|
'origin',
|
|
'refspec1',
|
|
'refspec2',
|
|
'+refs/tags/*:refs/tags/*'
|
|
],
|
|
expect.any(Object)
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('git user-agent with orchestration ID', () => {
|
|
beforeEach(async () => {
|
|
jest.spyOn(fshelper, 'fileExistsSync').mockImplementation(jest.fn())
|
|
jest.spyOn(fshelper, 'directoryExistsSync').mockImplementation(jest.fn())
|
|
})
|
|
|
|
afterEach(() => {
|
|
jest.restoreAllMocks()
|
|
// Clean up environment variable to prevent test pollution
|
|
delete process.env['ACTIONS_ORCHESTRATION_ID']
|
|
})
|
|
|
|
it('should include orchestration ID in user-agent when ACTIONS_ORCHESTRATION_ID is set', async () => {
|
|
const orchId = 'test-orch-id-12345'
|
|
process.env['ACTIONS_ORCHESTRATION_ID'] = orchId
|
|
|
|
let capturedEnv: any = null
|
|
mockExec.mockImplementation((path, args, options) => {
|
|
if (args.includes('version')) {
|
|
options.listeners.stdout(Buffer.from('2.18'))
|
|
}
|
|
// Capture env on any command
|
|
capturedEnv = options.env
|
|
return 0
|
|
})
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
|
|
// Call a git command to trigger env capture after user-agent is set
|
|
await git.init()
|
|
|
|
// Verify the user agent includes the orchestration ID
|
|
expect(git).toBeDefined()
|
|
expect(capturedEnv).toBeDefined()
|
|
expect(capturedEnv['GIT_HTTP_USER_AGENT']).toBe(
|
|
`git/2.18 (github-actions-checkout) actions_orchestration_id/${orchId}`
|
|
)
|
|
})
|
|
|
|
it('should sanitize invalid characters in orchestration ID', async () => {
|
|
const orchId = 'test (with) special/chars'
|
|
process.env['ACTIONS_ORCHESTRATION_ID'] = orchId
|
|
|
|
let capturedEnv: any = null
|
|
mockExec.mockImplementation((path, args, options) => {
|
|
if (args.includes('version')) {
|
|
options.listeners.stdout(Buffer.from('2.18'))
|
|
}
|
|
// Capture env on any command
|
|
capturedEnv = options.env
|
|
return 0
|
|
})
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
|
|
// Call a git command to trigger env capture after user-agent is set
|
|
await git.init()
|
|
|
|
// Verify the user agent has sanitized orchestration ID (spaces, parentheses, slash replaced)
|
|
expect(git).toBeDefined()
|
|
expect(capturedEnv).toBeDefined()
|
|
expect(capturedEnv['GIT_HTTP_USER_AGENT']).toBe(
|
|
'git/2.18 (github-actions-checkout) actions_orchestration_id/test__with__special_chars'
|
|
)
|
|
})
|
|
|
|
it('should not modify user-agent when ACTIONS_ORCHESTRATION_ID is not set', async () => {
|
|
delete process.env['ACTIONS_ORCHESTRATION_ID']
|
|
|
|
let capturedEnv: any = null
|
|
mockExec.mockImplementation((path, args, options) => {
|
|
if (args.includes('version')) {
|
|
options.listeners.stdout(Buffer.from('2.18'))
|
|
}
|
|
// Capture env on any command
|
|
capturedEnv = options.env
|
|
return 0
|
|
})
|
|
jest.spyOn(exec, 'exec').mockImplementation(mockExec)
|
|
|
|
const workingDirectory = 'test'
|
|
const lfs = false
|
|
const doSparseCheckout = false
|
|
git = await commandManager.createCommandManager(
|
|
workingDirectory,
|
|
lfs,
|
|
doSparseCheckout
|
|
)
|
|
|
|
// Call a git command to trigger env capture after user-agent is set
|
|
await git.init()
|
|
|
|
// Verify the user agent does NOT contain orchestration ID
|
|
expect(git).toBeDefined()
|
|
expect(capturedEnv).toBeDefined()
|
|
expect(capturedEnv['GIT_HTTP_USER_AGENT']).toBe(
|
|
'git/2.18 (github-actions-checkout)'
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('timeout and retry configuration', () => {
|
|
beforeEach(async () => {
|
|
jest.spyOn(fshelper, 'fileExistsSync').mockImplementation(jest.fn())
|
|
jest.spyOn(fshelper, 'directoryExistsSync').mockImplementation(jest.fn())
|
|
})
|
|
|
|
afterEach(() => {
|
|
jest.restoreAllMocks()
|
|
})
|
|
|
|
it('setTimeout accepts valid values', async () => {
|
|
git = await createMockGit()
|
|
git.setTimeout(30)
|
|
git.setTimeout(0)
|
|
})
|
|
|
|
it('setTimeout rejects negative values', async () => {
|
|
git = await createMockGit()
|
|
expect(() => git.setTimeout(-1)).toThrow(/non-negative/)
|
|
})
|
|
|
|
it('setRetryConfig accepts valid parameters', async () => {
|
|
git = await createMockGit()
|
|
git.setRetryConfig(5, 2, 15)
|
|
})
|
|
|
|
it('setRetryConfig rejects min > max backoff', async () => {
|
|
git = await createMockGit()
|
|
expect(() => git.setRetryConfig(3, 20, 5)).toThrow(
|
|
/min seconds should be less than or equal to max seconds/
|
|
)
|
|
})
|
|
|
|
it('fetch without timeout uses exec', async () => {
|
|
git = await createMockGit()
|
|
// timeout defaults to 0 (disabled)
|
|
|
|
mockExec.mockClear()
|
|
await git.fetch(['refs/heads/main'], {})
|
|
|
|
// exec.exec is used (via retryHelper) when no timeout
|
|
const fetchCalls = mockExec.mock.calls.filter(
|
|
(call: any[]) => (call[1] as string[]).includes('fetch')
|
|
)
|
|
expect(fetchCalls).toHaveLength(1)
|
|
})
|
|
|
|
it('fetch with timeout does not use exec', async () => {
|
|
git = await createMockGit()
|
|
// Short timeout and single attempt so the test completes quickly
|
|
git.setTimeout(1)
|
|
git.setRetryConfig(1, 0, 0)
|
|
|
|
mockExec.mockClear()
|
|
|
|
// fetch will use spawn path (which will fail/timeout since there's
|
|
// no real git repo), but we verify exec.exec was NOT called for fetch
|
|
try {
|
|
await git.fetch(['refs/heads/main'], {})
|
|
} catch {
|
|
// Expected: spawn will fail/timeout in test environment
|
|
}
|
|
|
|
const fetchCalls = mockExec.mock.calls.filter(
|
|
(call: any[]) => (call[1] as string[]).includes('fetch')
|
|
)
|
|
expect(fetchCalls).toHaveLength(0)
|
|
}, 10000)
|
|
})
|